syntax: Require issues for unstable features

alexcrichton · alexcrichton · commit 6634777ae0a8 · 2015-08-15T18:09:16.000-07:00
This turns an `#[unstable]` tag without an `issue` annotation into a hard error
to ensure that we've always got a tracking issue for unstable features in the
standard library.
diff --git a/src/libsyntax/attr.rs b/src/libsyntax/attr.rs
@@ -532,10 +532,9 @@ fn find_stability_generic<'a,
         }
     } else if stab.as_ref().map_or(false, |s| s.level == Unstable && s.issue.is_none()) {
         // non-deprecated unstable items need to point to issues.
-        // FIXME: uncomment this error
-        // diagnostic.span_err(item_sp,
-        //                     "non-deprecated unstable items need to point \
-        //                      to an issue with `issue = \"NNN\"`");
+        diagnostic.span_err(item_sp,
+                            "non-deprecated unstable items need to point \
+                             to an issue with `issue = \"NNN\"`");
     }
 
     (stab, used_attrs)

Original file line number	Diff line number	Diff line change
`@@ -532,10 +532,9 @@ fn find_stability_generic<'a,`
`532`	`532`	`}`
`533`	`533`	`} else if stab.as_ref().map_or(false, \|s\| s.level == Unstable && s.issue.is_none()) {`
`534`	`534`	`// non-deprecated unstable items need to point to issues.`
`535`		`- // FIXME: uncomment this error`
`536`		`- // diagnostic.span_err(item_sp,`
`537`		`- // "non-deprecated unstable items need to point \`
`538`		- // to an issue with `issue = \"NNN\"`");
	`535`	`+ diagnostic.span_err(item_sp,`
	`536`	`+ "non-deprecated unstable items need to point \`
	`537`	+ to an issue with `issue = \"NNN\"`");
`539`	`538`	`}`
`540`	`539`
`541`	`540`	`(stab, used_attrs)`