File tree Expand file tree Collapse file tree 3 files changed +7
-3
lines changed Expand file tree Collapse file tree 3 files changed +7
-3
lines changed Original file line number Diff line number Diff line change 1
1
---
2
2
refs/heads/master: c044791d80ea0dc5c4b57b6030a67b69f8510239
3
- refs/heads/snap-stage3: 0ec3183df8d0cdccc735fa6572d664b43dbb5e31
3
+ refs/heads/snap-stage3: c654a07d29c77b5a023cb9d36dfc61811349f64e
4
4
refs/heads/try: b53c0f93eedcdedd4fd89bccc5a3a09d1c5cd23e
5
5
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
6
6
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
Original file line number Diff line number Diff line change @@ -203,10 +203,12 @@ impl LintPass for TypeLimits {
203
203
} else {
204
204
t
205
205
} ;
206
- let ( min , max) = int_ty_range ( int_type) ;
206
+ let ( _ , max) = int_ty_range ( int_type) ;
207
207
let negative = self . negated_expr_id == e. id ;
208
208
209
- if ( negative && min != i64:: MIN && v > -min as u64 ) ||
209
+ // Detect literal value out of range [min, max] inclusive
210
+ // avoiding use of -min to prevent overflow/panic
211
+ if ( negative && v > max as u64 + 1 ) ||
210
212
( !negative && v > max as u64 ) {
211
213
cx. span_lint ( OVERFLOWING_LITERALS , e. span ,
212
214
& * format ! ( "literal out of range for {:?}" , t) ) ;
Original file line number Diff line number Diff line change @@ -52,6 +52,8 @@ fn main() {
52
52
let x = 9223372036854775808_i64 ; //~ error: literal out of range for i64
53
53
let x = -9223372036854775808_i64 ; // should be OK
54
54
let x = 18446744073709551615_i64 ; //~ error: literal out of range for i64
55
+ let x: i64 = -9223372036854775809 ; //~ error: literal out of range for i64
56
+ let x = -9223372036854775809_i64 ; //~ error: literal out of range for i64
55
57
56
58
let x = -3.40282348e+38_f32 ; //~ error: literal out of range for f32
57
59
let x = 3.40282348e+38_f32 ; //~ error: literal out of range for f32
You can’t perform that action at this time.
0 commit comments