Skip to content

Commit 66b44c1

Browse files
committed
---
yaml --- r: 218677 b: refs/heads/snap-stage3 c: c654a07 h: refs/heads/master i: 218675: 0e9a052 v: v3
1 parent 8ae7460 commit 66b44c1

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
refs/heads/master: c044791d80ea0dc5c4b57b6030a67b69f8510239
3-
refs/heads/snap-stage3: 0ec3183df8d0cdccc735fa6572d664b43dbb5e31
3+
refs/heads/snap-stage3: c654a07d29c77b5a023cb9d36dfc61811349f64e
44
refs/heads/try: b53c0f93eedcdedd4fd89bccc5a3a09d1c5cd23e
55
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
66
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596

branches/snap-stage3/src/librustc_lint/builtin.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,10 +203,12 @@ impl LintPass for TypeLimits {
203203
} else {
204204
t
205205
};
206-
let (min, max) = int_ty_range(int_type);
206+
let (_, max) = int_ty_range(int_type);
207207
let negative = self.negated_expr_id == e.id;
208208

209-
if (negative && min != i64::MIN && v > -min as u64) ||
209+
// Detect literal value out of range [min, max] inclusive
210+
// avoiding use of -min to prevent overflow/panic
211+
if (negative && v > max as u64 + 1) ||
210212
(!negative && v > max as u64) {
211213
cx.span_lint(OVERFLOWING_LITERALS, e.span,
212214
&*format!("literal out of range for {:?}", t));

branches/snap-stage3/src/test/compile-fail/lint-type-overflow.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ fn main() {
5252
let x = 9223372036854775808_i64; //~ error: literal out of range for i64
5353
let x = -9223372036854775808_i64; // should be OK
5454
let x = 18446744073709551615_i64; //~ error: literal out of range for i64
55+
let x: i64 = -9223372036854775809; //~ error: literal out of range for i64
56+
let x = -9223372036854775809_i64; //~ error: literal out of range for i64
5557

5658
let x = -3.40282348e+38_f32; //~ error: literal out of range for f32
5759
let x = 3.40282348e+38_f32; //~ error: literal out of range for f32

0 commit comments

Comments
 (0)