Skip to content

Commit 69210a9

Browse files
eefriedmaneefriedman
committed
Rename _nopanic methods to remove the suffix.
Just `sed s/_nopanic//g`. Hopefully makes libsyntax a bit more readable.
1 parent 3519eff commit 69210a9

File tree

10 files changed

+87
-87
lines changed

10 files changed

+87
-87
lines changed

‎src/libsyntax/ext/asm.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ pub fn expand_asm<'cx>(cx: &'cx mut ExtCtxt, sp: Span, tts: &[ast::TokenTree])
7979
cx.span_err(sp, "malformed inline assembly");
8080
return DummyResult::expr(sp);
8181
}
82-
let (s, style) = match expr_to_string(cx, panictry!(p.parse_expr_nopanic()),
82+
let (s, style) = match expr_to_string(cx, panictry!(p.parse_expr()),
8383
"inline assembly must be a string literal") {
8484
Some((s, st)) => (s, st),
8585
// let compilation continue
@@ -102,7 +102,7 @@ pub fn expand_asm<'cx>(cx: &'cx mut ExtCtxt, sp: Span, tts: &[ast::TokenTree])
102102
let span = p.last_span;
103103

104104
panictry!(p.expect(&token::OpenDelim(token::Paren)));
105-
let out = panictry!(p.parse_expr_nopanic());
105+
let out = panictry!(p.parse_expr());
106106
panictry!(p.expect(&token::CloseDelim(token::Paren)));
107107

108108
// Expands a read+write operand into two operands.
@@ -146,7 +146,7 @@ pub fn expand_asm<'cx>(cx: &'cx mut ExtCtxt, sp: Span, tts: &[ast::TokenTree])
146146
}
147147

148148
panictry!(p.expect(&token::OpenDelim(token::Paren)));
149-
let input = panictry!(p.parse_expr_nopanic());
149+
let input = panictry!(p.parse_expr());
150150
panictry!(p.expect(&token::CloseDelim(token::Paren)));
151151

152152
inputs.push((constraint, input));

‎src/libsyntax/ext/base.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,7 @@ pub fn get_single_str_from_tts(cx: &mut ExtCtxt,
809809
cx.span_err(sp, &format!("{} takes 1 argument", name));
810810
return None
811811
}
812-
let ret = cx.expander().fold_expr(panictry!(p.parse_expr_nopanic()));
812+
let ret = cx.expander().fold_expr(panictry!(p.parse_expr()));
813813
if p.token != token::Eof {
814814
cx.span_err(sp, &format!("{} takes 1 argument", name));
815815
}
@@ -826,7 +826,7 @@ pub fn get_exprs_from_tts(cx: &mut ExtCtxt,
826826
let mut p = cx.new_parser_from_tts(tts);
827827
let mut es = Vec::new();
828828
while p.token != token::Eof {
829-
es.push(cx.expander().fold_expr(panictry!(p.parse_expr_nopanic())));
829+
es.push(cx.expander().fold_expr(panictry!(p.parse_expr())));
830830
if panictry!(p.eat(&token::Comma)){
831831
continue;
832832
}

‎src/libsyntax/ext/format.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ fn parse_args(ecx: &mut ExtCtxt, sp: Span, tts: &[ast::TokenTree])
9393
ecx.span_err(sp, "requires at least a format string argument");
9494
return None;
9595
}
96-
let fmtstr = panictry!(p.parse_expr_nopanic());
96+
let fmtstr = panictry!(p.parse_expr());
9797
let mut named = false;
9898
while p.token != token::Eof {
9999
if !panictry!(p.eat(&token::Comma)) {
@@ -124,7 +124,7 @@ fn parse_args(ecx: &mut ExtCtxt, sp: Span, tts: &[ast::TokenTree])
124124
let name: &str = &ident.name.as_str();
125125

126126
panictry!(p.expect(&token::Eq));
127-
let e = panictry!(p.parse_expr_nopanic());
127+
let e = panictry!(p.parse_expr());
128128
match names.get(name) {
129129
None => {}
130130
Some(prev) => {
@@ -138,7 +138,7 @@ fn parse_args(ecx: &mut ExtCtxt, sp: Span, tts: &[ast::TokenTree])
138138
order.push(name.to_string());
139139
names.insert(name.to_string(), e);
140140
} else {
141-
args.push(panictry!(p.parse_expr_nopanic()));
141+
args.push(panictry!(p.parse_expr()));
142142
}
143143
}
144144
Some((fmtstr, args, order, names))

‎src/libsyntax/ext/quote.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -701,7 +701,7 @@ fn parse_arguments_to_quote(cx: &ExtCtxt, tts: &[TokenTree])
701701
let mut p = cx.new_parser_from_tts(tts);
702702
p.quote_depth += 1;
703703

704-
let cx_expr = panictry!(p.parse_expr_nopanic());
704+
let cx_expr = panictry!(p.parse_expr());
705705
if !panictry!(p.eat(&token::Comma)) {
706706
panic!(p.fatal("expected token `,`"));
707707
}

‎src/libsyntax/ext/source_util.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,13 @@ pub fn expand_include<'cx>(cx: &'cx mut ExtCtxt, sp: Span, tts: &[ast::TokenTree
109109
}
110110
impl<'a> base::MacResult for ExpandResult<'a> {
111111
fn make_expr(mut self: Box<ExpandResult<'a>>) -> Option<P<ast::Expr>> {
112-
Some(panictry!(self.p.parse_expr_nopanic()))
112+
Some(panictry!(self.p.parse_expr()))
113113
}
114114
fn make_items(mut self: Box<ExpandResult<'a>>)
115115
-> Option<SmallVector<P<ast::Item>>> {
116116
let mut ret = SmallVector::zero();
117117
while self.p.token != token::Eof {
118-
match panictry!(self.p.parse_item_nopanic()) {
118+
match panictry!(self.p.parse_item()) {
119119
Some(item) => ret.push(item),
120120
None => panic!(self.p.span_fatal(
121121
self.p.span,

‎src/libsyntax/ext/tt/macro_parser.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -501,18 +501,18 @@ pub fn parse_nt(p: &mut Parser, sp: Span, name: &str) -> Nonterminal {
501501
// check at the beginning and the parser checks after each bump
502502
panictry!(p.check_unknown_macro_variable());
503503
match name {
504-
"item" => match panictry!(p.parse_item_nopanic()) {
504+
"item" => match panictry!(p.parse_item()) {
505505
Some(i) => token::NtItem(i),
506506
None => panic!(p.fatal("expected an item keyword"))
507507
},
508508
"block" => token::NtBlock(panictry!(p.parse_block())),
509-
"stmt" => match panictry!(p.parse_stmt_nopanic()) {
509+
"stmt" => match panictry!(p.parse_stmt()) {
510510
Some(s) => token::NtStmt(s),
511511
None => panic!(p.fatal("expected a statement"))
512512
},
513-
"pat" => token::NtPat(panictry!(p.parse_pat_nopanic())),
514-
"expr" => token::NtExpr(panictry!(p.parse_expr_nopanic())),
515-
"ty" => token::NtTy(panictry!(p.parse_ty_nopanic())),
513+
"pat" => token::NtPat(panictry!(p.parse_pat())),
514+
"expr" => token::NtExpr(panictry!(p.parse_expr())),
515+
"ty" => token::NtTy(panictry!(p.parse_ty())),
516516
// this could be handled like a token, since it is one
517517
"ident" => match p.token {
518518
token::Ident(sn,b) => { panictry!(p.bump()); token::NtIdent(Box::new(sn),b) }

‎src/libsyntax/ext/tt/macro_rules.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,18 +67,18 @@ impl<'a> ParserAnyMacro<'a> {
6767

6868
impl<'a> MacResult for ParserAnyMacro<'a> {
6969
fn make_expr(self: Box<ParserAnyMacro<'a>>) -> Option<P<ast::Expr>> {
70-
let ret = panictry!(self.parser.borrow_mut().parse_expr_nopanic());
70+
let ret = panictry!(self.parser.borrow_mut().parse_expr());
7171
self.ensure_complete_parse(true);
7272
Some(ret)
7373
}
7474
fn make_pat(self: Box<ParserAnyMacro<'a>>) -> Option<P<ast::Pat>> {
75-
let ret = panictry!(self.parser.borrow_mut().parse_pat_nopanic());
75+
let ret = panictry!(self.parser.borrow_mut().parse_pat());
7676
self.ensure_complete_parse(false);
7777
Some(ret)
7878
}
7979
fn make_items(self: Box<ParserAnyMacro<'a>>) -> Option<SmallVector<P<ast::Item>>> {
8080
let mut ret = SmallVector::zero();
81-
while let Some(item) = panictry!(self.parser.borrow_mut().parse_item_nopanic()) {
81+
while let Some(item) = panictry!(self.parser.borrow_mut().parse_item()) {
8282
ret.push(item);
8383
}
8484
self.ensure_complete_parse(false);
@@ -106,7 +106,7 @@ impl<'a> MacResult for ParserAnyMacro<'a> {
106106
let mut parser = self.parser.borrow_mut();
107107
match parser.token {
108108
token::Eof => break,
109-
_ => match parser.parse_stmt_nopanic() {
109+
_ => match parser.parse_stmt() {
110110
Ok(maybe_stmt) => match maybe_stmt {
111111
Some(stmt) => ret.push(stmt),
112112
None => (),
@@ -120,7 +120,7 @@ impl<'a> MacResult for ParserAnyMacro<'a> {
120120
}
121121

122122
fn make_ty(self: Box<ParserAnyMacro<'a>>) -> Option<P<ast::Ty>> {
123-
let ret = panictry!(self.parser.borrow_mut().parse_ty_nopanic());
123+
let ret = panictry!(self.parser.borrow_mut().parse_ty());
124124
self.ensure_complete_parse(true);
125125
Some(ret)
126126
}

‎src/libsyntax/parse/mod.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ pub fn parse_expr_from_source_str(name: String,
116116
sess: &ParseSess)
117117
-> P<ast::Expr> {
118118
let mut p = new_parser_from_source_str(sess, cfg, name, source);
119-
maybe_aborted(panictry!(p.parse_expr_nopanic()), p)
119+
maybe_aborted(panictry!(p.parse_expr()), p)
120120
}
121121

122122
pub fn parse_item_from_source_str(name: String,
@@ -125,7 +125,7 @@ pub fn parse_item_from_source_str(name: String,
125125
sess: &ParseSess)
126126
-> Option<P<ast::Item>> {
127127
let mut p = new_parser_from_source_str(sess, cfg, name, source);
128-
maybe_aborted(panictry!(p.parse_item_nopanic()), p)
128+
maybe_aborted(panictry!(p.parse_item()), p)
129129
}
130130

131131
pub fn parse_meta_from_source_str(name: String,
@@ -148,7 +148,7 @@ pub fn parse_stmt_from_source_str(name: String,
148148
name,
149149
source
150150
);
151-
maybe_aborted(panictry!(p.parse_stmt_nopanic()), p)
151+
maybe_aborted(panictry!(p.parse_stmt()), p)
152152
}
153153

154154
// Warning: This parses with quote_depth > 0, which is not the default.
@@ -882,7 +882,7 @@ mod tests {
882882
#[test] fn parse_ident_pat () {
883883
let sess = ParseSess::new();
884884
let mut parser = string_to_parser(&sess, "b".to_string());
885-
assert!(panictry!(parser.parse_pat_nopanic())
885+
assert!(panictry!(parser.parse_pat())
886886
== P(ast::Pat{
887887
id: ast::DUMMY_NODE_ID,
888888
node: ast::PatIdent(ast::BindByValue(ast::MutImmutable),

0 commit comments

Comments
 (0)