Skip to content

Commit 69a4d15

Browse files
committed
---
yaml --- r: 135759 b: refs/heads/auto c: 4504412 h: refs/heads/master i: 135757: 0c0b776 135755: c0db778 135751: 11c1839 135743: cdc45e1 v: v3
1 parent 551fc5b commit 69a4d15

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ refs/heads/try3: 9387340aab40a73e8424c48fd42f0c521a4875c0
1313
refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
1414
refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
1515
refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
16-
refs/heads/auto: 333592edde810324c9730a89372fa5164d10871d
16+
refs/heads/auto: 45044124e46bbfd1ab9869ffce71259ae93866ff
1717
refs/heads/servo: af82457af293e2a842ba6b7759b70288da276167
1818
refs/tags/release-0.6: b4ebcfa1812664df5e142f0134a5faea3918544c
1919
refs/tags/0.1: b19db808c2793fe2976759b85a355c3ad8c8b336

branches/auto/src/librustc/lint/builtin.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -871,13 +871,17 @@ impl NonSnakeCase {
871871
fn to_snake_case(str: &str) -> String {
872872
let mut words = vec![];
873873
for s in str.split('_') {
874+
let mut last_upper = false;
874875
let mut buf = String::new();
875876
if s.is_empty() { continue; }
876877
for ch in s.chars() {
877-
if !buf.is_empty() && buf.as_slice() != "'" && ch.is_uppercase() {
878+
if !buf.is_empty() && buf.as_slice() != "'"
879+
&& ch.is_uppercase()
880+
&& !last_upper {
878881
words.push(buf);
879882
buf = String::new();
880883
}
884+
last_upper = ch.is_uppercase();
881885
buf.push_char(ch.to_lowercase());
882886
}
883887
words.push(buf);

branches/auto/src/test/compile-fail/lint-non-snake-case-functions.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,14 @@ impl Foo {
2323

2424
pub fn xyZ(&mut self) {}
2525
//~^ ERROR method `xyZ` should have a snake case name such as `xy_z`
26+
27+
fn render_HTML() {}
28+
//~^ ERROR method `render_HTML` should have a snake case name such as `render_html`
2629
}
2730

2831
trait X {
2932
fn ABC();
30-
//~^ ERROR trait method `ABC` should have a snake case name such as `a_b_c`
33+
//~^ ERROR trait method `ABC` should have a snake case name such as `abc`
3134

3235
fn a_b_C(&self) {}
3336
//~^ ERROR trait method `a_b_C` should have a snake case name such as `a_b_c`

0 commit comments

Comments
 (0)