Skip to content

Commit 6d7a0c8

Browse files
author
blake2-ppc
committed
std: Use do blocks instead of for with .iter_bytes()
1 parent 18d124b commit 6d7a0c8

File tree

2 files changed

+49
-33
lines changed

2 files changed

+49
-33
lines changed

src/libstd/hash.rs

Lines changed: 45 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -85,38 +85,44 @@ impl<A:IterBytes> Hash for A {
8585
#[inline]
8686
fn hash_keyed(&self, k0: u64, k1: u64) -> u64 {
8787
let mut s = State::new(k0, k1);
88-
for self.iter_bytes(true) |bytes| {
88+
do self.iter_bytes(true) |bytes| {
8989
s.input(bytes);
90-
}
90+
true
91+
};
9192
s.result_u64()
9293
}
9394
}
9495

9596
fn hash_keyed_2<A: IterBytes,
9697
B: IterBytes>(a: &A, b: &B, k0: u64, k1: u64) -> u64 {
9798
let mut s = State::new(k0, k1);
98-
for a.iter_bytes(true) |bytes| {
99+
do a.iter_bytes(true) |bytes| {
99100
s.input(bytes);
100-
}
101-
for b.iter_bytes(true) |bytes| {
101+
true
102+
};
103+
do b.iter_bytes(true) |bytes| {
102104
s.input(bytes);
103-
}
105+
true
106+
};
104107
s.result_u64()
105108
}
106109

107110
fn hash_keyed_3<A: IterBytes,
108111
B: IterBytes,
109112
C: IterBytes>(a: &A, b: &B, c: &C, k0: u64, k1: u64) -> u64 {
110113
let mut s = State::new(k0, k1);
111-
for a.iter_bytes(true) |bytes| {
114+
do a.iter_bytes(true) |bytes| {
112115
s.input(bytes);
113-
}
114-
for b.iter_bytes(true) |bytes| {
116+
true
117+
};
118+
do b.iter_bytes(true) |bytes| {
115119
s.input(bytes);
116-
}
117-
for c.iter_bytes(true) |bytes| {
120+
true
121+
};
122+
do c.iter_bytes(true) |bytes| {
118123
s.input(bytes);
119-
}
124+
true
125+
};
120126
s.result_u64()
121127
}
122128

@@ -132,18 +138,22 @@ fn hash_keyed_4<A: IterBytes,
132138
k1: u64)
133139
-> u64 {
134140
let mut s = State::new(k0, k1);
135-
for a.iter_bytes(true) |bytes| {
141+
do a.iter_bytes(true) |bytes| {
136142
s.input(bytes);
137-
}
138-
for b.iter_bytes(true) |bytes| {
143+
true
144+
};
145+
do b.iter_bytes(true) |bytes| {
139146
s.input(bytes);
140-
}
141-
for c.iter_bytes(true) |bytes| {
147+
true
148+
};
149+
do c.iter_bytes(true) |bytes| {
142150
s.input(bytes);
143-
}
144-
for d.iter_bytes(true) |bytes| {
151+
true
152+
};
153+
do d.iter_bytes(true) |bytes| {
145154
s.input(bytes);
146-
}
155+
true
156+
};
147157
s.result_u64()
148158
}
149159

@@ -161,21 +171,26 @@ fn hash_keyed_5<A: IterBytes,
161171
k1: u64)
162172
-> u64 {
163173
let mut s = State::new(k0, k1);
164-
for a.iter_bytes(true) |bytes| {
174+
do a.iter_bytes(true) |bytes| {
165175
s.input(bytes);
166-
}
167-
for b.iter_bytes(true) |bytes| {
176+
true
177+
};
178+
do b.iter_bytes(true) |bytes| {
168179
s.input(bytes);
169-
}
170-
for c.iter_bytes(true) |bytes| {
180+
true
181+
};
182+
do c.iter_bytes(true) |bytes| {
171183
s.input(bytes);
172-
}
173-
for d.iter_bytes(true) |bytes| {
184+
true
185+
};
186+
do d.iter_bytes(true) |bytes| {
174187
s.input(bytes);
175-
}
176-
for e.iter_bytes(true) |bytes| {
188+
true
189+
};
190+
do e.iter_bytes(true) |bytes| {
177191
s.input(bytes);
178-
}
192+
true
193+
};
179194
s.result_u64()
180195
}
181196

src/libstd/to_bytes.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,9 +353,10 @@ pub trait ToBytes {
353353
impl<A:IterBytes> ToBytes for A {
354354
fn to_bytes(&self, lsb0: bool) -> ~[u8] {
355355
do io::with_bytes_writer |wr| {
356-
for self.iter_bytes(lsb0) |bytes| {
357-
wr.write(bytes)
358-
}
356+
do self.iter_bytes(lsb0) |bytes| {
357+
wr.write(bytes);
358+
true
359+
};
359360
}
360361
}
361362
}

0 commit comments

Comments
 (0)