Skip to content

Commit 6ed6791

Browse files
author
Eric Holk
committed
Removing dead upcall_join. Closes #509.
1 parent a5563e1 commit 6ed6791

File tree

3 files changed

+0
-24
lines changed

3 files changed

+0
-24
lines changed

src/comp/back/upcall.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ type upcalls =
4040
ValueRef clone_chan,
4141
ValueRef _yield,
4242
ValueRef sleep,
43-
ValueRef _join,
4443
ValueRef send,
4544
ValueRef recv,
4645
ValueRef _fail,
@@ -91,7 +90,6 @@ fn declare_upcalls(type_names tn, ModuleRef llmod) -> @upcalls {
9190
T_opaque_chan_ptr()),
9291
_yield=dv("yield", empty_vec),
9392
sleep=dv("sleep", [T_size_t()]),
94-
_join=dv("join", [T_taskptr(tn)]),
9593
send=dv("send", [T_opaque_chan_ptr(), T_ptr(T_i8())]),
9694
recv=dv("recv", [T_ptr(T_ptr(T_i8())), T_opaque_port_ptr()]),
9795
_fail=dv("fail", [T_ptr(T_i8()), T_ptr(T_i8()), T_size_t()]),

src/rt/rust_upcall.cpp

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -195,27 +195,6 @@ upcall_sleep(rust_task *task, size_t time_in_us) {
195195
task->yield(2, time_in_us);
196196
}
197197

198-
extern "C" CDECL void
199-
upcall_join(rust_task *task, maybe_proxy<rust_task> *target) {
200-
LOG_UPCALL_ENTRY(task);
201-
202-
if (target->is_proxy()) {
203-
rust_handle<rust_task> *task_handle = target->as_proxy()->handle();
204-
notify_message::send(notify_message::JOIN, "join",
205-
task->get_handle(), task_handle);
206-
task->block(task_handle, "joining remote task");
207-
task->yield(2);
208-
} else {
209-
rust_task *target_task = target->referent();
210-
// If the other task is already dying, we don't have to wait for it.
211-
if (target_task->dead() == false) {
212-
target_task->tasks_waiting_to_join.push(task);
213-
task->block(target_task, "joining local task");
214-
task->yield(2);
215-
}
216-
}
217-
}
218-
219198
/**
220199
* Buffers a chunk of data in the specified channel.
221200
*

src/rt/rustrt.def.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ upcall_get_type_desc
5151
upcall_grow_task
5252
upcall_ivec_resize
5353
upcall_ivec_spill
54-
upcall_join
5554
upcall_kill
5655
upcall_log_double
5756
upcall_log_float

0 commit comments

Comments
 (0)