stdlib: Fix a crazy underflow bug in _uint.parse_buf. Oops.

pcwalton · pcwalton · commit 73044b3455b7 · 2011-04-27T11:49:06.000-07:00
diff --git a/src/lib/_uint.rs b/src/lib/_uint.rs
@@ -37,12 +37,11 @@ fn parse_buf(vec[u8] buf, uint radix) -> uint {
     auto i = _vec.len[u8](buf) - 1u;
     auto power = 1u;
     auto n = 0u;
-    while (i >= 0u) {
+    while (true) {
         n += (((buf.(i)) - ('0' as u8)) as uint) * power;
         power *= radix;
-        i -= 1u;
+        if (i == 0u) { ret n; }
     }
-    ret n;
 }
 
 fn to_str(uint num, uint radix) -> str

Original file line number	Diff line number	Diff line change
`@@ -37,12 +37,11 @@ fn parse_buf(vec[u8] buf, uint radix) -> uint {`
`37`	`37`	`auto i = _vec.len[u8](buf) - 1u;`
`38`	`38`	`auto power = 1u;`
`39`	`39`	`auto n = 0u;`
`40`		`- while (i >= 0u) {`
	`40`	`+ while (true) {`
`41`	`41`	`n += (((buf.(i)) - ('0' as u8)) as uint) * power;`
`42`	`42`	`power *= radix;`
`43`		`- i -= 1u;`
	`43`	`+ if (i == 0u) { ret n; }`
`44`	`44`	`}`
`45`		`- ret n;`
`46`	`45`	`}`
`47`	`46`
`48`	`47`	`fn to_str(uint num, uint radix) -> str`