Skip to content

Commit 7693e3e

Browse files
committed
liballoc: refactor & fix some imports.
1 parent e6e2792 commit 7693e3e

35 files changed

+424
-342
lines changed

src/liballoc/alloc.rs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@
22
33
#![stable(feature = "alloc_module", since = "1.28.0")]
44

5-
use core::intrinsics::{min_align_of_val, size_of_val};
6-
use core::ptr::{NonNull, Unique};
7-
use core::usize;
5+
use core::{
6+
intrinsics::{min_align_of_val, size_of_val},
7+
ptr::{NonNull, Unique},
8+
usize,
9+
};
810

911
#[stable(feature = "alloc_module", since = "1.28.0")]
1012
#[doc(inline)]
@@ -228,8 +230,10 @@ pub fn handle_alloc_error(layout: Layout) -> ! {
228230
mod tests {
229231
extern crate test;
230232
use self::test::Bencher;
231-
use boxed::Box;
232-
use alloc::{Global, Alloc, Layout, handle_alloc_error};
233+
use crate::{
234+
boxed::Box,
235+
alloc::{Global, Alloc, Layout, handle_alloc_error},
236+
};
233237

234238
#[test]
235239
fn allocate_zeroed() {

src/liballoc/benches/btree/map.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
use std::iter::Iterator;
2-
use std::vec::Vec;
3-
use std::collections::BTreeMap;
1+
use std::{
2+
iter::Iterator,
3+
vec::Vec,
4+
collections::BTreeMap,
5+
};
46
use rand::{Rng, seq::SliceRandom, thread_rng};
57
use test::{Bencher, black_box};
68

src/liballoc/benches/slice.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
use rand::{thread_rng};
2-
use std::mem;
3-
use std::ptr;
4-
5-
use rand::{Rng, SeedableRng};
6-
use rand::distributions::{Standard, Alphanumeric};
1+
use std::{mem, ptr};
2+
use rand::{
3+
thread_rng, Rng, SeedableRng,
4+
distributions::{Standard, Alphanumeric},
5+
};
76
use rand_xorshift::XorShiftRng;
87
use test::{Bencher, black_box};
98

src/liballoc/borrow.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@
22
33
#![stable(feature = "rust1", since = "1.0.0")]
44

5-
use core::cmp::Ordering;
6-
use core::hash::{Hash, Hasher};
7-
use core::ops::{Add, AddAssign, Deref};
5+
use core::{
6+
cmp::Ordering,
7+
hash::{Hash, Hasher},
8+
ops::{Add, AddAssign, Deref},
9+
};
810

9-
use crate::fmt;
10-
use crate::string::String;
11+
use crate::{fmt, string::String};
1112

1213
use self::Cow::*;
1314

src/liballoc/boxed.rs

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -56,26 +56,28 @@
5656
5757
#![stable(feature = "rust1", since = "1.0.0")]
5858

59-
use core::any::Any;
60-
use core::borrow;
61-
use core::cmp::Ordering;
62-
use core::convert::From;
63-
use core::fmt;
64-
use core::future::Future;
65-
use core::hash::{Hash, Hasher};
66-
use core::iter::{Iterator, FromIterator, FusedIterator};
67-
use core::marker::{Unpin, Unsize};
68-
use core::mem;
69-
use core::pin::Pin;
70-
use core::ops::{
71-
CoerceUnsized, DispatchFromDyn, Deref, DerefMut, Receiver, Generator, GeneratorState
59+
use core::{
60+
any::Any,
61+
borrow,
62+
cmp::Ordering,
63+
convert::From,
64+
fmt,
65+
future::Future,
66+
hash::{Hash, Hasher},
67+
iter::{Iterator, FromIterator, FusedIterator},
68+
marker::{Unpin, Unsize},
69+
mem,
70+
pin::Pin,
71+
ops::{CoerceUnsized, DispatchFromDyn, Deref, DerefMut, Receiver, Generator, GeneratorState},
72+
ptr::{self, NonNull, Unique},
73+
task::{LocalWaker, Poll},
7274
};
73-
use core::ptr::{self, NonNull, Unique};
74-
use core::task::{LocalWaker, Poll};
7575

76-
use crate::vec::Vec;
77-
use crate::raw_vec::RawVec;
78-
use crate::str::from_boxed_utf8_unchecked;
76+
use crate::{
77+
vec::Vec,
78+
raw_vec::RawVec,
79+
str::from_boxed_utf8_unchecked,
80+
};
7981

8082
/// A pointer type for heap allocation.
8183
///

src/liballoc/boxed_test.rs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
//! Test for `boxed` mod.
22
3-
use core::any::Any;
4-
use core::ops::Deref;
5-
use core::result::Result::{Err, Ok};
6-
use core::clone::Clone;
7-
use core::f64;
8-
use core::i64;
3+
use core::{
4+
any::Any,
5+
ops::Deref,
6+
result::Result::{Err, Ok},
7+
clone::Clone,
8+
f64,
9+
i64,
10+
};
911

1012
use std::boxed::Box;
1113

src/liballoc/collections/binary_heap.rs

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,14 +145,18 @@
145145
#![allow(missing_docs)]
146146
#![stable(feature = "rust1", since = "1.0.0")]
147147

148-
use core::ops::{Deref, DerefMut};
149-
use core::iter::{FromIterator, FusedIterator};
150-
use core::mem::{swap, size_of, ManuallyDrop};
151-
use core::ptr;
152-
use core::fmt;
153-
154-
use crate::slice;
155-
use crate::vec::{self, Vec};
148+
use core::{
149+
ops::{Deref, DerefMut},
150+
iter::{FromIterator, FusedIterator},
151+
mem::{swap, size_of, ManuallyDrop},
152+
ptr,
153+
fmt,
154+
};
155+
156+
use crate::{
157+
slice,
158+
vec::{self, Vec},
159+
};
156160

157161
use super::SpecExtend;
158162

src/liballoc/collections/btree/map.rs

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,24 @@
1-
use core::cmp::Ordering;
2-
use core::fmt::Debug;
3-
use core::hash::{Hash, Hasher};
4-
use core::iter::{FromIterator, Peekable, FusedIterator};
5-
use core::marker::PhantomData;
6-
use core::ops::Bound::{Excluded, Included, Unbounded};
7-
use core::ops::Index;
8-
use core::ops::RangeBounds;
9-
use core::{fmt, intrinsics, mem, ptr};
1+
use core::{
2+
cmp::Ordering,
3+
fmt::Debug,
4+
hash::{Hash, Hasher},
5+
iter::{FromIterator, Peekable, FusedIterator},
6+
marker::PhantomData,
7+
ops::{
8+
Bound::{Excluded, Included, Unbounded},
9+
Index, RangeBounds,
10+
},
11+
fmt, intrinsics, mem, ptr,
12+
};
1013

1114
use crate::borrow::Borrow;
1215

13-
use super::node::{self, Handle, NodeRef, marker};
14-
use super::search;
16+
use super::{
17+
node::{self, Handle, NodeRef, marker, InsertResult::*, ForceResult::*},
18+
search::{self, SearchResult::*},
19+
};
1520

16-
use super::node::InsertResult::*;
17-
use super::node::ForceResult::*;
18-
use super::search::SearchResult::*;
19-
use self::UnderflowResult::*;
20-
use self::Entry::*;
21+
use self::{UnderflowResult::*, Entry::*};
2122

2223
/// A map based on a B-Tree.
2324
///

src/liballoc/collections/btree/node.rs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,17 @@
3131
// - A node of length `n` has `n` keys, `n` values, and (in an internal node) `n + 1` edges.
3232
// This implies that even an empty internal node has at least one edge.
3333

34-
use core::marker::PhantomData;
35-
use core::mem::{self, MaybeUninit};
36-
use core::ptr::{self, Unique, NonNull};
37-
use core::slice;
34+
use core::{
35+
marker::PhantomData,
36+
mem::{self, MaybeUninit},
37+
ptr::{self, Unique, NonNull},
38+
slice,
39+
};
3840

39-
use crate::alloc::{Global, Alloc, Layout};
40-
use crate::boxed::Box;
41+
use crate::{
42+
alloc::{Global, Alloc, Layout},
43+
boxed::Box,
44+
};
4145

4246
const B: usize = 6;
4347
pub const MIN_LEN: usize = B - 1;

src/liballoc/collections/btree/search.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@ use core::cmp::Ordering;
22

33
use crate::borrow::Borrow;
44

5-
use super::node::{Handle, NodeRef, marker};
5+
use super::node::{Handle, NodeRef, marker, ForceResult::*};
66

7-
use super::node::ForceResult::*;
87
use self::SearchResult::*;
98

109
pub enum SearchResult<BorrowType, K, V, FoundType, GoDownType> {

src/liballoc/collections/btree/set.rs

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,20 @@
11
// This is pretty much entirely stolen from TreeSet, since BTreeMap has an identical interface
22
// to TreeMap
33

4-
use core::cmp::Ordering::{self, Less, Greater, Equal};
5-
use core::cmp::{min, max};
6-
use core::fmt::Debug;
7-
use core::fmt;
8-
use core::iter::{Peekable, FromIterator, FusedIterator};
9-
use core::ops::{BitOr, BitAnd, BitXor, Sub, RangeBounds};
10-
11-
use crate::borrow::Borrow;
12-
use crate::collections::btree_map::{self, BTreeMap, Keys};
4+
use core::{
5+
cmp::{
6+
Ordering::{self, Less, Greater, Equal},
7+
min, max,
8+
},
9+
fmt::{self, Debug},
10+
iter::{Peekable, FromIterator, FusedIterator},
11+
ops::{BitOr, BitAnd, BitXor, Sub, RangeBounds},
12+
};
13+
14+
use crate::{
15+
borrow::Borrow,
16+
collections::btree_map::{self, BTreeMap, Keys},
17+
};
1318
use super::Recover;
1419

1520
// FIXME(conventions): implement bounded iterators

src/liballoc/collections/linked_list.rs

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,15 @@
1212
1313
#![stable(feature = "rust1", since = "1.0.0")]
1414

15-
use core::cmp::Ordering;
16-
use core::fmt;
17-
use core::hash::{Hasher, Hash};
18-
use core::iter::{FromIterator, FusedIterator};
19-
use core::marker::PhantomData;
20-
use core::mem;
21-
use core::ptr::NonNull;
15+
use core::{
16+
cmp::Ordering,
17+
fmt,
18+
hash::{Hasher, Hash},
19+
iter::{FromIterator, FusedIterator},
20+
marker::PhantomData,
21+
mem,
22+
ptr::NonNull,
23+
};
2224

2325
use crate::boxed::Box;
2426
use super::SpecExtend;
@@ -1213,11 +1215,8 @@ unsafe impl<'a, T: Sync> Sync for IterMut<'a, T> {}
12131215

12141216
#[cfg(test)]
12151217
mod tests {
1216-
use std::thread;
1217-
use std::vec::Vec;
1218-
1218+
use std::{thread, vec::Vec};
12191219
use rand::{thread_rng, RngCore};
1220-
12211220
use super::{LinkedList, Node};
12221221

12231222
#[cfg(test)]

src/liballoc/collections/vec_deque.rs

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,25 @@
77
88
#![stable(feature = "rust1", since = "1.0.0")]
99

10-
use core::cmp::Ordering;
11-
use core::fmt;
12-
use core::iter::{repeat_with, FromIterator, FusedIterator};
13-
use core::mem;
14-
use core::ops::Bound::{Excluded, Included, Unbounded};
15-
use core::ops::{Index, IndexMut, RangeBounds, Try};
16-
use core::ptr;
17-
use core::ptr::NonNull;
18-
use core::slice;
19-
20-
use core::hash::{Hash, Hasher};
21-
use core::cmp;
22-
23-
use crate::collections::CollectionAllocErr;
24-
use crate::raw_vec::RawVec;
25-
use crate::vec::Vec;
10+
use core::{
11+
cmp::{self, Ordering},
12+
fmt,
13+
iter::{repeat_with, FromIterator, FusedIterator},
14+
mem,
15+
ops::{
16+
Bound::{Excluded, Included, Unbounded},
17+
Index, IndexMut, RangeBounds, Try,
18+
},
19+
ptr::{self, NonNull},
20+
slice,
21+
hash::{Hash, Hasher},
22+
};
23+
24+
use crate::{
25+
collections::CollectionAllocErr,
26+
raw_vec::RawVec,
27+
vec::Vec,
28+
};
2629

2730
const INITIAL_CAPACITY: usize = 7; // 2^3 - 1
2831
const MINIMUM_CAPACITY: usize = 1; // 2 - 1
@@ -2758,7 +2761,7 @@ impl<T> From<VecDeque<T>> for Vec<T> {
27582761

27592762
#[cfg(test)]
27602763
mod tests {
2761-
use test;
2764+
use ::test;
27622765

27632766
use super::VecDeque;
27642767

@@ -3036,7 +3039,7 @@ mod tests {
30363039

30373040
#[test]
30383041
fn test_from_vec() {
3039-
use vec::Vec;
3042+
use crate::vec::Vec;
30403043
for cap in 0..35 {
30413044
for len in 0..=cap {
30423045
let mut vec = Vec::with_capacity(cap);
@@ -3052,7 +3055,7 @@ mod tests {
30523055

30533056
#[test]
30543057
fn test_vec_from_vecdeque() {
3055-
use vec::Vec;
3058+
use crate::vec::Vec;
30563059

30573060
fn create_vec_and_test_convert(cap: usize, offset: usize, len: usize) {
30583061
let mut vd = VecDeque::with_capacity(cap);
@@ -3114,7 +3117,7 @@ mod tests {
31143117

31153118
#[test]
31163119
fn issue_53529() {
3117-
use boxed::Box;
3120+
use crate::boxed::Box;
31183121

31193122
let mut dst = VecDeque::new();
31203123
dst.push_front(Box::new(1));

0 commit comments

Comments
 (0)