Use match ergonomics for artithmetic lint

LunaBorowska · LunaBorowska · commit 79cd95cf35a0 · 2018-12-29T17:25:45.000+01:00
diff --git a/clippy_lints/src/arithmetic.rs b/clippy_lints/src/arithmetic.rs
@@ -73,8 +73,8 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Arithmetic {
                 return;
             }
         }
-        match expr.node {
-            hir::ExprKind::Binary(ref op, ref l, ref r) => {
+        match &expr.node {
+            hir::ExprKind::Binary(op, l, r) => {
                 match op.node {
                     hir::BinOpKind::And
                     | hir::BinOpKind::Or
@@ -100,7 +100,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Arithmetic {
                     self.expr_span = Some(expr.span);
                 }
             },
-            hir::ExprKind::Unary(hir::UnOp::UnNeg, ref arg) => {
+            hir::ExprKind::Unary(hir::UnOp::UnNeg, arg) => {
                 let ty = cx.tables.expr_ty(arg);
                 if ty.is_integral() {
                     span_lint(cx, INTEGER_ARITHMETIC, expr.span, "integer arithmetic detected");

Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,8 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Arithmetic {`
`73`	`73`	`return;`
`74`	`74`	`}`
`75`	`75`	`}`
`76`		`- match expr.node {`
`77`		`- hir::ExprKind::Binary(ref op, ref l, ref r) => {`
	`76`	`+ match &expr.node {`
	`77`	`+ hir::ExprKind::Binary(op, l, r) => {`
`78`	`78`	`match op.node {`
`79`	`79`	`hir::BinOpKind::And`
`80`	`80`	`\| hir::BinOpKind::Or`
`@@ -100,7 +100,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Arithmetic {`
`100`	`100`	`self.expr_span = Some(expr.span);`
`101`	`101`	`}`
`102`	`102`	`},`
`103`		`- hir::ExprKind::Unary(hir::UnOp::UnNeg, ref arg) => {`
	`103`	`+ hir::ExprKind::Unary(hir::UnOp::UnNeg, arg) => {`
`104`	`104`	`let ty = cx.tables.expr_ty(arg);`
`105`	`105`	`if ty.is_integral() {`
`106`	`106`	`span_lint(cx, INTEGER_ARITHMETIC, expr.span, "integer arithmetic detected");`