instantly_dangling_pointer, temporary_cstring_as_ptr: add and move tests

Author: GrigorenkoPV

tests/ui/lint/lint-temporary-cstring-as-param.rs renamed to tests/ui/lint/dangling-ptr/cstring-as-param.rs

@@ -1,5 +1,5 @@
 error: getting a pointer from a temporary `CString` will result in a dangling pointer
-  --> $DIR/lint-temporary-cstring-as-param.rs:9:45
+  --> $DIR/cstring-as-param.rs:9:45
    |
 LL |     some_function(CString::new("").unwrap().as_ptr());
    |                   ------------------------- ^^^^^^ this pointer will immediately be invalid
@@ -9,7 +9,7 @@ LL |     some_function(CString::new("").unwrap().as_ptr());
    = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
    = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
 note: the lint level is defined here
-  --> $DIR/lint-temporary-cstring-as-param.rs:1:9
+  --> $DIR/cstring-as-param.rs:1:9
    |
 LL | #![deny(temporary_cstring_as_ptr)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^

tests/ui/lint/lint-temporary-cstring-as-param.stderr renamed to tests/ui/lint/dangling-ptr/cstring-as-param.stderr

@@ -1,5 +1,5 @@
 error: getting a pointer from a temporary `CString` will result in a dangling pointer
-  --> $DIR/lint-temporary-cstring-as-ptr.rs:14:48
+  --> $DIR/cstring-as-ptr.rs:14:48
    |
 LL |     let s = CString::new("some text").unwrap().as_ptr();
    |             ---------------------------------- ^^^^^^ this pointer will immediately be invalid
@@ -9,13 +9,13 @@ LL |     let s = CString::new("some text").unwrap().as_ptr();
    = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
    = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
 note: the lint level is defined here
-  --> $DIR/lint-temporary-cstring-as-ptr.rs:2:9
+  --> $DIR/cstring-as-ptr.rs:2:9
    |
 LL | #![deny(temporary_cstring_as_ptr)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: getting a pointer from a temporary `CString` will result in a dangling pointer
-  --> $DIR/lint-temporary-cstring-as-ptr.rs:8:52
+  --> $DIR/cstring-as-ptr.rs:8:52
    |
 LL |         let s = CString::new("some text").unwrap().as_ptr();
    |                 ---------------------------------- ^^^^^^ this pointer will immediately be invalid

tests/ui/lint/lint-temporary-cstring-as-ptr.rs renamed to tests/ui/lint/dangling-ptr/cstring-as-ptr.rs

@@ -0,0 +1,13 @@
+#![deny(instantly_dangling_pointer)]
+
+const MAX_PATH: usize = 260;
+fn main() {
+    let str1 = String::with_capacity(MAX_PATH).as_mut_ptr();
+    //~^ ERROR [instantly_dangling_pointer]
+    let str2 = String::from("TotototototototototototototototototoT").as_ptr();
+    //~^ ERROR [instantly_dangling_pointer]
+    unsafe {
+        std::ptr::copy_nonoverlapping(str2, str1, 30);
+        println!("{:?}", String::from_raw_parts(str1, 30, 30));
+    }
+}

tests/ui/lint/lint-temporary-cstring-as-ptr.stderr renamed to tests/ui/lint/dangling-ptr/cstring-as-ptr.stderr

@@ -0,0 +1,29 @@
+error: getting a pointer from a temporary `String` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-issue123613.rs:5:48
+   |
+LL |     let str1 = String::with_capacity(MAX_PATH).as_mut_ptr();
+   |                ------------------------------- ^^^^^^^^^^ this pointer will immediately be invalid
+   |                |
+   |                this `String` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_mut_ptr` the `String` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+note: the lint level is defined here
+  --> $DIR/instantly-dangling-pointer-issue123613.rs:1:9
+   |
+LL | #![deny(instantly_dangling_pointer)]
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error: getting a pointer from a temporary `String` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-issue123613.rs:7:70
+   |
+LL |     let str2 = String::from("TotototototototototototototototototoT").as_ptr();
+   |                ----------------------------------------------------- ^^^^^^ this pointer will immediately be invalid
+   |                |
+   |                this `String` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `String` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: aborting due to 2 previous errors
+

tests/ui/lint/dangling-ptr/instantly-dangling-pointer-issue123613.rs

@@ -0,0 +1,6 @@
+#![deny(instantly_dangling_pointer)]
+
+fn main() {
+    vec![0u8].as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    vec![0u8].as_mut_ptr(); //~ ERROR [instantly_dangling_pointer]
+}

tests/ui/lint/dangling-ptr/instantly-dangling-pointer-issue123613.stderr

@@ -0,0 +1,29 @@
+error: getting a pointer from a temporary `Vec<u8>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-methods.rs:4:15
+   |
+LL |     vec![0u8].as_ptr();
+   |     --------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Vec<u8>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Vec<u8>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+note: the lint level is defined here
+  --> $DIR/instantly-dangling-pointer-methods.rs:1:9
+   |
+LL | #![deny(instantly_dangling_pointer)]
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error: getting a pointer from a temporary `Vec<u8>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-methods.rs:5:15
+   |
+LL |     vec![0u8].as_mut_ptr();
+   |     --------- ^^^^^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Vec<u8>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_mut_ptr` the `Vec<u8>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: aborting due to 2 previous errors
+

tests/ui/lint/dangling-ptr/instantly-dangling-pointer-methods.rs

@@ -0,0 +1,37 @@
+#![deny(instantly_dangling_pointer)]
+
+use std::cell::Cell;
+use std::ffi::{CStr, CString};
+use std::mem::MaybeUninit;
+
+struct AsPtrFake;
+
+impl AsPtrFake {
+    fn as_ptr(&self) -> *const () {
+        std::ptr::null()
+    }
+}
+
+fn declval<T>() -> T {
+    loop {}
+}
+
+fn main() {
+    declval::<CString>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<String>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Vec<u8>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Box<CString>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Box<[u8]>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Box<str>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Box<CStr>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<[u8; 10]>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Box<[u8; 10]>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Box<Vec<u8>>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Box<String>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Box<Box<Box<Box<[u8]>>>>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Cell<u8>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<MaybeUninit<u8>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Vec<AsPtrFake>>().as_ptr(); //~ ERROR [instantly_dangling_pointer]
+    declval::<Box<AsPtrFake>>().as_ptr();
+    declval::<AsPtrFake>().as_ptr();
+}

tests/ui/lint/dangling-ptr/instantly-dangling-pointer-methods.stderr

@@ -0,0 +1,172 @@
+error: getting a pointer from a temporary `CString` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:20:26
+   |
+LL |     declval::<CString>().as_ptr();
+   |     -------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+note: the lint level is defined here
+  --> $DIR/instantly-dangling-pointer-types.rs:1:9
+   |
+LL | #![deny(instantly_dangling_pointer)]
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error: getting a pointer from a temporary `String` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:21:25
+   |
+LL |     declval::<String>().as_ptr();
+   |     ------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `String` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `String` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Vec<u8>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:22:26
+   |
+LL |     declval::<Vec<u8>>().as_ptr();
+   |     -------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Vec<u8>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Vec<u8>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Box<CString>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:23:31
+   |
+LL |     declval::<Box<CString>>().as_ptr();
+   |     ------------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Box<CString>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Box<CString>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Box<[u8]>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:24:28
+   |
+LL |     declval::<Box<[u8]>>().as_ptr();
+   |     ---------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Box<[u8]>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Box<[u8]>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Box<str>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:25:27
+   |
+LL |     declval::<Box<str>>().as_ptr();
+   |     --------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Box<str>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Box<str>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Box<CStr>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:26:28
+   |
+LL |     declval::<Box<CStr>>().as_ptr();
+   |     ---------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Box<CStr>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Box<CStr>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `[u8; 10]` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:27:27
+   |
+LL |     declval::<[u8; 10]>().as_ptr();
+   |     --------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `[u8; 10]` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `[u8; 10]` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Box<[u8; 10]>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:28:32
+   |
+LL |     declval::<Box<[u8; 10]>>().as_ptr();
+   |     -------------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Box<[u8; 10]>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Box<[u8; 10]>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Box<Vec<u8>>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:29:31
+   |
+LL |     declval::<Box<Vec<u8>>>().as_ptr();
+   |     ------------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Box<Vec<u8>>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Box<Vec<u8>>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Box<String>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:30:30
+   |
+LL |     declval::<Box<String>>().as_ptr();
+   |     ------------------------ ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Box<String>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Box<String>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Box<Box<Box<Box<[u8]>>>>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:31:43
+   |
+LL |     declval::<Box<Box<Box<Box<[u8]>>>>>().as_ptr();
+   |     ------------------------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Box<Box<Box<Box<[u8]>>>>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Box<Box<Box<Box<[u8]>>>>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Cell<u8>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:32:27
+   |
+LL |     declval::<Cell<u8>>().as_ptr();
+   |     --------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Cell<u8>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Cell<u8>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `MaybeUninit<u8>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:33:34
+   |
+LL |     declval::<MaybeUninit<u8>>().as_ptr();
+   |     ---------------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `MaybeUninit<u8>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `MaybeUninit<u8>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: getting a pointer from a temporary `Vec<AsPtrFake>` will result in a dangling pointer
+  --> $DIR/instantly-dangling-pointer-types.rs:34:33
+   |
+LL |     declval::<Vec<AsPtrFake>>().as_ptr();
+   |     --------------------------- ^^^^^^ this pointer will immediately be invalid
+   |     |
+   |     this `Vec<AsPtrFake>` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
+   |
+   = note: pointers do not have a lifetime; when calling `as_ptr` the `Vec<AsPtrFake>` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
+   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
+
+error: aborting due to 15 previous errors
+