update test stderr

Author: matthiaskrgr

ci/base-tests.sh

@@ -28,6 +28,9 @@ cd clippy_dev && cargo test && cd ..
 ./util/dev update_lints --check
 cargo +nightly fmt --all -- --check
 
+
+#avoid loop spam
+set +ex
 # make sure tests are formatted
 
 # some lints are sensitive to formatting, exclude some files
@@ -36,7 +39,9 @@ for file in `find tests -not -path "tests/ui/methods.rs" -not -path "tests/ui/fo
 rustfmt ${file} --check  || echo "${file} needs reformatting!" ; needs_formatting=true
 done
 
-if $needs_reformatting
-    "Tests need reformatting!"
+if [ "${needs_reformatting}" = true] ; then
+    echo "Tests need reformatting!"
     exit 2
 fi
+
+set -ex

tests/ui-toml/toml_blacklist/conf_french_blacklisted_name.stderr

@@ -1,45 +1,45 @@
 error: use of a blacklisted/placeholder name `toto`
-  --> $DIR/conf_french_blacklisted_name.rs:19:9
+  --> $DIR/conf_french_blacklisted_name.rs:15:9
    |
-19 | fn test(toto: ()) {}
+15 | fn test(toto: ()) {}
    |         ^^^^
    |
    = note: `-D clippy::blacklisted-name` implied by `-D warnings`
 
 error: use of a blacklisted/placeholder name `toto`
-  --> $DIR/conf_french_blacklisted_name.rs:22:9
+  --> $DIR/conf_french_blacklisted_name.rs:18:9
    |
-22 |     let toto = 42;
+18 |     let toto = 42;
    |         ^^^^
 
 error: use of a blacklisted/placeholder name `tata`
-  --> $DIR/conf_french_blacklisted_name.rs:23:9
+  --> $DIR/conf_french_blacklisted_name.rs:19:9
    |
-23 |     let tata = 42;
+19 |     let tata = 42;
    |         ^^^^
 
 error: use of a blacklisted/placeholder name `titi`
-  --> $DIR/conf_french_blacklisted_name.rs:24:9
+  --> $DIR/conf_french_blacklisted_name.rs:20:9
    |
-24 |     let titi = 42;
+20 |     let titi = 42;
    |         ^^^^
 
 error: use of a blacklisted/placeholder name `toto`
-  --> $DIR/conf_french_blacklisted_name.rs:30:10
+  --> $DIR/conf_french_blacklisted_name.rs:26:10
    |
-30 |         (toto, Some(tata), titi @ Some(_)) => (),
+26 |         (toto, Some(tata), titi @ Some(_)) => (),
    |          ^^^^
 
 error: use of a blacklisted/placeholder name `tata`
-  --> $DIR/conf_french_blacklisted_name.rs:30:21
+  --> $DIR/conf_french_blacklisted_name.rs:26:21
    |
-30 |         (toto, Some(tata), titi @ Some(_)) => (),
+26 |         (toto, Some(tata), titi @ Some(_)) => (),
    |                     ^^^^
 
 error: use of a blacklisted/placeholder name `titi`
-  --> $DIR/conf_french_blacklisted_name.rs:30:28
+  --> $DIR/conf_french_blacklisted_name.rs:26:28
    |
-30 |         (toto, Some(tata), titi @ Some(_)) => (),
+26 |         (toto, Some(tata), titi @ Some(_)) => (),
    |                            ^^^^
 
 error: aborting due to 7 previous errors

tests/ui-toml/toml_trivially_copy/test.stderr

@@ -1,15 +1,15 @@
 error: this argument is passed by reference, but would be more efficient if passed by value
-  --> $DIR/test.rs:23:11
+  --> $DIR/test.rs:20:11
    |
-23 | fn bad(x: &u16, y: &Foo) {
+20 | fn bad(x: &u16, y: &Foo) {}
    |           ^^^^ help: consider passing by value instead: `u16`
    |
    = note: `-D clippy::trivially-copy-pass-by-ref` implied by `-D warnings`
 
 error: this argument is passed by reference, but would be more efficient if passed by value
-  --> $DIR/test.rs:23:20
+  --> $DIR/test.rs:20:20
    |
-23 | fn bad(x: &u16, y: &Foo) {
+20 | fn bad(x: &u16, y: &Foo) {}
    |                    ^^^^ help: consider passing by value instead: `Foo`
 
 error: aborting due to 2 previous errors

tests/ui/absurd-extreme-comparisons.stderr

@@ -1,144 +1,144 @@
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:17:5
+  --> $DIR/absurd-extreme-comparisons.rs:23:5
    |
-17 |     u <= 0;
+23 |     u <= 0;
    |     ^^^^^^
    |
    = note: `-D clippy::absurd-extreme-comparisons` implied by `-D warnings`
    = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using u == 0 instead
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:18:5
+  --> $DIR/absurd-extreme-comparisons.rs:24:5
    |
-18 |     u <= Z;
+24 |     u <= Z;
    |     ^^^^^^
    |
    = help: because Z is the minimum value for this type, the case where the two sides are not equal never occurs, consider using u == Z instead
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:19:5
+  --> $DIR/absurd-extreme-comparisons.rs:25:5
    |
-19 |     u < Z;
+25 |     u < Z;
    |     ^^^^^
    |
    = help: because Z is the minimum value for this type, this comparison is always false
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:20:5
+  --> $DIR/absurd-extreme-comparisons.rs:26:5
    |
-20 |     Z >= u;
+26 |     Z >= u;
    |     ^^^^^^
    |
    = help: because Z is the minimum value for this type, the case where the two sides are not equal never occurs, consider using Z == u instead
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:21:5
+  --> $DIR/absurd-extreme-comparisons.rs:27:5
    |
-21 |     Z > u;
+27 |     Z > u;
    |     ^^^^^
    |
    = help: because Z is the minimum value for this type, this comparison is always false
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:22:5
+  --> $DIR/absurd-extreme-comparisons.rs:28:5
    |
-22 |     u > std::u32::MAX;
+28 |     u > std::u32::MAX;
    |     ^^^^^^^^^^^^^^^^^
    |
    = help: because std::u32::MAX is the maximum value for this type, this comparison is always false
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:23:5
+  --> $DIR/absurd-extreme-comparisons.rs:29:5
    |
-23 |     u >= std::u32::MAX;
+29 |     u >= std::u32::MAX;
    |     ^^^^^^^^^^^^^^^^^^
    |
    = help: because std::u32::MAX is the maximum value for this type, the case where the two sides are not equal never occurs, consider using u == std::u32::MAX instead
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:24:5
+  --> $DIR/absurd-extreme-comparisons.rs:30:5
    |
-24 |     std::u32::MAX < u;
+30 |     std::u32::MAX < u;
    |     ^^^^^^^^^^^^^^^^^
    |
    = help: because std::u32::MAX is the maximum value for this type, this comparison is always false
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:25:5
+  --> $DIR/absurd-extreme-comparisons.rs:31:5
    |
-25 |     std::u32::MAX <= u;
+31 |     std::u32::MAX <= u;
    |     ^^^^^^^^^^^^^^^^^^
    |
    = help: because std::u32::MAX is the maximum value for this type, the case where the two sides are not equal never occurs, consider using std::u32::MAX == u instead
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:26:5
+  --> $DIR/absurd-extreme-comparisons.rs:32:5
    |
-26 |     1-1 > u;
+32 |     1-1 > u;
    |     ^^^^^^^
    |
    = help: because 1-1 is the minimum value for this type, this comparison is always false
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:27:5
+  --> $DIR/absurd-extreme-comparisons.rs:33:5
    |
-27 |     u >= !0;
+33 |     u >= !0;
    |     ^^^^^^^
    |
    = help: because !0 is the maximum value for this type, the case where the two sides are not equal never occurs, consider using u == !0 instead
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:28:5
+  --> $DIR/absurd-extreme-comparisons.rs:34:5
    |
-28 |     u <= 12 - 2*6;
+34 |     u <= 12 - 2*6;
    |     ^^^^^^^^^^^^^
    |
    = help: because 12 - 2*6 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using u == 12 - 2*6 instead
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:30:5
+  --> $DIR/absurd-extreme-comparisons.rs:36:5
    |
-30 |     i < -127 - 1;
+36 |     i < -127 - 1;
    |     ^^^^^^^^^^^^
    |
    = help: because -127 - 1 is the minimum value for this type, this comparison is always false
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:31:5
+  --> $DIR/absurd-extreme-comparisons.rs:37:5
    |
-31 |     std::i8::MAX >= i;
+37 |     std::i8::MAX >= i;
    |     ^^^^^^^^^^^^^^^^^
    |
    = help: because std::i8::MAX is the maximum value for this type, this comparison is always true
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:32:5
+  --> $DIR/absurd-extreme-comparisons.rs:38:5
    |
-32 |     3-7 < std::i32::MIN;
+38 |     3-7 < std::i32::MIN;
    |     ^^^^^^^^^^^^^^^^^^^
    |
    = help: because std::i32::MIN is the minimum value for this type, this comparison is always false
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:34:5
+  --> $DIR/absurd-extreme-comparisons.rs:40:5
    |
-34 |     b >= true;
+40 |     b >= true;
    |     ^^^^^^^^^
    |
    = help: because true is the maximum value for this type, the case where the two sides are not equal never occurs, consider using b == true instead
 
 error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
-  --> $DIR/absurd-extreme-comparisons.rs:35:5
+  --> $DIR/absurd-extreme-comparisons.rs:41:5
    |
-35 |     false > b;
+41 |     false > b;
    |     ^^^^^^^^^
    |
    = help: because false is the minimum value for this type, this comparison is always false
 
 error: <-comparison of unit values detected. This will always be false
-  --> $DIR/absurd-extreme-comparisons.rs:38:5
+  --> $DIR/absurd-extreme-comparisons.rs:44:5
    |
-38 |     () < {};
+44 |     () < {};
    |     ^^^^^^^
    |
    = note: #[deny(clippy::unit_cmp)] on by default