option_map_unit_fn

Author: Urhengulas

Cargo.toml

@@ -179,7 +179,6 @@ needless_doctest_main = "allow"
 new_without_default = "allow"
 non_canonical_clone_impl = "allow"
 non_canonical_partial_ord_impl = "allow"
-option_map_unit_fn = "allow"
 partialeq_to_none = "allow"
 ptr_arg = "allow"
 redundant_closure = "allow"

crates/hir-def/src/nameres/collector.rs

@@ -2371,9 +2371,9 @@ impl ModCollector<'_, '_> {
         };
 
         for (name, macs) in source.scope.legacy_macros() {
-            macs.last().map(|&mac| {
+            if let Some(&mac) = macs.last() {
                 target.scope.define_legacy_macro(name.clone(), mac);
-            });
+            }
         }
     }