Address comments from PR review

Author: ebroto

clippy_dev/src/new_lint.rs

@@ -139,6 +139,7 @@ fn get_manifest_contents(lint_name: &str, hint: &str) -> String {
 [package]
 name = "{}"
 version = "0.1.0"
+publish = false
 "#,
         hint, lint_name
     )

tests/compile-test.rs

@@ -147,7 +147,7 @@ fn run_ui_toml(config: &mut compiletest::Config) {
         Ok(true) => {},
         Ok(false) => panic!("Some tests failed"),
         Err(e) => {
-            println!("I/O failure during tests: {:?}", e);
+            panic!("I/O failure during tests: {:?}", e);
         },
     }
 }
@@ -223,7 +223,7 @@ fn run_ui_cargo(config: &mut compiletest::Config) {
         Ok(true) => {},
         Ok(false) => panic!("Some tests failed"),
         Err(e) => {
-            println!("I/O failure during tests: {:?}", e);
+            panic!("I/O failure during tests: {:?}", e);
         },
     }
 }

tests/ui-cargo/cargo_common_metadata/fail/Cargo.toml

@@ -1,3 +1,4 @@
 [package]
 name = "cargo_common_metadata"
 version = "0.1.0"
+publish = false

tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "cargo_common_metadata"
 version = "0.1.0"
+publish = false
 authors = ["Random person from the Internet <[email protected]>"]
 description = "A test package for the cargo_common_metadata lint"
 repository = "https://github.com/someone/cargo_common_metadata"

tests/ui-cargo/multiple_crate_versions/fail/Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "multiple_crate_versions"
 version = "0.1.0"
+publish = false
 
 [dependencies]
 ctrlc = "=3.1.0"

tests/ui-cargo/multiple_crate_versions/pass/Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "cargo_common_metadata"
 version = "0.1.0"
+publish = false
 
 [dependencies]
 regex = "1.3.7"

tests/ui-cargo/wildcard_dependencies/fail/Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "wildcard_dependencies"
 version = "0.1.0"
+publish = false
 
 [dependencies]
 regex = "*"

tests/ui-cargo/wildcard_dependencies/pass/Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "wildcard_dependencies"
 version = "0.1.0"
+publish = false
 
 [dependencies]
 regex = "1"