Don't sort span_suggestions, leave that to caller

estebank · estebank · commit 82babe0303eb · 2023-11-19T17:50:45.000Z
diff --git a/clippy_lints/src/booleans.rs b/clippy_lints/src/booleans.rs
@@ -424,8 +424,9 @@ impl<'a, 'tcx> NonminimalBoolVisitor<'a, 'tcx> {
                     improvements.push(suggestion);
                 }
             }
-            let nonminimal_bool_lint = |suggestions: Vec<_>| {
+            let nonminimal_bool_lint = |mut suggestions: Vec<_>| {
                 if self.cx.tcx.lint_level_at_node(NONMINIMAL_BOOL, e.hir_id).0 != Level::Allow {
+                    suggestions.sort();
                     span_lint_hir_and_then(
                         self.cx,
                         NONMINIMAL_BOOL,

Original file line number	Diff line number	Diff line change
`@@ -424,8 +424,9 @@ impl<'a, 'tcx> NonminimalBoolVisitor<'a, 'tcx> {`
`424`	`424`	`improvements.push(suggestion);`
`425`	`425`	`}`
`426`	`426`	`}`
`427`		`- let nonminimal_bool_lint = \|suggestions: Vec<_>\| {`
	`427`	`+ let nonminimal_bool_lint = \|mut suggestions: Vec<_>\| {`
`428`	`428`	`if self.cx.tcx.lint_level_at_node(NONMINIMAL_BOOL, e.hir_id).0 != Level::Allow {`
	`429`	`+ suggestions.sort();`
`429`	`430`	`span_lint_hir_and_then(`
`430`	`431`	`self.cx,`
`431`	`432`	`NONMINIMAL_BOOL,`