Skip to content

Commit 88a1219

Browse files
erickterickt
committed
cleanup warnings from compiletest
1 parent d7e43aa commit 88a1219

File tree

3 files changed

+53
-54
lines changed

3 files changed

+53
-54
lines changed

‎src/compiletest/compiletest.rc

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -50,20 +50,20 @@ pub fn main() {
5050

5151
pub fn parse_config(args: ~[~str]) -> config {
5252
let opts =
53-
~[getopts::reqopt(~"compile-lib-path"),
54-
getopts::reqopt(~"run-lib-path"),
55-
getopts::reqopt(~"rustc-path"), getopts::reqopt(~"src-base"),
56-
getopts::reqopt(~"build-base"), getopts::reqopt(~"aux-base"),
57-
getopts::reqopt(~"stage-id"),
58-
getopts::reqopt(~"mode"), getopts::optflag(~"ignored"),
59-
getopts::optopt(~"runtool"), getopts::optopt(~"rustcflags"),
60-
getopts::optflag(~"verbose"),
61-
getopts::optopt(~"logfile"),
62-
getopts::optflag(~"jit"),
63-
getopts::optflag(~"newrt"),
64-
getopts::optopt(~"target"),
65-
getopts::optopt(~"adb-path"),
66-
getopts::optopt(~"adb-test-dir")
53+
~[getopts::reqopt("compile-lib-path"),
54+
getopts::reqopt("run-lib-path"),
55+
getopts::reqopt("rustc-path"), getopts::reqopt("src-base"),
56+
getopts::reqopt("build-base"), getopts::reqopt("aux-base"),
57+
getopts::reqopt("stage-id"),
58+
getopts::reqopt("mode"), getopts::optflag("ignored"),
59+
getopts::optopt("runtool"), getopts::optopt("rustcflags"),
60+
getopts::optflag("verbose"),
61+
getopts::optopt("logfile"),
62+
getopts::optflag("jit"),
63+
getopts::optflag("newrt"),
64+
getopts::optopt("target"),
65+
getopts::optopt("adb-path"),
66+
getopts::optopt("adb-test-dir")
6767
];
6868

6969
assert!(!args.is_empty());
@@ -74,43 +74,43 @@ pub fn parse_config(args: ~[~str]) -> config {
7474
Err(f) => fail!(getopts::fail_str(f))
7575
};
7676

77-
fn opt_path(m: &getopts::Matches, nm: ~str) -> Path {
77+
fn opt_path(m: &getopts::Matches, nm: &str) -> Path {
7878
Path(getopts::opt_str(m, nm))
7979
}
8080

8181
config {
82-
compile_lib_path: getopts::opt_str(matches, ~"compile-lib-path"),
83-
run_lib_path: getopts::opt_str(matches, ~"run-lib-path"),
84-
rustc_path: opt_path(matches, ~"rustc-path"),
85-
src_base: opt_path(matches, ~"src-base"),
86-
build_base: opt_path(matches, ~"build-base"),
87-
aux_base: opt_path(matches, ~"aux-base"),
88-
stage_id: getopts::opt_str(matches, ~"stage-id"),
89-
mode: str_mode(getopts::opt_str(matches, ~"mode")),
90-
run_ignored: getopts::opt_present(matches, ~"ignored"),
82+
compile_lib_path: getopts::opt_str(matches, "compile-lib-path"),
83+
run_lib_path: getopts::opt_str(matches, "run-lib-path"),
84+
rustc_path: opt_path(matches, "rustc-path"),
85+
src_base: opt_path(matches, "src-base"),
86+
build_base: opt_path(matches, "build-base"),
87+
aux_base: opt_path(matches, "aux-base"),
88+
stage_id: getopts::opt_str(matches, "stage-id"),
89+
mode: str_mode(getopts::opt_str(matches, "mode")),
90+
run_ignored: getopts::opt_present(matches, "ignored"),
9191
filter:
9292
if vec::len(matches.free) > 0u {
9393
option::Some(copy matches.free[0])
9494
} else { option::None },
95-
logfile: getopts::opt_maybe_str(matches, ~"logfile").map(|s| Path(*s)),
96-
runtool: getopts::opt_maybe_str(matches, ~"runtool"),
97-
rustcflags: getopts::opt_maybe_str(matches, ~"rustcflags"),
98-
jit: getopts::opt_present(matches, ~"jit"),
99-
newrt: getopts::opt_present(matches, ~"newrt"),
100-
target: opt_str2(getopts::opt_maybe_str(matches, ~"target")).to_str(),
101-
adb_path: opt_str2(getopts::opt_maybe_str(matches, ~"adb-path")).to_str(),
95+
logfile: getopts::opt_maybe_str(matches, "logfile").map(|s| Path(*s)),
96+
runtool: getopts::opt_maybe_str(matches, "runtool"),
97+
rustcflags: getopts::opt_maybe_str(matches, "rustcflags"),
98+
jit: getopts::opt_present(matches, "jit"),
99+
newrt: getopts::opt_present(matches, "newrt"),
100+
target: opt_str2(getopts::opt_maybe_str(matches, "target")).to_str(),
101+
adb_path: opt_str2(getopts::opt_maybe_str(matches, "adb-path")).to_str(),
102102
adb_test_dir:
103-
opt_str2(getopts::opt_maybe_str(matches, ~"adb-test-dir")).to_str(),
103+
opt_str2(getopts::opt_maybe_str(matches, "adb-test-dir")).to_str(),
104104
adb_device_status:
105-
if (opt_str2(getopts::opt_maybe_str(matches, ~"target")) ==
105+
if (opt_str2(getopts::opt_maybe_str(matches, "target")) ==
106106
~"arm-linux-androideabi") {
107-
if (opt_str2(getopts::opt_maybe_str(matches, ~"adb-test-dir")) !=
107+
if (opt_str2(getopts::opt_maybe_str(matches, "adb-test-dir")) !=
108108
~"(none)" &&
109-
opt_str2(getopts::opt_maybe_str(matches, ~"adb-test-dir")) !=
109+
opt_str2(getopts::opt_maybe_str(matches, "adb-test-dir")) !=
110110
~"") { true }
111111
else { false }
112112
} else { false },
113-
verbose: getopts::opt_present(matches, ~"verbose")
113+
verbose: getopts::opt_present(matches, "verbose")
114114
}
115115
}
116116

‎src/compiletest/header.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,10 @@ pub fn load_props(testfile: &Path) -> TestProps {
8787

8888
pub fn is_test_ignored(config: &config, testfile: &Path) -> bool {
8989
for iter_header(testfile) |ln| {
90-
if parse_name_directive(ln, ~"xfail-test") { return true; }
90+
if parse_name_directive(ln, "xfail-test") { return true; }
9191
if parse_name_directive(ln, xfail_target()) { return true; }
9292
if config.mode == common::mode_pretty &&
93-
parse_name_directive(ln, ~"xfail-pretty") { return true; }
93+
parse_name_directive(ln, "xfail-pretty") { return true; }
9494
};
9595
return false;
9696

@@ -107,8 +107,7 @@ fn iter_header(testfile: &Path, it: &fn(~str) -> bool) -> bool {
107107
// Assume that any directives will be found before the first
108108
// module or function. This doesn't seem to be an optimization
109109
// with a warm page cache. Maybe with a cold one.
110-
if str::starts_with(ln, ~"fn")
111-
|| str::starts_with(ln, ~"mod") {
110+
if str::starts_with(ln, "fn") || str::starts_with(ln, "mod") {
112111
return false;
113112
} else { if !(it(ln)) { return false; } }
114113
}

‎src/compiletest/runtest.rs

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ use util::logv;
2525
pub fn run(config: config, testfile: ~str) {
2626
if config.verbose {
2727
// We're going to be dumping a lot of info. Start on a new line.
28-
io::stdout().write_str(~"\n\n");
28+
io::stdout().write_str("\n\n");
2929
}
3030
let testfile = Path(testfile);
3131
debug!("running %s", testfile.to_str());
@@ -231,7 +231,7 @@ fn run_debuginfo_test(config: &config, props: &TestProps, testfile: &Path) {
231231
// do not optimize debuginfo tests
232232
let mut config = match config.rustcflags {
233233
Some(ref flags) => config {
234-
rustcflags: Some(str::replace(*flags, ~"-O", ~"")),
234+
rustcflags: Some(str::replace(*flags, "-O", "")),
235235
.. copy *config
236236
},
237237
None => copy *config
@@ -249,19 +249,19 @@ fn run_debuginfo_test(config: &config, props: &TestProps, testfile: &Path) {
249249
// write debugger script
250250
let script_str = str::append(cmds, "\nquit\n");
251251
debug!("script_str = %s", script_str);
252-
dump_output_file(config, testfile, script_str, ~"debugger.script");
252+
dump_output_file(config, testfile, script_str, "debugger.script");
253253

254254
// run debugger script with gdb
255255
#[cfg(windows)]
256256
fn debugger() -> ~str { ~"gdb.exe" }
257257
#[cfg(unix)]
258258
fn debugger() -> ~str { ~"gdb" }
259-
let debugger_script = make_out_name(config, testfile, ~"debugger.script");
259+
let debugger_script = make_out_name(config, testfile, "debugger.script");
260260
let debugger_opts = ~[~"-quiet", ~"-batch", ~"-nx",
261261
~"-command=" + debugger_script.to_str(),
262262
make_exe_name(config, testfile).to_str()];
263263
let ProcArgs = ProcArgs {prog: debugger(), args: debugger_opts};
264-
ProcRes = compose_and_run(config, testfile, ProcArgs, ~[], ~"", None);
264+
ProcRes = compose_and_run(config, testfile, ProcArgs, ~[], "", None);
265265
if ProcRes.status != 0 {
266266
fatal(~"gdb failed to execute");
267267
}
@@ -368,7 +368,7 @@ fn check_expected_errors(expected_errors: ~[errors::ExpectedError],
368368
}
369369

370370
// ignore this msg which gets printed at the end
371-
if str::contains(line, ~"aborting due to") {
371+
if str::contains(line, "aborting due to") {
372372
was_expected = true;
373373
}
374374

@@ -643,7 +643,7 @@ fn program_output(config: &config, testfile: &Path, lib_path: &str, prog: ~str,
643643
#[cfg(target_os = "macos")]
644644
#[cfg(target_os = "freebsd")]
645645
fn make_cmdline(_libpath: &str, prog: &str, args: &[~str]) -> ~str {
646-
fmt!("%s %s", prog, str::connect(args, ~" "))
646+
fmt!("%s %s", prog, str::connect(args, " "))
647647
}
648648

649649
#[cfg(target_os = "win32")]
@@ -668,7 +668,7 @@ fn dump_output_file(config: &config, testfile: &Path,
668668
out: &str, extension: &str) {
669669
let outfile = make_out_name(config, testfile, extension);
670670
let writer =
671-
io::file_writer(&outfile, ~[io::Create, io::Truncate]).get();
671+
io::file_writer(&outfile, [io::Create, io::Truncate]).get();
672672
writer.write_str(out);
673673
}
674674

@@ -692,8 +692,8 @@ fn output_base_name(config: &config, testfile: &Path) -> Path {
692692

693693
fn maybe_dump_to_stdout(config: &config, out: &str, err: &str) {
694694
if config.verbose {
695-
let sep1 = fmt!("------%s------------------------------", ~"stdout");
696-
let sep2 = fmt!("------%s------------------------------", ~"stderr");
695+
let sep1 = fmt!("------%s------------------------------", "stdout");
696+
let sep2 = fmt!("------%s------------------------------", "stderr");
697697
let sep3 = ~"------------------------------------------";
698698
io::stdout().write_line(sep1);
699699
io::stdout().write_line(out);
@@ -781,10 +781,10 @@ fn _arm_exec_compiled_test(config: &config, props: &TestProps,
781781
newargs_err.push(newcmd_err);
782782
783783
let procsrv::Result{ out: out_out, err: _out_err, status: out_status } =
784-
procsrv::run(~"", config.adb_path, newargs_out, ~[(~"",~"")],
784+
procsrv::run("", config.adb_path, newargs_out, ~[(~"",~"")],
785785
Some(~""));
786786
let procsrv::Result{ out: err_out, err: _err_err, status: _err_status } =
787-
procsrv::run(~"", config.adb_path, newargs_err, ~[(~"",~"")],
787+
procsrv::run("", config.adb_path, newargs_err, ~[(~"",~"")],
788788
Some(~""));
789789
790790
dump_output(config, testfile, out_out, err_out);
@@ -818,8 +818,8 @@ fn _arm_push_aux_shared_library(config: &config, testfile: &Path) {
818818
819819
if (file.filetype() == Some(~".so")) {
820820
821-
let copy_result = procsrv::run(~"", config.adb_path,
822-
~[~"push", file.to_str(), copy config.adb_test_dir],
821+
let copy_result = procsrv::run("", config.adb_path,
822+
[~"push", file.to_str(), copy config.adb_test_dir],
823823
~[(~"",~"")], Some(~""));
824824
825825
if config.verbose {

0 commit comments

Comments
 (0)