Skip to content

Commit 88f08f3

Browse files
committed
---
yaml --- r: 23337 b: refs/heads/master c: c321cdb h: refs/heads/master i: 23335: 6f6c724 v: v3
1 parent ecd1fdf commit 88f08f3

File tree

3 files changed

+24
-1
lines changed

3 files changed

+24
-1
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 849d5649ef0c113d75bf9f9b1c3ddcd9a2508e49
2+
refs/heads/master: c321cdbac6c4ddd9fedb89e1cc8bce1569347c5a
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: cd6f24f9d14ac90d167386a56e7a6ac1f0318195
55
refs/heads/try: ffbe0e0e00374358b789b0037bcb3a577cd218be

trunk/src/rustc/middle/typeck/check/alt.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,12 @@ fn check_pat(pcx: pat_ctxt, pat: @ast::pat, expected: ty::t) {
270270
}
271271
}
272272

273+
// Forbid pattern-matching structs with destructors.
274+
if ty::has_dtor(tcx, class_id) {
275+
tcx.sess.span_err(pat.span, ~"deconstructing struct not allowed \
276+
in pattern (it has a destructor)");
277+
}
278+
273279
// Index the class fields.
274280
let field_map = std::map::box_str_hash();
275281
for class_fields.eachi |i, class_field| {
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
struct X {
2+
x: ~str;
3+
drop {
4+
error!("value: %s", self.x);
5+
}
6+
}
7+
8+
fn unwrap(+x: X) -> ~str {
9+
let X { x: y } = x; //~ ERROR deconstructing struct not allowed in pattern
10+
y
11+
}
12+
13+
fn main() {
14+
let x = X { x: ~"hello" };
15+
let y = unwrap(x);
16+
error!("contents: %s", y);
17+
}

0 commit comments

Comments
 (0)