Skip to content

Commit 8a516b6

Browse files
committed
---
yaml --- r: 13604 b: refs/heads/master c: 29330b5 h: refs/heads/master v: v3
1 parent f122884 commit 8a516b6

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 4396ad488f28f52bfbf4fe86cbba989761a21992
2+
refs/heads/master: 29330b5bdad47766fd36c1cc6352034724363ea1
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: 4a81779abd786ff22d71434c6d9a5917ea4cdfff
55
refs/heads/try: 2898dcc5d97da9427ac367542382b6239d9c0bbf

trunk/src/cargo/cargo.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ fn test_is_uuid() {
166166
}
167167

168168
// FIXME: implement url/URL parsing so we don't have to resort to weak checks
169+
// (#2661)
169170

170171
fn has_archive_extension(p: str) -> bool {
171172
str::ends_with(p, ".tar") ||
@@ -189,7 +190,7 @@ fn is_archive_path(u: str) -> bool {
189190

190191
fn is_archive_url(u: str) -> bool {
191192
// FIXME: this requires the protocol bit - if we had proper url parsing,
192-
// we wouldn't need it
193+
// we wouldn't need it (#2661)
193194

194195
alt str::find_str(u, "://") {
195196
option::some(i) { has_archive_extension(u) }
@@ -958,7 +959,7 @@ fn cmd_uninstall(c: cargo) {
958959

959960
// FIXME: needs stronger pattern matching
960961
// FIXME: needs to uninstall from a specified location in a cache instead
961-
// of looking for it (binaries can be uninstalled by name only)
962+
// of looking for it (binaries can be uninstalled by name only) (#2662)
962963
if is_uuid(target) {
963964
for os::list_dir(lib).each { |file|
964965
alt str::find_str(file, "-" + target + "-") {
@@ -1061,7 +1062,7 @@ fn install_query(c: cargo, wd: str, target: str) {
10611062

10621063
// FIXME: This whole dep_cache and current_install
10631064
// thing is a bit of a hack. It should be cleaned up in the future.
1064-
1065+
// #2662
10651066
if target == c.current_install {
10661067
for c.dep_cache.each { |k, _v|
10671068
c.dep_cache.remove(k);
@@ -1894,7 +1895,7 @@ fn main(argv: [str]) {
18941895
if !first_time && o.free[1] != "init" {
18951896
cmd_init(c);
18961897

1897-
// FIXME: shouldn't need to reconfigure
1898+
// FIXME: shouldn't need to reconfigure (#2662)
18981899
c = configure(o);
18991900
}
19001901

0 commit comments

Comments
 (0)