Skip to content

Commit 8e88463

Browse files
committed
---
yaml --- r: 211099 b: refs/heads/try c: deaa117 h: refs/heads/master i: 211097: a714ff8 211095: d11c8a6 v: v3
1 parent 4c80aa2 commit 8e88463

File tree

7 files changed

+13
-33
lines changed

7 files changed

+13
-33
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
refs/heads/master: 3e561f05c00cd180ec02db4ccab2840a4aba93d2
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: ba0e1cd8147d452c356aacb29fb87568ca26f111
5-
refs/heads/try: c3d60aba6c86883c79055c1a3923d4db116b644e
5+
refs/heads/try: deaa1172cf2871e04ca2524b6b553afb143f677a
66
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
77
refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
88
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596

branches/try/mk/docs.mk

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ ERR_IDX_GEN = $(RPATH_VAR2_T_$(CFG_BUILD)_H_$(CFG_BUILD)) $(ERR_IDX_GEN_EXE)
7777

7878
D := $(S)src/doc
7979

80-
DOC_TARGETS := trpl style error-index
80+
# FIXME (#25705) eventually may want to put error-index target back here.
81+
DOC_TARGETS := trpl style
8182
COMPILER_DOC_TARGETS :=
8283
DOC_L10N_TARGETS :=
8384

branches/try/src/doc/reference.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3622,14 +3622,6 @@ The `Sized` trait indicates that the size of this type is known at compile-time.
36223622
The `Drop` trait provides a destructor, to be run whenever a value of this type
36233623
is to be destroyed.
36243624

3625-
## The `Deref` trait
3626-
3627-
The `Deref<Target = U>` trait allows a type to implicitly implement all the methods
3628-
of the type `U`. When attempting to resolve a method call, the compiler will search
3629-
the top-level type for the implementation of the called method. If no such method is
3630-
found, `.deref()` is called and the compiler continues to search for the method
3631-
implementation in the returned type `U`.
3632-
36333625
# Memory model
36343626

36353627
A Rust program's memory consists of a static set of *items* and a *heap*.

branches/try/src/doc/trpl/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@ of those times. As the error explains, while we made our binding mutable, we
150150
still cannot call `push`. This is because we already have a reference to an
151151
element of the vector, `y`. Mutating something while another reference exists
152152
is dangerous, because we may invalidate the reference. In this specific case,
153-
when we create the vector, we may have only allocated space for two elements.
154-
Adding a third would mean allocating a new chunk of memory for all those elements,
153+
when we create the vector, we may have only allocated space for three elements.
154+
Adding a fourth would mean allocating a new chunk of memory for all those elements,
155155
copying the old values over, and updating the internal pointer to that memory.
156156
That all works just fine. The problem is that `y` wouldn’t get updated, and so
157157
we’d have a ‘dangling pointer’. That’s bad. Any use of `y` would be an error in

branches/try/src/doc/trpl/guessing-game.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ a few tricks up their sleeves.
148148
For example, they’re [immutable][immutable] by default. That’s why our example
149149
uses `mut`: it makes a binding mutable, rather than immutable. `let` doesn’t
150150
take a name on the left hand side, it actually accepts a
151-
[pattern][patterns]’. We’ll use patterns later. It’s easy enough
151+
[pattern][patterns]’. We’ll use patterns more later. It’s easy enough
152152
to use for now:
153153

154154
```rust

branches/try/src/doc/trpl/the-stack-and-the-heap.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -277,9 +277,9 @@ allocated on the heap:
277277
| 0 | x | ?????? |
278278

279279
[drop]: drop.html
280-
[^moving]: We can make the memory live longer by transferring ownership,
281-
sometimes called ‘moving out of the box’. More complex examples will
282-
be covered later.
280+
[moving]: We can make the memory live longer by transferring ownership,
281+
sometimes called ‘moving out of the box’. More complex examples will
282+
be covered later.
283283

284284

285285
And then the stack frame goes away, freeing all of our memory.

branches/try/src/libsyntax/diagnostics/plugin.rs

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ use std::collections::BTreeMap;
1414
use ast;
1515
use ast::{Ident, Name, TokenTree};
1616
use codemap::Span;
17-
use diagnostics::metadata::{check_uniqueness, output_metadata, Duplicate};
1817
use ext::base::{ExtCtxt, MacEager, MacResult};
1918
use ext::build::AstBuilder;
2019
use parse::token;
@@ -148,7 +147,7 @@ pub fn expand_build_diagnostic_array<'cx>(ecx: &'cx mut ExtCtxt,
148147
token_tree: &[TokenTree])
149148
-> Box<MacResult+'cx> {
150149
assert_eq!(token_tree.len(), 3);
151-
let (crate_name, name) = match (&token_tree[0], &token_tree[2]) {
150+
let (_crate_name, name) = match (&token_tree[0], &token_tree[2]) {
152151
(
153152
// Crate name.
154153
&ast::TtToken(_, token::Ident(ref crate_name, _)),
@@ -158,21 +157,9 @@ pub fn expand_build_diagnostic_array<'cx>(ecx: &'cx mut ExtCtxt,
158157
_ => unreachable!()
159158
};
160159

161-
// Check uniqueness of errors and output metadata.
162-
with_registered_diagnostics(|diagnostics| {
163-
match check_uniqueness(crate_name, &*diagnostics) {
164-
Ok(Duplicate(err, location)) => {
165-
ecx.span_err(span, &format!(
166-
"error {} from `{}' also found in `{}'",
167-
err, crate_name, location
168-
));
169-
},
170-
Ok(_) => (),
171-
Err(e) => panic!("{}", e.description())
172-
}
173-
174-
output_metadata(&*ecx, crate_name, &*diagnostics).ok().expect("metadata output error");
175-
});
160+
// FIXME (#25705): we used to ensure error code uniqueness and
161+
// output error description JSON metadata here, but the approach
162+
// employed was too brittle.
176163

177164
// Construct the output expression.
178165
let (count, expr) =

0 commit comments

Comments
 (0)