core: Change XXXs into proper FIXMEs with issue numbers

Author: catamorphism

src/libcore/gc.rs

@@ -344,7 +344,7 @@ pub fn cleanup_stack_for_failure() {
             roots.insert(*root, ());
 
             if ptr::is_null(tydesc) {
-                // XXX: Destroy this box
+                // FIXME #4420: Destroy this box
             } else {
                 rustrt::rust_call_tydesc_glue(*root, tydesc, 3 as size_t);
             }

src/libcore/pipes.rs

@@ -202,7 +202,7 @@ pub type Packet<T: Owned> = {
 
 #[doc(hidden)]
 pub trait HasBuffer {
-    // XXX This should not have a trailing underscore
+    // FIXME #4421: This should not have a trailing underscore
     fn set_buffer_(b: *libc::c_void);
 }
 

src/libcore/private.rs

@@ -83,8 +83,7 @@ pub unsafe fn chan_from_global_ptr<T: Owned>(
         let (setup1_po, setup1_ch) = pipes::stream();
         let (setup2_po, setup2_ch) = pipes::stream();
 
-        // XXX: Ugly type inference hints
-        let setup1_po: pipes::Port<oldcomm::Chan<T>> = setup1_po;
+        // FIXME #4422: Ugly type inference hint
         let setup2_po: pipes::Port<Msg> = setup2_po;
 
         do task_fn().spawn |move f, move setup1_ch, move setup2_po| {

src/libcore/repr.rs

@@ -60,7 +60,8 @@ impl Writer : EscapedCharWriter {
             '"' => self.write_str("\\\""),
             '\x20'..'\x7e' => self.write_char(ch),
             _ => {
-                // XXX: This is inefficient because it requires a malloc.
+                // FIXME #4423: This is inefficient because it requires a
+                // malloc.
                 self.write_str(char::escape_unicode(ch))
             }
         }
@@ -96,7 +97,7 @@ impl i32 : Repr {
     fn write_repr(writer: @Writer) { writer.write_int(self as int); }
 }
 impl i64 : Repr {
-    // XXX: This can lose precision.
+    // FIXME #4424: This can lose precision.
     fn write_repr(writer: @Writer) { writer.write_int(self as int); }
 }
 
@@ -113,20 +114,20 @@ impl u32 : Repr {
     fn write_repr(writer: @Writer) { writer.write_uint(self as uint); }
 }
 impl u64 : Repr {
-    // XXX: This can lose precision.
+    // FIXME #4424: This can lose precision.
     fn write_repr(writer: @Writer) { writer.write_uint(self as uint); }
 }
 
 impl float : Repr {
-    // XXX: This mallocs.
+    // FIXME #4423: This mallocs.
     fn write_repr(writer: @Writer) { writer.write_str(self.to_str()); }
 }
 impl f32 : Repr {
-    // XXX: This mallocs.
+    // FIXME #4423 This mallocs.
     fn write_repr(writer: @Writer) { writer.write_str(self.to_str()); }
 }
 impl f64 : Repr {
-    // XXX: This mallocs.
+    // FIXME #4423: This mallocs.
     fn write_repr(writer: @Writer) { writer.write_str(self.to_str()); }
 }
 

src/libcore/stackwalk.rs

@@ -13,7 +13,8 @@
 #[legacy_modes]; // tjc: remove after snapshot
 
 // NB: transitionary, de-mode-ing.
-// XXX: Can't forbid this because frame_address needs a deprecated mode.
+// FIXME #4425: Can't forbid this because frame_address needs a deprecated
+// mode.
 #[allow(deprecated_mode)];
 #[forbid(deprecated_pattern)];
 

src/libcore/sys.rs

@@ -134,7 +134,7 @@ pub pure fn begin_unwind(msg: ~str, file: ~str, line: uint) -> ! {
     }
 }
 
-// XXX: Temorary until rt::rt_fail_ goes away
+// FIXME #4427: Temporary until rt::rt_fail_ goes away
 pub pure fn begin_unwind_(msg: *c_char, file: *c_char, line: size_t) -> ! {
     unsafe {
         gc::cleanup_stack_for_failure();

src/libcore/task/spawn.rs

@@ -592,7 +592,7 @@ pub fn spawn_raw(opts: TaskOpts, f: fn~()) {
             }
 
             // Run the box annihilator.
-            // XXX: Crashy.
+            // FIXME #4428: Crashy.
             // unsafe { cleanup::annihilate(); }
         };
 

src/libcore/vec.rs

@@ -563,7 +563,7 @@ pub fn pop<T>(v: &mut ~[T]) -> T {
     }
     let valptr = ptr::to_mut_unsafe_ptr(&mut v[ln - 1u]);
     unsafe {
-        // XXX: Should be rusti::uninit() - we don't need this zeroed
+        // FIXME #4204: Should be rusti::uninit() - we don't need this zeroed
         let mut val = rusti::init();
         val <-> *valptr;
         raw::set_len(v, ln - 1u);
@@ -636,7 +636,7 @@ pub fn push_all_move<T>(v: &mut ~[T], rhs: ~[T]) {
     unsafe {
         do as_mut_buf(rhs) |p, len| {
             for uint::range(0, len) |i| {
-                // XXX Should be rusti::uninit() - don't need to zero
+                // FIXME #4204 Should be rusti::uninit() - don't need to zero
                 let mut x = rusti::init();
                 x <-> *ptr::mut_offset(p, i);
                 push(v, x);
@@ -653,7 +653,7 @@ pub fn truncate<T>(v: &mut ~[T], newlen: uint) {
         unsafe {
             // This loop is optimized out for non-drop types.
             for uint::range(newlen, oldlen) |i| {
-                // XXX Should be rusti::uninit() - don't need to zero
+                // FIXME #4204 Should be rusti::uninit() - don't need to zero
                 let mut dropped = rusti::init();
                 dropped <-> *ptr::mut_offset(p, i);
             }
@@ -678,7 +678,7 @@ pub fn dedup<T: Eq>(v: &mut ~[T]) unsafe {
             // last_written < next_to_read < ln
             if *ptr::mut_offset(p, next_to_read) ==
                 *ptr::mut_offset(p, last_written) {
-                // XXX Should be rusti::uninit() - don't need to zero
+                // FIXME #4204 Should be rusti::uninit() - don't need to zero
                 let mut dropped = rusti::init();
                 dropped <-> *ptr::mut_offset(p, next_to_read);
             } else {