Skip to content

Commit 921f4d3

Browse files
committed
Keep original literal notation in suggestion
1 parent dfe37f1 commit 921f4d3

File tree

4 files changed

+18
-2
lines changed

4 files changed

+18
-2
lines changed

clippy_lints/src/unused_rounding.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ fn is_useless_rounding(expr: &Expr) -> Option<(&str, String)> {
3636
&& let ExprKind::Lit(spanned) = &receiver.kind
3737
&& let LitKind::Float(symbol, ty) = spanned.kind {
3838
let f = symbol.as_str().parse::<f64>().unwrap();
39-
let f_str = symbol.to_string() + if let LitFloatType::Suffixed(ty) = ty {
39+
let f_str = spanned.token_lit.symbol.to_string() + if let LitFloatType::Suffixed(ty) = ty {
4040
ty.name_str()
4141
} else {
4242
""

tests/ui/unused_rounding.fixed

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,9 @@ fn main() {
66
let _ = 1.0f64;
77
let _ = 1.00f32;
88
let _ = 2e-54f64.floor();
9+
10+
// issue9866
11+
let _ = 3.3_f32.round();
12+
let _ = 3.3_f64.round();
13+
let _ = 3.0_f32;
914
}

tests/ui/unused_rounding.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,9 @@ fn main() {
66
let _ = 1.0f64.floor();
77
let _ = 1.00f32.round();
88
let _ = 2e-54f64.floor();
9+
10+
// issue9866
11+
let _ = 3.3_f32.round();
12+
let _ = 3.3_f64.round();
13+
let _ = 3.0_f32.round();
914
}

tests/ui/unused_rounding.stderr

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,11 @@ error: used the `round` method with a whole number float
1818
LL | let _ = 1.00f32.round();
1919
| ^^^^^^^^^^^^^^^ help: remove the `round` method call: `1.00f32`
2020

21-
error: aborting due to 3 previous errors
21+
error: used the `round` method with a whole number float
22+
--> $DIR/unused_rounding.rs:13:13
23+
|
24+
LL | let _ = 3.0_f32.round();
25+
| ^^^^^^^^^^^^^^^ help: remove the `round` method call: `3.0_f32`
26+
27+
error: aborting due to 4 previous errors
2228

0 commit comments

Comments
 (0)