---

yaml
---
r: 34799
b: refs/heads/master
c: 4e03ffd
h: refs/heads/master
i:
  34797: 7a9faa2
  34795: 0ed5201
  34791: cb155b4
  34783: 00055ae
v: v3

Author: erickt

[refs]

@@ -1,5 +1,5 @@
 ---
-refs/heads/master: 6ce4cf769f671c53f05e97357110d4c0ba322eae
+refs/heads/master: 4e03ffdb6547d9541de84b61d7798b497235472b
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: eb8fd119c65c67f3b1b8268cc7341c22d39b7b61
 refs/heads/try: d324a424d8f84b1eb049b12cf34182bda91b0024

trunk/src/libcore/run.rs

@@ -248,14 +248,12 @@ pub fn start_program(prog: &str, args: &[~str]) -> Program {
 }
 
 fn read_all(rd: io::Reader) -> ~str {
-    let buf = io::with_bytes_writer(|wr| {
-        let mut bytes = [mut 0, ..4096];
-        while !rd.eof() {
-            let nread = rd.read(bytes, bytes.len());
-            wr.write(bytes.view(0, nread));
-        }
-    });
-    str::from_bytes(buf)
+    let mut buf = ~"";
+    while !rd.eof() {
+        let bytes = rd.read_bytes(4096u);
+        buf += str::from_bytes(bytes);
+    }
+    move buf
 }
 
 /**
@@ -343,15 +341,13 @@ fn writeclose(fd: c_int, s: ~str) {
 fn readclose(fd: c_int) -> ~str {
     let file = os::fdopen(fd);
     let reader = io::FILE_reader(file, false);
-    let buf = io::with_bytes_writer(|writer| {
-        let mut bytes = [mut 0, ..4096];
-        while !reader.eof() {
-            let nread = reader.read(bytes, bytes.len());
-            writer.write(bytes.view(0, nread));
-        }
-    });
+    let mut buf = ~"";
+    while !reader.eof() {
+        let bytes = reader.read_bytes(4096u);
+        buf += str::from_bytes(bytes);
+    }
     os::fclose(file);
-    str::from_bytes(buf)
+    move buf
 }
 
 /// Waits for a process to exit and returns the exit code

trunk/src/rustc/middle/trans/build.rs

@@ -433,8 +433,7 @@ fn GEP(cx: block, Pointer: ValueRef, Indices: ~[ValueRef]) -> ValueRef {
 //
 // XXX: Use a small-vector optimization to avoid allocations here.
 fn GEPi(cx: block, base: ValueRef, ixs: &[uint]) -> ValueRef {
-    let mut v: ~[ValueRef] = ~[];
-    for vec::each(ixs) |i| { v.push(C_i32(*i as i32)); }
+    let v = do vec::map(ixs) |i| { C_i32(*i as i32) };
     count_insn(cx, "gepi");
     return InBoundsGEP(cx, base, v);
 }

trunk/src/rustdoc/markdown_writer.rs

@@ -136,15 +136,13 @@ fn readclose(fd: libc::c_int) -> ~str {
     // Copied from run::program_output
     let file = os::fdopen(fd);
     let reader = io::FILE_reader(file, false);
-    let buf = io::with_bytes_writer(|writer| {
-        let mut bytes = [mut 0, ..4096];
-        while !reader.eof() {
-            let nread = reader.read(bytes, bytes.len());
-            writer.write(bytes.view(0, nread));
-        }
-    });
+    let mut buf = ~"";
+    while !reader.eof() {
+        let bytes = reader.read_bytes(4096u);
+        buf += str::from_bytes(bytes);
+    }
     os::fclose(file);
-    str::from_bytes(buf)
+    return buf;
 }
 
 fn generic_writer(+process: fn~(markdown: ~str)) -> Writer {