Skip to content

Commit 96f27c7

Browse files
committed
Change cfg(version) error message wording
1 parent 90aa62a commit 96f27c7

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

src/librustc_attr/builtin.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -634,21 +634,21 @@ pub fn eval_condition(
634634
[NestedMetaItem::Literal(Lit { span, .. })
635635
| NestedMetaItem::MetaItem(MetaItem { span, .. })] => {
636636
sess.span_diagnostic
637-
.struct_span_err(*span, &*format!("expected string literal"))
637+
.struct_span_err(*span, &*format!("expected a version literal"))
638638
.emit();
639639
return false;
640640
}
641641
[..] => {
642642
sess.span_diagnostic
643-
.struct_span_err(cfg.span, "expected single string literal")
643+
.struct_span_err(cfg.span, "expected single version literal")
644644
.emit();
645645
return false;
646646
}
647647
};
648648
let min_version = match Version::parse(&min_version.as_str()) {
649649
Some(ver) => ver,
650650
None => {
651-
sess.span_diagnostic.struct_span_err(*span, "invalid version string").emit();
651+
sess.span_diagnostic.struct_span_err(*span, "invalid version literal").emit();
652652
return false;
653653
}
654654
};

src/test/ui/feature-gates/feature-gate-cfg-version.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,16 @@ fn foo() -> bool { true }
55
//~^ ERROR `cfg(version)` is experimental and subject to change
66
fn foo() -> bool { false }
77

8-
#[cfg(version("1.43", "1.44", "1.45"))] //~ ERROR: expected single string literal
8+
#[cfg(version("1.43", "1.44", "1.45"))] //~ ERROR: expected single version literal
99
//~^ ERROR `cfg(version)` is experimental and subject to change
1010
fn bar() -> bool { false }
11-
#[cfg(version(false))] //~ ERROR: expected string literal
11+
#[cfg(version(false))] //~ ERROR: expected a version literal
1212
//~^ ERROR `cfg(version)` is experimental and subject to change
1313
fn bar() -> bool { false }
14-
#[cfg(version("foo"))] //~ ERROR: invalid version string
14+
#[cfg(version("foo"))] //~ ERROR: invalid version literal
15+
//~^ ERROR `cfg(version)` is experimental and subject to change
16+
fn bar() -> bool { false }
17+
#[cfg(version("999"))]
1518
//~^ ERROR `cfg(version)` is experimental and subject to change
1619
fn bar() -> bool { false }
1720
#[cfg(version("999"))]

src/test/ui/feature-gates/feature-gate-cfg-version.stderr

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ LL | #[cfg(version("1.43", "1.44", "1.45"))]
2525
= note: see issue #64796 <https://github.com/rust-lang/rust/issues/64796> for more information
2626
= help: add `#![feature(cfg_version)]` to the crate attributes to enable
2727

28-
error: expected single string literal
28+
error: expected single version literal
2929
--> $DIR/feature-gate-cfg-version.rs:8:7
3030
|
3131
LL | #[cfg(version("1.43", "1.44", "1.45"))]
@@ -40,7 +40,7 @@ LL | #[cfg(version(false))]
4040
= note: see issue #64796 <https://github.com/rust-lang/rust/issues/64796> for more information
4141
= help: add `#![feature(cfg_version)]` to the crate attributes to enable
4242

43-
error: expected string literal
43+
error: expected a version literal
4444
--> $DIR/feature-gate-cfg-version.rs:11:15
4545
|
4646
LL | #[cfg(version(false))]
@@ -55,7 +55,7 @@ LL | #[cfg(version("foo"))]
5555
= note: see issue #64796 <https://github.com/rust-lang/rust/issues/64796> for more information
5656
= help: add `#![feature(cfg_version)]` to the crate attributes to enable
5757

58-
error: invalid version string
58+
error: invalid version literal
5959
--> $DIR/feature-gate-cfg-version.rs:14:15
6060
|
6161
LL | #[cfg(version("foo"))]

0 commit comments

Comments
 (0)