---

yaml
---
r: 22519
b: refs/heads/master
c: ad5c4ed
h: refs/heads/master
i:
  22517: 5f01b7e
  22515: 98e8628
  22511: 712e13e
v: v3

Author: msullivan

[refs]

@@ -1,5 +1,5 @@
 ---
-refs/heads/master: 9728d14baeb1f93da6ebe524b840ec9868c296ae
+refs/heads/master: ad5c4ed351766d5cc97f74f9a4ef784950654e15
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: cd6f24f9d14ac90d167386a56e7a6ac1f0318195
 refs/heads/try: ffbe0e0e00374358b789b0037bcb3a577cd218be

trunk/src/libcore/str.rs

@@ -26,6 +26,7 @@ export
    unpack_slice,
 
    // Adding things to and removing things from a string
+   push_str_no_overallocate,
    push_str,
    push_char,
    pop_char,
@@ -235,13 +236,29 @@ pure fn from_chars(chs: &[const char]) -> str {
     ret buf;
 }
 
+/// Appends a string slice to the back of a string, without overallocating
+#[inline(always)]
+fn push_str_no_overallocate(&lhs: str, rhs: str/&) {
+    unsafe {
+        let llen = lhs.len();
+        let rlen = rhs.len();
+        reserve(lhs, llen + rlen);
+        do as_buf(lhs) |lbuf| {
+            do unpack_slice(rhs) |rbuf, _rlen| {
+                let dst = ptr::offset(lbuf, llen);
+                ptr::memcpy(dst, rbuf, rlen);
+            }
+        }
+        unsafe::set_len(lhs, llen + rlen);
+    }
+}
 /// Appends a string slice to the back of a string
 #[inline(always)]
 fn push_str(&lhs: str, rhs: str/&) {
     unsafe {
         let llen = lhs.len();
         let rlen = rhs.len();
-        reserve(lhs, llen + rlen);
+        reserve_at_least(lhs, llen + rlen);
         do as_buf(lhs) |lbuf| {
             do unpack_slice(rhs) |rbuf, _rlen| {
                 let dst = ptr::offset(lbuf, llen);
@@ -257,7 +274,7 @@ fn push_str(&lhs: str, rhs: str/&) {
 pure fn append(+lhs: str, rhs: str/&) -> str {
     let mut v <- lhs;
     unchecked {
-        push_str(v, rhs);
+        push_str_no_overallocate(v, rhs);
     }
     ret v;
 }

trunk/src/libstd/sha1.rs

@@ -265,7 +265,7 @@ mod tests {
         fn a_million_letter_a() -> str {
             let mut i = 0;
             let mut rs = "";
-            while i < 100000 { rs += "aaaaaaaaaa"; i += 1; }
+            while i < 100000 { str::push_str(rs, "aaaaaaaaaa"); i += 1; }
             ret rs;
         }
         // Test messages from FIPS 180-1