---

yaml
---
r: 145695
b: refs/heads/try2
c: 435ca16
h: refs/heads/master
i:
  145693: 0314e0e
  145691: 77078c6
  145687: cbd057a
  145679: 4ce65ae
  145663: 066fe15
v: v3

Author: sfackler

[refs]

@@ -5,7 +5,7 @@ refs/heads/snap-stage3: 78a7676898d9f80ab540c6df5d4c9ce35bb50463
 refs/heads/try: 519addf6277dbafccbb4159db4b710c37eaa2ec5
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
-refs/heads/try2: 8f40641e01fe7f79e21f606733646c600820bbd8
+refs/heads/try2: 435ca16f4fa7bd47c16de693054be5cba5fd4ebb
 refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
 refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try2/src/libextra/extra.rs

@@ -26,8 +26,7 @@ Rust extras are part of the standard Rust distribution.
        url = "https://github.com/mozilla/rust/tree/master/src/libextra")];
 
 #[doc(html_logo_url = "http://www.rust-lang.org/logos/rust-logo-128x128-blk.png",
-      html_favicon_url = "http://www.rust-lang.org/favicon.ico",
-      html_root_url = "http://static.rust-lang.org/doc/master")];
+      html_favicon_url = "http://www.rust-lang.org/favicon.ico")];
 
 #[comment = "Rust extras"];
 #[license = "MIT/ASL2"];

branches/try2/src/librustdoc/clean.rs

@@ -15,18 +15,11 @@ use its = syntax::parse::token::ident_to_str;
 
 use syntax;
 use syntax::ast;
-use syntax::ast_map;
 use syntax::ast_util;
 use syntax::attr;
 use syntax::attr::AttributeMethods;
 
-use rustc::metadata::cstore;
-use rustc::metadata::csearch;
-use rustc::metadata::decoder;
-
 use std;
-use std::hashmap::HashMap;
-
 use doctree;
 use visit_ast;
 use std::local_data;
@@ -68,44 +61,19 @@ impl<T: Clean<U>, U> Clean<~[U]> for syntax::opt_vec::OptVec<T> {
 pub struct Crate {
     name: ~str,
     module: Option<Item>,
-    externs: HashMap<ast::CrateNum, ExternalCrate>,
 }
 
 impl Clean<Crate> for visit_ast::RustdocVisitor {
     fn clean(&self) -> Crate {
         use syntax::attr::{find_linkage_metas, last_meta_item_value_str_by_name};
-        let maybe_meta = last_meta_item_value_str_by_name(
-                                find_linkage_metas(self.attrs), "name");
-        let cx = local_data::get(super::ctxtkey, |x| *x.unwrap());
-
-        let mut externs = HashMap::new();
-        do cstore::iter_crate_data(cx.sess.cstore) |n, meta| {
-            externs.insert(n, meta.clean());
-        }
+        let maybe_meta = last_meta_item_value_str_by_name(find_linkage_metas(self.attrs), "name");
 
         Crate {
             name: match maybe_meta {
                 Some(x) => x.to_owned(),
-                None => fail2!("rustdoc requires a \\#[link(name=\"foo\")] \
-                                crate attribute"),
+                None => fail2!("rustdoc_ng requires a \\#[link(name=\"foo\")] crate attribute"),
             },
             module: Some(self.module.clean()),
-            externs: externs,
-        }
-    }
-}
-
-#[deriving(Clone, Encodable, Decodable)]
-pub struct ExternalCrate {
-    name: ~str,
-    attrs: ~[Attribute],
-}
-
-impl Clean<ExternalCrate> for cstore::crate_metadata {
-    fn clean(&self) -> ExternalCrate {
-        ExternalCrate {
-            name: self.name.to_owned(),
-            attrs: decoder::get_crate_attributes(self.data).clean()
         }
     }
 }
@@ -574,15 +542,7 @@ pub enum Type {
     ResolvedPath {
         path: Path,
         typarams: Option<~[TyParamBound]>,
-        id: ast::NodeId,
-    },
-    /// Same as above, but only external variants
-    ExternalPath {
-        path: Path,
-        typarams: Option<~[TyParamBound]>,
-        fqn: ~[~str],
-        kind: TypeKind,
-        crate: ast::CrateNum,
+        did: ast::DefId
     },
     // I have no idea how to usefully use this.
     TyParamBinder(ast::NodeId),
@@ -612,14 +572,6 @@ pub enum Type {
     // region, raw, other boxes, mutable
 }
 
-#[deriving(Clone, Encodable, Decodable)]
-pub enum TypeKind {
-    TypeStruct,
-    TypeEnum,
-    TypeTrait,
-    TypeFunction,
-}
-
 impl Clean<Type> for ast::Ty {
     fn clean(&self) -> Type {
         use syntax::ast::*;
@@ -1147,12 +1099,26 @@ fn name_from_pat(p: &ast::Pat) -> ~str {
     }
 }
 
+fn remove_comment_tags(s: &str) -> ~str {
+    if s.starts_with("/") {
+        match s.slice(0,3) {
+            &"///" => return s.slice(3, s.len()).trim().to_owned(),
+            &"/**" | &"/*!" => return s.slice(3, s.len() - 2).trim().to_owned(),
+            _ => return s.trim().to_owned()
+        }
+    } else {
+        return s.to_owned();
+    }
+}
+
 /// Given a Type, resolve it using the def_map
 fn resolve_type(path: Path, tpbs: Option<~[TyParamBound]>,
                 id: ast::NodeId) -> Type {
-    let cx = local_data::get(super::ctxtkey, |x| *x.unwrap());
+    use syntax::ast::*;
+
+    let dm = local_data::get(super::ctxtkey, |x| *x.unwrap()).tycx.def_map;
     debug2!("searching for {:?} in defmap", id);
-    let d = match cx.tycx.def_map.find(&id) {
+    let d = match dm.find(&id) {
         Some(k) => k,
         None => {
             let ctxt = local_data::get(super::ctxtkey, |x| *x.unwrap());
@@ -1162,41 +1128,28 @@ fn resolve_type(path: Path, tpbs: Option<~[TyParamBound]>,
         }
     };
 
-    let (def_id, kind) = match *d {
-        ast::DefFn(i, _) => (i, TypeFunction),
-        ast::DefSelf(i) | ast::DefSelfTy(i) => return Self(i),
-        ast::DefTy(i) => (i, TypeEnum),
-        ast::DefTrait(i) => {
+    let def_id = match *d {
+        DefFn(i, _) => i,
+        DefSelf(i) | DefSelfTy(i) => return Self(i),
+        DefTy(i) => i,
+        DefTrait(i) => {
             debug2!("saw DefTrait in def_to_id");
-            (i, TypeTrait)
+            i
         },
-        ast::DefPrimTy(p) => match p {
-            ast::ty_str => return String,
-            ast::ty_bool => return Bool,
+        DefPrimTy(p) => match p {
+            ty_str => return String,
+            ty_bool => return Bool,
             _ => return Primitive(p)
         },
-        ast::DefTyParam(i, _) => return Generic(i.node),
-        ast::DefStruct(i) => (i, TypeStruct),
-        ast::DefTyParamBinder(i) => {
+        DefTyParam(i, _) => return Generic(i.node),
+        DefStruct(i) => i,
+        DefTyParamBinder(i) => {
             debug2!("found a typaram_binder, what is it? {}", i);
             return TyParamBinder(i);
         },
         x => fail2!("resolved type maps to a weird def {:?}", x),
     };
-    if ast_util::is_local(def_id) {
-        ResolvedPath{ path: path, typarams: tpbs, id: def_id.node }
-    } else {
-        let fqn = csearch::get_item_path(cx.tycx, def_id);
-        let fqn = fqn.move_iter().map(|i| {
-            match i {
-                ast_map::path_mod(id) |
-                ast_map::path_name(id) |
-                ast_map::path_pretty_name(id, _) => id.clean()
-            }
-        }).to_owned_vec();
-        ExternalPath{ path: path, typarams: tpbs, fqn: fqn, kind: kind,
-                      crate: def_id.crate }
-    }
+    ResolvedPath{ path: path, typarams: tpbs, did: def_id }
 }
 
 fn resolve_use_source(path: Path, id: ast::NodeId) -> ImportSource {