Skip to content

Commit 9c5622a

Browse files
committed
---
yaml --- r: 13614 b: refs/heads/master c: be8b091 h: refs/heads/master v: v3
1 parent 26b87c8 commit 9c5622a

File tree

3 files changed

+2
-16
lines changed

3 files changed

+2
-16
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 290206b17890a76f96979ad629203d965ff35d1c
2+
refs/heads/master: be8b09160bb6cefc239a8ede5e4ac01e1d61adf9
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: 4a81779abd786ff22d71434c6d9a5917ea4cdfff
55
refs/heads/try: 2898dcc5d97da9427ac367542382b6239d9c0bbf

trunk/src/rt/arch/i386/morestack.S

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -213,15 +213,6 @@ MORESTACK:
213213

214214
popl %ebp
215215

216-
// FIXME: I don't think these rules are necessary
217-
// since the unwinder should never encounter an instruction
218-
// pointer pointing here.
219-
#if defined(__linux__) || defined(__APPLE__) || defined(__FreeBSD__)
220-
// Restore the rule for how to find %ebp
221-
.cfi_restore %ebp
222-
// Tell the unwinder how to find the CFA in terms of %esp
223-
.cfi_def_cfa %esp, 16
224-
#endif
225216
retl $8
226217

227218
.L$bail:

trunk/src/rt/arch/x86_64/morestack.S

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ MORESTACK:
5151

5252
subq $184, %rsp
5353

54-
// FIXME: libgcc also saves rax. not sure if we need to
54+
// FIXME: libgcc also saves rax. not sure if we need to (#2685)
5555

5656
// Save argument registers of the original function
5757
movq %rdi, (%rsp)
@@ -133,11 +133,6 @@ MORESTACK:
133133

134134
popq %rax // Restore the return value
135135
popq %rbp
136-
// FIXME: I don't think these rules are necessary
137-
// since the unwinder should never encounter an instruction
138-
// pointer pointing here.
139-
.cfi_restore %rbp
140-
.cfi_def_cfa %rsp, 16
141136
ret
142137

143138
.cfi_endproc

0 commit comments

Comments
 (0)