Skip to content

Commit 9e8cba8

Browse files
sfackleralexcrichton
authored andcommitted
---
yaml --- r: 124833 b: refs/heads/auto c: 456884b h: refs/heads/master i: 124831: 0185f56 v: v3
1 parent b886db5 commit 9e8cba8

File tree

2 files changed

+12
-13
lines changed

2 files changed

+12
-13
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ refs/heads/try3: 9387340aab40a73e8424c48fd42f0c521a4875c0
1313
refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
1414
refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
1515
refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
16-
refs/heads/auto: 2e24ef377e32ee2fe253046fdc073840279e4b95
16+
refs/heads/auto: 456884b7a0eb90038d915d8bc251a725451d284b
1717
refs/heads/servo: af82457af293e2a842ba6b7759b70288da276167
1818
refs/tags/release-0.6: b4ebcfa1812664df5e142f0134a5faea3918544c
1919
refs/tags/0.1: b19db808c2793fe2976759b85a355c3ad8c8b336

branches/auto/src/librustc/front/test.rs

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
use driver::session::Session;
1717
use front::config;
1818

19-
use std::cell::RefCell;
2019
use std::gc::{Gc, GC};
2120
use std::slice;
2221
use std::vec;
@@ -46,9 +45,9 @@ struct Test {
4645

4746
struct TestCtxt<'a> {
4847
sess: &'a Session,
49-
path: RefCell<Vec<ast::Ident>>,
48+
path: Vec<ast::Ident>,
5049
ext_cx: ExtCtxt<'a>,
51-
testfns: RefCell<Vec<Test> >,
50+
testfns: Vec<Test>,
5251
is_test_crate: bool,
5352
config: ast::CrateConfig,
5453
}
@@ -86,9 +85,9 @@ impl<'a> fold::Folder for TestHarnessGenerator<'a> {
8685
}
8786

8887
fn fold_item(&mut self, i: Gc<ast::Item>) -> SmallVector<Gc<ast::Item>> {
89-
self.cx.path.borrow_mut().push(i.ident);
88+
self.cx.path.push(i.ident);
9089
debug!("current path: {}",
91-
ast_util::path_name_i(self.cx.path.borrow().as_slice()));
90+
ast_util::path_name_i(self.cx.path.as_slice()));
9291

9392
if is_test_fn(&self.cx, i) || is_bench_fn(&self.cx, i) {
9493
match i.node {
@@ -102,20 +101,20 @@ impl<'a> fold::Folder for TestHarnessGenerator<'a> {
102101
debug!("this is a test function");
103102
let test = Test {
104103
span: i.span,
105-
path: self.cx.path.borrow().clone(),
104+
path: self.cx.path.clone(),
106105
bench: is_bench_fn(&self.cx, i),
107106
ignore: is_ignored(&self.cx, i),
108107
should_fail: should_fail(i)
109108
};
110-
self.cx.testfns.borrow_mut().push(test);
109+
self.cx.testfns.push(test);
111110
// debug!("have {} test/bench functions",
112111
// cx.testfns.len());
113112
}
114113
}
115114
}
116115

117116
let res = fold::noop_fold_item(&*i, self);
118-
self.cx.path.borrow_mut().pop();
117+
self.cx.path.pop();
119118
res
120119
}
121120

@@ -155,8 +154,8 @@ fn generate_test_harness(sess: &Session, krate: ast::Crate)
155154
deriving_hash_type_parameter: false,
156155
crate_name: "test".to_string(),
157156
}),
158-
path: RefCell::new(Vec::new()),
159-
testfns: RefCell::new(Vec::new()),
157+
path: Vec::new(),
158+
testfns: Vec::new(),
160159
is_test_crate: is_test_crate(&krate),
161160
config: krate.config.clone(),
162161
};
@@ -399,13 +398,13 @@ fn is_test_crate(krate: &ast::Crate) -> bool {
399398
}
400399

401400
fn mk_test_descs(cx: &TestCtxt) -> Gc<ast::Expr> {
402-
debug!("building test vector from {} tests", cx.testfns.borrow().len());
401+
debug!("building test vector from {} tests", cx.testfns.len());
403402

404403
box(GC) ast::Expr {
405404
id: ast::DUMMY_NODE_ID,
406405
node: ast::ExprVstore(box(GC) ast::Expr {
407406
id: ast::DUMMY_NODE_ID,
408-
node: ast::ExprVec(cx.testfns.borrow().iter().map(|test| {
407+
node: ast::ExprVec(cx.testfns.iter().map(|test| {
409408
mk_test_desc_and_fn_rec(cx, test)
410409
}).collect()),
411410
span: DUMMY_SP,

0 commit comments

Comments
 (0)