---

yaml
---
r: 79455
b: refs/heads/snap-stage3
c: 6c6d053
h: refs/heads/master
i:
  79453: 4b90596
  79451: 35650f5
  79447: 9601f13
  79439: 32a2dae
  79423: ab19176
v: v3

Author: jbclements

[refs]

@@ -1,7 +1,7 @@
 ---
 refs/heads/master: 124eb2119c78651cfaaa7a046a101fa2e20f83ca
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
-refs/heads/snap-stage3: 2f6498f7b4be2584d1164d68fc4d5ae485da2ea6
+refs/heads/snap-stage3: 6c6d053b0177ed91071128aa5a2f57539e746987
 refs/heads/try: ac820906c0e53eab79a98ee64f7231f57c3887b4
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b

branches/snap-stage3/src/libsyntax/ext/expand.rs

@@ -1452,10 +1452,6 @@ mod test {
         pprust::print_mod(s, &crate.module, crate.attrs);
     }
 
-    // "fn a() -> int { let b = 13; let c = b; b+c }" --> b & c should get new names, in the expr too.
-    // "macro_rules! f (($x:ident) => ($x + b)) fn a() -> int { let b = 13; f!(b)}" --> one should
-    //     be renamed, one should not.
-
     fn expand_and_resolve_and_pretty_print (crate_str : @str) -> ~str {
         let resolver = new_ident_resolver();
         let resolver_fold = fun_to_ident_folder(resolver);
@@ -1469,10 +1465,20 @@ mod test {
 
     #[test]
     fn automatic_renaming () {
+        // "fn a() -> int { let b = 13; let c = b; b+c }"
+        //    --> b & c should get new names, in the expr too.
+        // "macro_rules! f (($x:ident) => ($x + b)) fn a() -> int { let b = 13; f!(b)}"
+        //    --> one should be renamed, one should not.
+
         let teststrs =
-            ~[@"fn a() -> int { let b = 13; let c = b; b+c }",
-              @"macro_rules! f (($x:ident) => ($x + b)) fn a() -> int { let b = 13; f!(b)}"];
+            ~[// b & c should get new names throughout, in the expr too:
+                @"fn a() -> int { let b = 13; let c = b; b+c }",
+                // the use of b before the + should be renamed, the other one not:
+                @"macro_rules! f (($x:ident) => ($x + b)) fn a() -> int { let b = 13; f!(b)}",
+                // the b before the plus should not be renamed (requires marks)
+                @"macro_rules! f (($x:ident) => ({let b=9; ($x + b)})) fn a() -> int { f!(b)}"];
         for s in teststrs.iter() {
+            // we need regexps to test these!
             std::io::println(expand_and_resolve_and_pretty_print(*s));
         }
     }