---

yaml
---
r: 163667
b: refs/heads/snap-stage3
c: e64a007
h: refs/heads/master
i:
  163665: e9e9fed
  163663: 8ebc0df
v: v3

Author: Jorge Aparicio

[refs]

@@ -1,7 +1,7 @@
 ---
 refs/heads/master: 9146a919b616e39e528e4d7100d16eef52f1f852
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
-refs/heads/snap-stage3: f2ef2cda526ba601cf5091f65cb12962a0ae0956
+refs/heads/snap-stage3: e64a0072d66f0071f47325711a226f34d7b76f05
 refs/heads/try: 20cbbffeefc1f35e2ea63afce7b42fbd79611d42
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d

branches/snap-stage3/src/librustc/lint/builtin.rs

@@ -56,10 +56,9 @@ declare_lint! {
     "suggest using `loop { }` instead of `while true { }`"
 }
 
+#[deriving(Copy)]
 pub struct WhileTrue;
 
-impl Copy for WhileTrue {}
-
 impl LintPass for WhileTrue {
     fn get_lints(&self) -> LintArray {
         lint_array!(WHILE_TRUE)
@@ -83,10 +82,9 @@ declare_lint! {
     "detects unnecessary type casts that can be removed"
 }
 
+#[deriving(Copy)]
 pub struct UnusedCasts;
 
-impl Copy for UnusedCasts {}
-
 impl LintPass for UnusedCasts {
     fn get_lints(&self) -> LintArray {
         lint_array!(UNUSED_TYPECASTS)
@@ -126,13 +124,12 @@ declare_lint! {
     "shift exceeds the type's number of bits"
 }
 
+#[deriving(Copy)]
 pub struct TypeLimits {
     /// Id of the last visited negated expression
     negated_expr_id: ast::NodeId,
 }
 
-impl Copy for TypeLimits {}
-
 impl TypeLimits {
     pub fn new() -> TypeLimits {
         TypeLimits {
@@ -442,10 +439,9 @@ impl<'a, 'tcx, 'v> Visitor<'v> for ImproperCTypesVisitor<'a, 'tcx> {
     }
 }
 
+#[deriving(Copy)]
 pub struct ImproperCTypes;
 
-impl Copy for ImproperCTypes {}
-
 impl LintPass for ImproperCTypes {
     fn get_lints(&self) -> LintArray {
         lint_array!(IMPROPER_CTYPES)
@@ -486,10 +482,9 @@ declare_lint! {
     "use of owned (Box type) heap memory"
 }
 
+#[deriving(Copy)]
 pub struct BoxPointers;
 
-impl Copy for BoxPointers {}
-
 impl BoxPointers {
     fn check_heap_type<'a, 'tcx>(&self, cx: &Context<'a, 'tcx>,
                                  span: Span, ty: Ty<'tcx>) {
@@ -627,10 +622,9 @@ declare_lint! {
     "detects attributes that were not used by the compiler"
 }
 
+#[deriving(Copy)]
 pub struct UnusedAttributes;
 
-impl Copy for UnusedAttributes {}
-
 impl LintPass for UnusedAttributes {
     fn get_lints(&self) -> LintArray {
         lint_array!(UNUSED_ATTRIBUTES)
@@ -711,10 +705,9 @@ declare_lint! {
     "path statements with no effect"
 }
 
+#[deriving(Copy)]
 pub struct PathStatements;
 
-impl Copy for PathStatements {}
-
 impl LintPass for PathStatements {
     fn get_lints(&self) -> LintArray {
         lint_array!(PATH_STATEMENTS)
@@ -746,10 +739,9 @@ declare_lint! {
     "unused result of an expression in a statement"
 }
 
+#[deriving(Copy)]
 pub struct UnusedResults;
 
-impl Copy for UnusedResults {}
-
 impl LintPass for UnusedResults {
     fn get_lints(&self) -> LintArray {
         lint_array!(UNUSED_MUST_USE, UNUSED_RESULTS)
@@ -815,10 +807,9 @@ declare_lint! {
     "types, variants, traits and type parameters should have camel case names"
 }
 
+#[deriving(Copy)]
 pub struct NonCamelCaseTypes;
 
-impl Copy for NonCamelCaseTypes {}
-
 impl NonCamelCaseTypes {
     fn check_case(&self, cx: &Context, sort: &str, ident: ast::Ident, span: Span) {
         fn is_camel_case(ident: ast::Ident) -> bool {
@@ -939,10 +930,9 @@ declare_lint! {
     "methods, functions, lifetime parameters and modules should have snake case names"
 }
 
+#[deriving(Copy)]
 pub struct NonSnakeCase;
 
-impl Copy for NonSnakeCase {}
-
 impl NonSnakeCase {
     fn check_snake_case(&self, cx: &Context, sort: &str, ident: ast::Ident, span: Span) {
         fn is_snake_case(ident: ast::Ident) -> bool {
@@ -1053,10 +1043,9 @@ declare_lint! {
     "static constants should have uppercase identifiers"
 }
 
+#[deriving(Copy)]
 pub struct NonUpperCaseGlobals;
 
-impl Copy for NonUpperCaseGlobals {}
-
 impl LintPass for NonUpperCaseGlobals {
     fn get_lints(&self) -> LintArray {
         lint_array!(NON_UPPER_CASE_GLOBALS)
@@ -1107,10 +1096,9 @@ declare_lint! {
     "`if`, `match`, `while` and `return` do not need parentheses"
 }
 
+#[deriving(Copy)]
 pub struct UnusedParens;
 
-impl Copy for UnusedParens {}
-
 impl UnusedParens {
     fn check_unused_parens_core(&self, cx: &Context, value: &ast::Expr, msg: &str,
                                      struct_lit_needs_parens: bool) {
@@ -1202,10 +1190,9 @@ declare_lint! {
     "unnecessary braces around an imported item"
 }
 
+#[deriving(Copy)]
 pub struct UnusedImportBraces;
 
-impl Copy for UnusedImportBraces {}
-
 impl LintPass for UnusedImportBraces {
     fn get_lints(&self) -> LintArray {
         lint_array!(UNUSED_IMPORT_BRACES)
@@ -1242,10 +1229,9 @@ declare_lint! {
     "using `Struct { x: x }` instead of `Struct { x }`"
 }
 
+#[deriving(Copy)]
 pub struct NonShorthandFieldPatterns;
 
-impl Copy for NonShorthandFieldPatterns {}
-
 impl LintPass for NonShorthandFieldPatterns {
     fn get_lints(&self) -> LintArray {
         lint_array!(NON_SHORTHAND_FIELD_PATTERNS)
@@ -1276,10 +1262,9 @@ declare_lint! {
     "unnecessary use of an `unsafe` block"
 }
 
+#[deriving(Copy)]
 pub struct UnusedUnsafe;
 
-impl Copy for UnusedUnsafe {}
-
 impl LintPass for UnusedUnsafe {
     fn get_lints(&self) -> LintArray {
         lint_array!(UNUSED_UNSAFE)
@@ -1302,10 +1287,9 @@ declare_lint! {
     "usage of an `unsafe` block"
 }
 
+#[deriving(Copy)]
 pub struct UnsafeBlocks;
 
-impl Copy for UnsafeBlocks {}
-
 impl LintPass for UnsafeBlocks {
     fn get_lints(&self) -> LintArray {
         lint_array!(UNSAFE_BLOCKS)
@@ -1327,10 +1311,9 @@ declare_lint! {
     "detect mut variables which don't need to be mutable"
 }
 
+#[deriving(Copy)]
 pub struct UnusedMut;
 
-impl Copy for UnusedMut {}
-
 impl UnusedMut {
     fn check_unused_mut_pat(&self, cx: &Context, pats: &[P<ast::Pat>]) {
         // collect all mutable pattern and group their NodeIDs by their Identifier to
@@ -1397,10 +1380,9 @@ declare_lint! {
     "detects unnecessary allocations that can be eliminated"
 }
 
+#[deriving(Copy)]
 pub struct UnusedAllocation;
 
-impl Copy for UnusedAllocation {}
-
 impl LintPass for UnusedAllocation {
     fn get_lints(&self) -> LintArray {
         lint_array!(UNUSED_ALLOCATION)
@@ -1589,10 +1571,9 @@ impl LintPass for MissingDoc {
     }
 }
 
+#[deriving(Copy)]
 pub struct MissingCopyImplementations;
 
-impl Copy for MissingCopyImplementations {}
-
 impl LintPass for MissingCopyImplementations {
     fn get_lints(&self) -> LintArray {
         lint_array!(MISSING_COPY_IMPLEMENTATIONS)
@@ -1665,10 +1646,9 @@ declare_lint! {
 
 /// Checks for use of items with `#[deprecated]`, `#[experimental]` and
 /// `#[unstable]` attributes, or no stability attribute.
+#[deriving(Copy)]
 pub struct Stability;
 
-impl Copy for Stability {}
-
 impl Stability {
     fn lint(&self, cx: &Context, id: ast::DefId, span: Span) {
         let stability = stability::lookup(cx.tcx, id);
@@ -1903,10 +1883,9 @@ declare_lint!{
 
 /// Does nothing as a lint pass, but registers some `Lint`s
 /// which are used by other parts of the compiler.
+#[deriving(Copy)]
 pub struct HardwiredLints;
 
-impl Copy for HardwiredLints {}
-
 impl LintPass for HardwiredLints {
     fn get_lints(&self) -> LintArray {
         lint_array!(

branches/snap-stage3/src/librustc/lint/mod.rs

@@ -42,6 +42,7 @@ use syntax::ast;
 pub use lint::context::{Context, LintStore, raw_emit_lint, check_crate, gather_attrs};
 
 /// Specification of a single lint.
+#[deriving(Copy)]
 pub struct Lint {
     /// A string identifier for the lint.
     ///
@@ -64,8 +65,6 @@ pub struct Lint {
     pub desc: &'static str,
 }
 
-impl Copy for Lint {}
-
 impl Lint {
     /// Get the lint's name, with ASCII letters converted to lowercase.
     pub fn name_lower(&self) -> String {
@@ -175,14 +174,12 @@ pub trait LintPass {
 pub type LintPassObject = Box<LintPass + 'static>;
 
 /// Identifies a lint known to the compiler.
-#[deriving(Clone)]
+#[deriving(Clone, Copy)]
 pub struct LintId {
     // Identity is based on pointer equality of this field.
     lint: &'static Lint,
 }
 
-impl Copy for LintId {}
-
 impl PartialEq for LintId {
     fn eq(&self, other: &LintId) -> bool {
         (self.lint as *const Lint) == (other.lint as *const Lint)
@@ -213,13 +210,11 @@ impl LintId {
 }
 
 /// Setting for how to handle a lint.
-#[deriving(Clone, PartialEq, PartialOrd, Eq, Ord)]
+#[deriving(Clone, Copy, PartialEq, PartialOrd, Eq, Ord)]
 pub enum Level {
     Allow, Warn, Deny, Forbid
 }
 
-impl Copy for Level {}
-
 impl Level {
     /// Convert a level to a lower-case string.
     pub fn as_str(self) -> &'static str {
@@ -244,7 +239,7 @@ impl Level {
 }
 
 /// How a lint level was set.
-#[deriving(Clone, PartialEq, Eq)]
+#[deriving(Clone, Copy, PartialEq, Eq)]
 pub enum LintSource {
     /// Lint is at the default level as declared
     /// in rustc or a plugin.
@@ -257,8 +252,6 @@ pub enum LintSource {
     CommandLine,
 }
 
-impl Copy for LintSource {}
-
 pub type LevelSource = (Level, LintSource);
 
 pub mod builtin;

branches/snap-stage3/src/librustc/metadata/common.rs

@@ -113,7 +113,7 @@ pub const tag_items_data_item_reexport_def_id: uint = 0x39;
 pub const tag_items_data_item_reexport_name: uint = 0x3a;
 
 // used to encode crate_ctxt side tables
-#[deriving(PartialEq)]
+#[deriving(Copy, PartialEq)]
 #[repr(uint)]
 pub enum astencode_tag { // Reserves 0x40 -- 0x5f
     tag_ast = 0x40,
@@ -145,7 +145,6 @@ pub enum astencode_tag { // Reserves 0x40 -- 0x5f
     tag_table_object_cast_map = 0x57,
 }
 
-impl Copy for astencode_tag {}
 static first_astencode_tag: uint = tag_ast as uint;
 static last_astencode_tag: uint = tag_table_object_cast_map as uint;
 impl astencode_tag {

branches/snap-stage3/src/librustc/metadata/csearch.rs

@@ -33,14 +33,13 @@ use syntax::parse::token;
 
 use std::collections::hash_map::HashMap;
 
+#[deriving(Copy)]
 pub struct MethodInfo {
     pub name: ast::Name,
     pub def_id: ast::DefId,
     pub vis: ast::Visibility,
 }
 
-impl Copy for MethodInfo {}
-
 pub fn get_symbol(cstore: &cstore::CStore, def: ast::DefId) -> String {
     let cdata = cstore.get_crate_data(def.krate);
     decoder::get_symbol(cdata.data(), def.node)

branches/snap-stage3/src/librustc/metadata/cstore.rs

@@ -48,23 +48,19 @@ pub struct crate_metadata {
     pub span: Span,
 }
 
-#[deriving(Show, PartialEq, Clone)]
+#[deriving(Copy, Show, PartialEq, Clone)]
 pub enum LinkagePreference {
     RequireDynamic,
     RequireStatic,
 }
 
-impl Copy for LinkagePreference {}
-
-#[deriving(Clone, PartialEq, FromPrimitive)]
+#[deriving(Copy, Clone, PartialEq, FromPrimitive)]
 pub enum NativeLibraryKind {
     NativeStatic,    // native static library (.a archive)
     NativeFramework, // OSX-specific
     NativeUnknown,   // default way to specify a dynamic library
 }
 
-impl Copy for NativeLibraryKind {}
-
 // Where a crate came from on the local filesystem. One of these two options
 // must be non-None.
 #[deriving(PartialEq, Clone)]