Skip to content

Commit 9fae469

Browse files
committed
fix clippy::single-match-else and clippy::match_same_arms warnings in clippys codebase
1 parent 2a31937 commit 9fae469

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

clippy_lints/src/duration_subsec.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,8 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for DurationSubsec {
4646
if let Some((Constant::Int(divisor), _)) = constant(cx, cx.tables, right);
4747
then {
4848
let suggested_fn = match (method_path.ident.as_str().as_ref(), divisor) {
49-
("subsec_micros", 1_000) => "subsec_millis",
49+
("subsec_micros", 1_000) | ("subsec_nanos", 1_000_000) => "subsec_millis",
5050
("subsec_nanos", 1_000) => "subsec_micros",
51-
("subsec_nanos", 1_000_000) => "subsec_millis",
5251
_ => return,
5352
};
5453
span_lint_and_sugg(

clippy_lints/src/multiple_crate_versions.rs

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,17 @@ impl LintPass for Pass {
4141

4242
impl EarlyLintPass for Pass {
4343
fn check_crate(&mut self, cx: &EarlyContext<'_>, krate: &Crate) {
44-
let metadata = match cargo_metadata::metadata_deps(None, true) {
45-
Ok(metadata) => metadata,
46-
Err(_) => {
47-
span_lint(
48-
cx,
49-
MULTIPLE_CRATE_VERSIONS,
50-
krate.span,
51-
"could not read cargo metadata"
52-
);
44+
let metadata = if let Ok(metadata) = cargo_metadata::metadata_deps(None, true) {
45+
metadata
46+
} else {
47+
span_lint(
48+
cx,
49+
MULTIPLE_CRATE_VERSIONS,
50+
krate.span,
51+
"could not read cargo metadata"
52+
);
5353

54-
return;
55-
}
54+
return;
5655
};
5756

5857
let mut packages = metadata.packages;

0 commit comments

Comments
 (0)