Skip to content

Commit a127264

Browse files
committed
expansion: Rename Expansion to AstFragment
1 parent 869fa27 commit a127264

File tree

5 files changed

+207
-194
lines changed

5 files changed

+207
-194
lines changed

src/librustc_resolve/macros.rs

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ use syntax::attr::{self, HasAttrs};
2323
use syntax::errors::DiagnosticBuilder;
2424
use syntax::ext::base::{self, Annotatable, Determinacy, MultiModifier, MultiDecorator};
2525
use syntax::ext::base::{MacroKind, SyntaxExtension, Resolver as SyntaxResolver};
26-
use syntax::ext::expand::{Expansion, ExpansionKind, Invocation, InvocationKind, find_attr_invoc};
26+
use syntax::ext::expand::{self, AstFragment, AstFragmentKind, Invocation, InvocationKind};
2727
use syntax::ext::hygiene::{self, Mark, Transparency};
2828
use syntax::ext::placeholders::placeholder;
2929
use syntax::ext::tt::macro_rules;
@@ -187,9 +187,10 @@ impl<'a> base::Resolver for Resolver<'a> {
187187
self.whitelisted_legacy_custom_derives.contains(&name)
188188
}
189189

190-
fn visit_expansion(&mut self, mark: Mark, expansion: &Expansion, derives: &[Mark]) {
190+
fn visit_ast_fragment_with_placeholders(&mut self, mark: Mark, fragment: &AstFragment,
191+
derives: &[Mark]) {
191192
let invocation = self.invocations[&mark];
192-
self.collect_def_ids(mark, invocation, expansion);
193+
self.collect_def_ids(mark, invocation, fragment);
193194

194195
self.current_module = invocation.module.get();
195196
self.current_module.unresolved_invocations.borrow_mut().remove(&mark);
@@ -202,7 +203,7 @@ impl<'a> base::Resolver for Resolver<'a> {
202203
legacy_scope: LegacyScope::Invocation(invocation),
203204
expansion: mark,
204205
};
205-
expansion.visit_with(&mut visitor);
206+
fragment.visit_with(&mut visitor);
206207
invocation.expansion.set(visitor.legacy_scope);
207208
}
208209

@@ -396,14 +397,14 @@ impl<'a> Resolver<'a> {
396397
Ok(ext) => if let SyntaxExtension::ProcMacroDerive(_, ref inert_attrs, _) = *ext {
397398
if inert_attrs.contains(&attr_name) {
398399
// FIXME(jseyfried) Avoid `mem::replace` here.
399-
let dummy_item = placeholder(ExpansionKind::Items, ast::DUMMY_NODE_ID)
400+
let dummy_item = placeholder(AstFragmentKind::Items, ast::DUMMY_NODE_ID)
400401
.make_items().pop().unwrap();
401402
let dummy_item = Annotatable::Item(dummy_item);
402403
*item = mem::replace(item, dummy_item).map_attrs(|mut attrs| {
403404
let inert_attr = attr.take().unwrap();
404405
attr::mark_known(&inert_attr);
405406
if self.proc_macro_enabled {
406-
*attr = find_attr_invoc(&mut attrs);
407+
*attr = expand::find_attr_invoc(&mut attrs);
407408
}
408409
attrs.push(inert_attr);
409410
attrs
@@ -769,7 +770,7 @@ impl<'a> Resolver<'a> {
769770
fn collect_def_ids(&mut self,
770771
mark: Mark,
771772
invocation: &'a InvocationData<'a>,
772-
expansion: &Expansion) {
773+
fragment: &AstFragment) {
773774
let Resolver { ref mut invocations, arenas, graph_root, .. } = *self;
774775
let InvocationData { def_index, .. } = *invocation;
775776

@@ -787,7 +788,7 @@ impl<'a> Resolver<'a> {
787788
let mut def_collector = DefCollector::new(&mut self.definitions, mark);
788789
def_collector.visit_macro_invoc = Some(visit_macro_invoc);
789790
def_collector.with_parent(def_index, |def_collector| {
790-
expansion.visit_with(def_collector)
791+
fragment.visit_with(def_collector)
791792
});
792793
}
793794

src/libsyntax/ext/base.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ use codemap::{self, CodeMap, Spanned, respan};
1616
use syntax_pos::{Span, MultiSpan, DUMMY_SP};
1717
use edition::Edition;
1818
use errors::{DiagnosticBuilder, DiagnosticId};
19-
use ext::expand::{self, Expansion, Invocation};
19+
use ext::expand::{self, AstFragment, Invocation};
2020
use ext::hygiene::{self, Mark, SyntaxContext};
2121
use fold::{self, Folder};
2222
use parse::{self, parser, DirectoryOwnership};
@@ -697,7 +697,8 @@ pub trait Resolver {
697697
fn eliminate_crate_var(&mut self, item: P<ast::Item>) -> P<ast::Item>;
698698
fn is_whitelisted_legacy_custom_derive(&self, name: Name) -> bool;
699699

700-
fn visit_expansion(&mut self, mark: Mark, expansion: &Expansion, derives: &[Mark]);
700+
fn visit_ast_fragment_with_placeholders(&mut self, mark: Mark, fragment: &AstFragment,
701+
derives: &[Mark]);
701702
fn add_builtin(&mut self, ident: ast::Ident, ext: Lrc<SyntaxExtension>);
702703

703704
fn resolve_imports(&mut self);
@@ -726,7 +727,8 @@ impl Resolver for DummyResolver {
726727
fn eliminate_crate_var(&mut self, item: P<ast::Item>) -> P<ast::Item> { item }
727728
fn is_whitelisted_legacy_custom_derive(&self, _name: Name) -> bool { false }
728729

729-
fn visit_expansion(&mut self, _invoc: Mark, _expansion: &Expansion, _derives: &[Mark]) {}
730+
fn visit_ast_fragment_with_placeholders(&mut self, _invoc: Mark, _fragment: &AstFragment,
731+
_derives: &[Mark]) {}
730732
fn add_builtin(&mut self, _ident: ast::Ident, _ext: Lrc<SyntaxExtension>) {}
731733

732734
fn resolve_imports(&mut self) {}

0 commit comments

Comments
 (0)