Skip to content

Commit a1cc934

Browse files
committed
---
yaml --- r: 207693 b: refs/heads/tmp c: 38a97be h: refs/heads/master i: 207691: b9aa467 v: v3
1 parent f5ffb73 commit a1cc934

File tree

3 files changed

+7
-19
lines changed

3 files changed

+7
-19
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ refs/heads/building: 126db549b038c84269a1e4fe46f051b2c15d6970
3232
refs/heads/beta: cd7d89af9169885642d43597302af69f842bbd78
3333
refs/heads/windistfix: 7608dbad651f02e837ed05eef3d74a6662a6e928
3434
refs/tags/1.0.0-alpha: e42bd6d93a1d3433c486200587f8f9e12590a4d7
35-
refs/heads/tmp: c3d60aba6c86883c79055c1a3923d4db116b644e
35+
refs/heads/tmp: 38a97becdf3e6a6157f6f7ec2d98ade8d8edc193
3636
refs/tags/1.0.0-alpha.2: 4c705f6bc559886632d3871b04f58aab093bfa2f
3737
refs/tags/homu-tmp: 704c2ee730d2e948d11a2edd77e3f35de8329a6e
3838
refs/heads/gate: 97c84447b65164731087ea82685580cc81424412

branches/tmp/mk/docs.mk

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ ERR_IDX_GEN = $(RPATH_VAR2_T_$(CFG_BUILD)_H_$(CFG_BUILD)) $(ERR_IDX_GEN_EXE)
7777

7878
D := $(S)src/doc
7979

80-
DOC_TARGETS := trpl style error-index
80+
# FIXME (#25705) eventually may want to put error-index target back here.
81+
DOC_TARGETS := trpl style
8182
COMPILER_DOC_TARGETS :=
8283
DOC_L10N_TARGETS :=
8384

branches/tmp/src/libsyntax/diagnostics/plugin.rs

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ use std::collections::BTreeMap;
1414
use ast;
1515
use ast::{Ident, Name, TokenTree};
1616
use codemap::Span;
17-
use diagnostics::metadata::{check_uniqueness, output_metadata, Duplicate};
1817
use ext::base::{ExtCtxt, MacEager, MacResult};
1918
use ext::build::AstBuilder;
2019
use parse::token;
@@ -148,7 +147,7 @@ pub fn expand_build_diagnostic_array<'cx>(ecx: &'cx mut ExtCtxt,
148147
token_tree: &[TokenTree])
149148
-> Box<MacResult+'cx> {
150149
assert_eq!(token_tree.len(), 3);
151-
let (crate_name, name) = match (&token_tree[0], &token_tree[2]) {
150+
let (_crate_name, name) = match (&token_tree[0], &token_tree[2]) {
152151
(
153152
// Crate name.
154153
&ast::TtToken(_, token::Ident(ref crate_name, _)),
@@ -158,21 +157,9 @@ pub fn expand_build_diagnostic_array<'cx>(ecx: &'cx mut ExtCtxt,
158157
_ => unreachable!()
159158
};
160159

161-
// Check uniqueness of errors and output metadata.
162-
with_registered_diagnostics(|diagnostics| {
163-
match check_uniqueness(crate_name, &*diagnostics) {
164-
Ok(Duplicate(err, location)) => {
165-
ecx.span_err(span, &format!(
166-
"error {} from `{}' also found in `{}'",
167-
err, crate_name, location
168-
));
169-
},
170-
Ok(_) => (),
171-
Err(e) => panic!("{}", e.description())
172-
}
173-
174-
output_metadata(&*ecx, crate_name, &*diagnostics).ok().expect("metadata output error");
175-
});
160+
// FIXME (#25705): we used to ensure error code uniqueness and
161+
// output error description JSON metadata here, but the approach
162+
// employed was too brittle.
176163

177164
// Construct the output expression.
178165
let (count, expr) =

0 commit comments

Comments
 (0)