Skip to content

Commit a1cf396

Browse files
committed
---
yaml --- r: 170911 b: refs/heads/try c: 9d0b3c9 h: refs/heads/master i: 170909: 3605668 170907: 0091a66 170903: 016c3f0 170895: 86d3520 170879: fafa0b2 v: v3
1 parent 2dba614 commit a1cf396

File tree

6 files changed

+2
-62
lines changed

6 files changed

+2
-62
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
refs/heads/master: 73a25f55ad748b4d3516417c711b99ce446591af
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: 5b3cd3900ceda838f5798c30ab96ceb41f962534
5-
refs/heads/try: 8efd9901b628d687d11a4d0ccc153553b38ada49
5+
refs/heads/try: 9d0b3c9fc91dbde74f7cafc85377432447c0d364
66
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
77
refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
88
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596

branches/try/src/librustc/metadata/creader.rs

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,13 @@ use metadata::cstore::{CStore, CrateSource, MetadataBlob};
2020
use metadata::decoder;
2121
use metadata::loader;
2222
use metadata::loader::CratePaths;
23-
use util::nodemap::FnvHashMap;
2423

2524
use std::rc::Rc;
26-
use std::collections::hash_map::Entry::{Occupied, Vacant};
2725
use syntax::ast;
2826
use syntax::abi;
2927
use syntax::attr;
3028
use syntax::attr::AttrMetaMethods;
3129
use syntax::codemap::{Span, mk_sp};
32-
use syntax::diagnostic::SpanHandler;
3330
use syntax::parse;
3431
use syntax::parse::token::InternedString;
3532
use syntax::parse::token;
@@ -67,27 +64,6 @@ fn dump_crates(cstore: &CStore) {
6764
})
6865
}
6966

70-
fn warn_if_multiple_versions(diag: &SpanHandler, cstore: &CStore) {
71-
let mut map = FnvHashMap::new();
72-
cstore.iter_crate_data(|cnum, data| {
73-
match map.entry(&data.name()) {
74-
Vacant(entry) => { entry.insert(vec![cnum]); },
75-
Occupied(mut entry) => { entry.get_mut().push(cnum); },
76-
}
77-
});
78-
79-
for (name, dupes) in map.into_iter() {
80-
if dupes.len() == 1 { continue }
81-
diag.handler().warn(
82-
format!("using multiple versions of crate `{}`", name)[]);
83-
for dupe in dupes.into_iter() {
84-
let data = cstore.get_crate_data(dupe);
85-
diag.span_note(data.span, "used here");
86-
loader::note_crate_name(diag, data.name()[]);
87-
}
88-
}
89-
}
90-
9167
fn should_link(i: &ast::ViewItem) -> bool {
9268
!attr::contains_name(i.attrs[], "no_link")
9369
}
@@ -188,7 +164,6 @@ impl<'a> CrateReader<'a> {
188164
if log_enabled!(log::DEBUG) {
189165
dump_crates(&self.sess.cstore);
190166
}
191-
warn_if_multiple_versions(self.sess.diagnostic(), &self.sess.cstore);
192167

193168
for &(ref name, kind) in self.sess.opts.libs.iter() {
194169
register_native_lib(self.sess, None, name.clone(), kind);

branches/try/src/test/run-make/extern-diff-internal-name/Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@
22

33
all:
44
$(RUSTC) lib.rs
5-
$(RUSTC) test.rs --extern foo=$(TMPDIR)/libbar.rlib 2>&1 | \
6-
{ ! grep "using multiple versions of crate"; }
5+
$(RUSTC) test.rs --extern foo=$(TMPDIR)/libbar.rlib

branches/try/src/test/run-make/multiple-versions/Makefile

Lines changed: 0 additions & 9 deletions
This file was deleted.

branches/try/src/test/run-make/multiple-versions/bar.rs

Lines changed: 0 additions & 14 deletions
This file was deleted.

branches/try/src/test/run-make/multiple-versions/foo.rs

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)