---

yaml
---
r: 59055
b: refs/heads/incoming
c: 7d4bb90
h: refs/heads/master
i:
  59053: a3650b5
  59051: fa1c07a
  59047: 499af1e
  59039: 0539200
v: v3

Author: emberian

[refs]

@@ -6,7 +6,7 @@ refs/heads/try: c50a9d5b664478e533ba1d1d353213d70c8ad589
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
 refs/heads/try2: 147ecfdd8221e4a4d4e090486829a06da1e0ca3c
-refs/heads/incoming: d546493096f35e68cbcd9b5d3d7654e7a9345744
+refs/heads/incoming: 7d4bb90e76207f3715126562fd50193fda97ff49
 refs/heads/dist-snap: 00dbbd01c2aee72982b3e0f9511ae1d4428c3ba9
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
 refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/incoming/src/libcore/unstable/intrinsics.rs

@@ -42,17 +42,12 @@ pub extern "rust-intrinsic" {
 
     pub fn get_tydesc<T>() -> *();
 
-    /// init is unsafe because it returns a zeroed-out datum,
-    /// which is unsafe unless T is POD. We don't have a POD
-    /// kind yet. (See #4074)
-    pub unsafe fn init<T>() -> T;
+    pub fn init<T>() -> T;
 
     #[cfg(not(stage0))]
     pub unsafe fn uninit<T>() -> T;
 
-    /// forget is unsafe because the caller is responsible for
-    /// ensuring the argument is deallocated already
-    pub unsafe fn forget<T>(_: T) -> ();
+    pub fn forget<T>(_: T) -> ();
 
     pub fn needs_drop<T>() -> bool;
 

branches/incoming/src/librustc/middle/resolve.rs

@@ -1909,7 +1909,6 @@ pub impl Resolver {
             }
 
             if self.unresolved_imports == prev_unresolved_imports {
-                self.session.err(~"failed to resolve imports");
                 self.report_unresolved_imports(module_root);
                 break;
             }

branches/incoming/src/librustc/middle/trans/expr.rs

@@ -968,10 +968,7 @@ fn trans_lvalue_unadjusted(bcx: block, expr: @ast::expr) -> DatumBlock {
                 }
 
                 fn get_val(bcx: block, did: ast::def_id, const_ty: ty::t)
-                           -> ValueRef {
-                    // For external constants, we don't inline.
-                    let extern_const_values =
-                        &mut *bcx.ccx().extern_const_values;
+                    -> ValueRef {
                     if did.crate == ast::local_crate {
                         // The LLVM global has the type of its initializer,
                         // which may not be equal to the enum's type for
@@ -980,24 +977,25 @@ fn trans_lvalue_unadjusted(bcx: block, expr: @ast::expr) -> DatumBlock {
                                     base::get_item_val(bcx.ccx(), did.node),
                                     T_ptr(type_of(bcx.ccx(), const_ty)))
                     } else {
-                        match extern_const_values.find(&did) {
-                            None => {}  // Continue.
-                            Some(llval) => {
-                                return *llval;
+                        // For external constants, we don't inline.
+                        match bcx.ccx().extern_const_values.find(&did) {
+                            None => {
+                                unsafe {
+                                    let llty = type_of(bcx.ccx(), const_ty);
+                                    let symbol = csearch::get_symbol(
+                                        bcx.ccx().sess.cstore,
+                                        did);
+                                    let llval = llvm::LLVMAddGlobal(
+                                        bcx.ccx().llmod,
+                                        llty,
+                                        transmute::<&u8,*i8>(&symbol[0]));
+                                    bcx.ccx().extern_const_values.insert(
+                                        did,
+                                        llval);
+                                    llval
+                                }
                             }
-                        }
-
-                        unsafe {
-                            let llty = type_of(bcx.ccx(), const_ty);
-                            let symbol = csearch::get_symbol(
-                                bcx.ccx().sess.cstore,
-                                did);
-                            let llval = llvm::LLVMAddGlobal(
-                                bcx.ccx().llmod,
-                                llty,
-                                transmute::<&u8,*i8>(&symbol[0]));
-                            extern_const_values.insert(did, llval);
-                            llval
+                            Some(llval) => *llval
                         }
                     }
                 }