---

brson · brson · commit a3cfc6262cd4 · 2011-06-16T17:23:20.000-07:00
yaml --- r: 3190 b: refs/heads/master c: 6f4326c h: refs/heads/master v: v3
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: fc12577fdd7969f5e9a136915f6ef48e67acd3bc
+refs/heads/master: 6f4326c54d4638950d30a72aa2aa4aa4bd42fd21
diff --git a/trunk/src/comp/front/parser.rs b/trunk/src/comp/front/parser.rs
@@ -2125,7 +2125,8 @@ fn parse_inner_attrs_and_next(&parser p) -> tup(vec[ast::attribute],
 fn parse_inner_attrs(&parser p) -> vec[ast::attribute] {
     auto attrs_and_next = parse_inner_attrs_and_next(p);
     if (vec::len(attrs_and_next._1) > 0u) {
-        // FIXME: Don't drop this dangling attr on the ground
+        ret p.err("expected crate directive but found " +
+                  token::to_str(p.get_reader(), p.peek()));
     }
     ret attrs_and_next._0;
 }
diff --git a/trunk/src/test/compile-fail/attr-bad-crate-attr.rc b/trunk/src/test/compile-fail/attr-bad-crate-attr.rc
@@ -0,0 +1,5 @@
+// xfail-stage0
+// error-pattern: expected crate directive
+
+#[attr = "val"];
+#[attr = "val"] // Unterminated

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`---`
`2`		`-refs/heads/master: fc12577fdd7969f5e9a136915f6ef48e67acd3bc`
	`2`	`+refs/heads/master: 6f4326c54d4638950d30a72aa2aa4aa4bd42fd21`
Original file line number	Diff line number	Diff line change
`@@ -2125,7 +2125,8 @@ fn parse_inner_attrs_and_next(&parser p) -> tup(vec[ast::attribute],`
`2125`	`2125`	`fn parse_inner_attrs(&parser p) -> vec[ast::attribute] {`
`2126`	`2126`	`auto attrs_and_next = parse_inner_attrs_and_next(p);`
`2127`	`2127`	`if (vec::len(attrs_and_next._1) > 0u) {`
`2128`		`- // FIXME: Don't drop this dangling attr on the ground`
	`2128`	`+ ret p.err("expected crate directive but found " +`
	`2129`	`+ token::to_str(p.get_reader(), p.peek()));`
`2129`	`2130`	`}`
`2130`	`2131`	`ret attrs_and_next._0;`
`2131`	`2132`	`}`