---

yaml
---
r: 159195
b: refs/heads/snap-stage3
c: ba24e33
h: refs/heads/master
i:
  159193: 712f8ea
  159191: 14beeff
v: v3

Author: csherratt

[refs]

@@ -1,7 +1,7 @@
 ---
 refs/heads/master: 40fb87d40f681f5356af42175fc7b85da387f037
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
-refs/heads/snap-stage3: 7a666df5fa6295e82d4350a6eb105c0370aca7a1
+refs/heads/snap-stage3: ba24e3302102eb97c253ad8d0ad08a5678428ae5
 refs/heads/try: f58aad6dce273570fb130b4df008ef9acd5a5be2
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d

branches/snap-stage3/src/libcollections/ring_buf.rs

@@ -115,15 +115,21 @@ impl<T> RingBuf<T> {
         let size = cap.checked_mul(&mem::size_of::<T>())
                       .expect("capacity overflow");
 
+        let ptr = if mem::size_of::<T>() != 0 {
+            unsafe {
+                let ptr = heap::allocate(size, mem::min_align_of::<T>())  as *mut T;;
+                if ptr.is_null() { ::alloc::oom() }
+                ptr
+            }
+        } else {
+            heap::EMPTY as *mut T
+        };
+
         RingBuf {
             tail: 0,
             head: 0,
             cap: cap,
-            ptr: if mem::size_of::<T>() != 0 {
-                unsafe { heap::allocate(size, mem::min_align_of::<T>()) as *mut T }
-            } else {
-                heap::EMPTY as *mut T
-            }
+            ptr: ptr
         }
     }
 
@@ -282,6 +288,7 @@ impl<T> RingBuf<T> {
                                                 old,
                                                 new,
                                                 mem::min_align_of::<T>()) as *mut T;
+                    if self.ptr.is_null() { ::alloc::oom() }
                 }
             }
 
@@ -422,9 +429,7 @@ impl<T> RingBuf<T> {
     /// ```
     #[unstable = "matches collection reform specification, waiting for dust to settle"]
     pub fn clear(&mut self) {
-        while !self.is_empty() {
-            self.pop_front();
-        }
+        while self.pop_front().is_some() {}
         self.head = 0;
         self.tail = 0;
     }
@@ -720,7 +725,7 @@ impl<'a, T> Iterator<&'a mut T> for MutItems<'a, T> {
         if mem::size_of::<T>() != 0 {
             unsafe { Some(&mut *self.ptr.offset(tail as int)) }
         } else {
-            // use a none zero pointer
+            // use a non-zero pointer
             Some(unsafe { mem::transmute(1u) })
         }
     }