Skip to content

Commit a8da686

Browse files
committed
---
yaml --- r: 82871 b: refs/heads/auto c: 371a7ec h: refs/heads/master i: 82869: ec3d872 82867: 4d5c054 82863: 37bcc25 v: v3
1 parent 2e32a04 commit a8da686

File tree

15 files changed

+96
-41
lines changed

15 files changed

+96
-41
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ refs/heads/try3: 9387340aab40a73e8424c48fd42f0c521a4875c0
1313
refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
1414
refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
1515
refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
16-
refs/heads/auto: 49e6db7f3510a99ab3d3723b2430add985629c39
16+
refs/heads/auto: 371a7ec56959323fd8add557219c4cbcac89825f
1717
refs/heads/servo: af82457af293e2a842ba6b7759b70288da276167
1818
refs/tags/release-0.6: b4ebcfa1812664df5e142f0134a5faea3918544c
1919
refs/tags/0.1: b19db808c2793fe2976759b85a355c3ad8c8b336

branches/auto/src/libextra/getopts.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,15 @@ use std::vec;
8585

8686
/// Name of an option. Either a string or a single char.
8787
#[deriving(Clone, Eq)]
88+
#[allow(missing_doc)]
8889
pub enum Name {
8990
Long(~str),
9091
Short(char),
9192
}
9293

9394
/// Describes whether an option has an argument.
9495
#[deriving(Clone, Eq)]
96+
#[allow(missing_doc)]
9597
pub enum HasArg {
9698
Yes,
9799
No,
@@ -100,6 +102,7 @@ pub enum HasArg {
100102

101103
/// Describes how often an option may occur.
102104
#[deriving(Clone, Eq)]
105+
#[allow(missing_doc)]
103106
pub enum Occur {
104107
Req,
105108
Optional,
@@ -141,6 +144,7 @@ pub struct Matches {
141144
/// The type returned when the command line does not conform to the
142145
/// expected format. Pass this value to <fail_str> to get an error message.
143146
#[deriving(Clone, Eq, ToStr)]
147+
#[allow(missing_doc)]
144148
pub enum Fail_ {
145149
ArgumentMissing(~str),
146150
UnrecognizedOption(~str),
@@ -151,6 +155,7 @@ pub enum Fail_ {
151155

152156
/// The type of failure that occured.
153157
#[deriving(Eq)]
158+
#[allow(missing_doc)]
154159
pub enum FailType {
155160
ArgumentMissing_,
156161
UnrecognizedOption_,

branches/auto/src/libextra/list.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,14 @@
1313

1414

1515
#[deriving(Clone, Eq)]
16+
#[allow(missing_doc)]
1617
pub enum List<T> {
1718
Cons(T, @List<T>),
1819
Nil,
1920
}
2021

2122
#[deriving(Eq)]
23+
#[allow(missing_doc)]
2224
pub enum MutList<T> {
2325
MutCons(T, @mut MutList<T>),
2426
MutNil,

branches/auto/src/libextra/semver.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ use std::to_str::ToStr;
3838
/// An identifier in the pre-release or build metadata. If the identifier can
3939
/// be parsed as a decimal value, it will be represented with `Numeric`.
4040
#[deriving(Clone, Eq)]
41+
#[allow(missing_doc)]
4142
pub enum Identifier {
4243
Numeric(uint),
4344
AlphaNumeric(~str)

branches/auto/src/libextra/terminfo/parm.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ enum FormatState {
3939

4040
/// Types of parameters a capability can use
4141
#[deriving(Clone)]
42+
#[allow(missing_doc)]
4243
pub enum Param {
4344
String(~str),
4445
Number(int)

branches/auto/src/libextra/uuid.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ struct UuidFields {
116116
}
117117

118118
/// Error details for string parsing failures
119+
#[allow(missing_doc)]
119120
pub enum ParseError {
120121
ErrorInvalidLength(uint),
121122
ErrorInvalidCharacter(char, uint),

branches/auto/src/librustc/middle/lint.rs

Lines changed: 38 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1351,6 +1351,18 @@ impl MissingDocLintVisitor {
13511351
// otherwise, warn!
13521352
cx.span_lint(missing_doc, sp, msg);
13531353
}
1354+
1355+
fn check_struct(&mut self, cx: @mut Context, sdef: @ast::struct_def) {
1356+
for field in sdef.fields.iter() {
1357+
match field.node.kind {
1358+
ast::named_field(_, vis) if vis != ast::private => {
1359+
self.check_attrs(cx, field.node.attrs, field.span,
1360+
"missing documentation for a field");
1361+
}
1362+
ast::unnamed_field | ast::named_field(*) => {}
1363+
}
1364+
}
1365+
}
13541366
}
13551367

13561368
impl Visitor<@mut Context> for MissingDocLintVisitor {
@@ -1395,35 +1407,49 @@ impl SubitemStoppableVisitor for MissingDocLintVisitor {
13951407
}
13961408

13971409
fn visit_item_action(&mut self, it:@ast::item, cx:@mut Context) {
1410+
if it.vis != ast::public {
1411+
return;
1412+
}
13981413

13991414
match it.node {
14001415
// Go ahead and match the fields here instead of using
14011416
// visit_struct_field while we have access to the enclosing
14021417
// struct's visibility
1403-
ast::item_struct(sdef, _) if it.vis == ast::public => {
1418+
ast::item_struct(sdef, _) => {
14041419
self.check_attrs(cx, it.attrs, it.span,
14051420
"missing documentation for a struct");
1406-
for field in sdef.fields.iter() {
1407-
match field.node.kind {
1408-
ast::named_field(_, vis) if vis != ast::private => {
1409-
self.check_attrs(cx, field.node.attrs, field.span,
1410-
"missing documentation for a field");
1411-
}
1412-
ast::unnamed_field | ast::named_field(*) => {}
1413-
}
1414-
}
1421+
self.check_struct(cx, sdef);
14151422
}
14161423

1417-
ast::item_trait(*) if it.vis == ast::public => {
1424+
ast::item_trait(*) => {
14181425
self.check_attrs(cx, it.attrs, it.span,
14191426
"missing documentation for a trait");
14201427
}
14211428

1422-
ast::item_fn(*) if it.vis == ast::public => {
1429+
ast::item_fn(*) => {
14231430
self.check_attrs(cx, it.attrs, it.span,
14241431
"missing documentation for a function");
14251432
}
14261433

1434+
ast::item_enum(ref edef, _) => {
1435+
self.check_attrs(cx, it.attrs, it.span,
1436+
"missing documentation for an enum");
1437+
for variant in edef.variants.iter() {
1438+
if variant.node.vis == ast::private {
1439+
continue;
1440+
}
1441+
1442+
self.check_attrs(cx, variant.node.attrs, variant.span,
1443+
"missing documentation for a variant");
1444+
match variant.node.kind {
1445+
ast::struct_variant_kind(sdef) => {
1446+
self.check_struct(cx, sdef);
1447+
}
1448+
_ => ()
1449+
}
1450+
}
1451+
}
1452+
14271453
_ => {}
14281454
}
14291455
}

branches/auto/src/librustc/middle/trans/intrinsic.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ pub fn trans_intrinsic(ccx: @mut CrateContext,
6565
let val = Call(bcx, llfn, [a, b], []);
6666
let result = ExtractValue(bcx, val, 0);
6767
let overflow = ZExt(bcx, ExtractValue(bcx, val, 1), Type::bool());
68-
let ret = Load(bcx, Alloca(bcx, type_of::type_of(bcx.ccx(), t), ""));
68+
let ret = C_undef(type_of::type_of(bcx.ccx(), t));
6969
let ret = InsertValue(bcx, ret, result, 0);
7070
let ret = InsertValue(bcx, ret, overflow, 1);
7171

branches/auto/src/librustdoc/html/static/main.css

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -118,16 +118,9 @@ body {
118118
.content h1 { margin-top: 0; }
119119
.content h1, .content h2 { margin-left: -20px; }
120120
.content pre { padding: 20px; }
121-
.content.source pre.rust {
122-
white-space: pre;
123-
overflow: auto;
124-
padding-left: 0;
125-
}
121+
126122
.content pre.line-numbers { float: left; border: none; }
127123
.line-numbers span { color: #c67e2d; }
128-
.line-numbers .line-highlighted {
129-
background-color: #fff871;
130-
}
131124

132125
.content .highlighted {
133126
cursor: pointer;

branches/auto/src/librustdoc/html/static/main.js

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -31,25 +31,6 @@
3131
resizeShortBlocks();
3232
$(window).on('resize', resizeShortBlocks);
3333

34-
function highlightSourceLines() {
35-
var i, from, to, match = window.location.hash.match(/^#?(\d+)(?:-(\d+))?$/);
36-
if (match) {
37-
from = parseInt(match[1], 10);
38-
to = Math.min(50000, parseInt(match[2] || match[1], 10));
39-
from = Math.min(from, to);
40-
if ($('#' + from).length === 0) {
41-
return;
42-
}
43-
$('#' + from)[0].scrollIntoView();
44-
$('.line-numbers span').removeClass('line-highlighted');
45-
for (i = from; i <= to; i += 1) {
46-
$('#' + i).addClass('line-highlighted');
47-
}
48-
}
49-
}
50-
highlightSourceLines();
51-
$(window).on('hashchange', highlightSourceLines);
52-
5334
$(document).on('keyup', function (e) {
5435
if (document.activeElement.tagName === 'INPUT') {
5536
return;

branches/auto/src/libstd/fmt/parse.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,17 +61,20 @@ pub struct FormatSpec<'self> {
6161

6262
/// Enum describing where an argument for a format can be located.
6363
#[deriving(Eq)]
64+
#[allow(missing_doc)]
6465
pub enum Position<'self> {
6566
ArgumentNext, ArgumentIs(uint), ArgumentNamed(&'self str)
6667
}
6768

6869
/// Enum of alignments which are supported.
6970
#[deriving(Eq)]
71+
#[allow(missing_doc)]
7072
pub enum Alignment { AlignLeft, AlignRight, AlignUnknown }
7173

7274
/// Various flags which can be applied to format strings, the meaning of these
7375
/// flags is defined by the formatters themselves.
7476
#[deriving(Eq)]
77+
#[allow(missing_doc)]
7578
pub enum Flag {
7679
FlagSignPlus,
7780
FlagSignMinus,
@@ -82,6 +85,7 @@ pub enum Flag {
8285
/// A count is used for the precision and width parameters of an integer, and
8386
/// can reference either an argument or a literal integer.
8487
#[deriving(Eq)]
88+
#[allow(missing_doc)]
8589
pub enum Count {
8690
CountIs(uint),
8791
CountIsParam(uint),
@@ -126,6 +130,7 @@ pub struct PluralArm<'self> {
126130
///
127131
/// http://www.icu-project.org/apiref/icu4c/classicu_1_1PluralRules.html
128132
#[deriving(Eq, IterBytes)]
133+
#[allow(missing_doc)]
129134
pub enum PluralKeyword {
130135
Zero, One, Two, Few, Many
131136
}

branches/auto/src/libstd/local_data.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ use util;
5959
*/
6060
pub type Key<T> = &'static KeyValue<T>;
6161

62+
#[allow(missing_doc)]
6263
pub enum KeyValue<T> { Key }
6364

6465
trait LocalData {}

branches/auto/src/libstd/option.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ use clone::DeepClone;
5656

5757
/// The option type
5858
#[deriving(Clone, DeepClone, Eq)]
59+
#[allow(missing_doc)]
5960
pub enum Option<T> {
6061
None,
6162
Some(T),

branches/auto/src/libstd/send_str.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ use to_bytes::{IterBytes, Cb};
2222
/// A SendStr is a string that can hold either a ~str or a &'static str.
2323
/// This can be useful as an optimization when an allocation is sometimes
2424
/// needed but the common case is statically known.
25+
#[allow(missing_doc)]
2526
pub enum SendStr {
2627
SendStrOwned(~str),
2728
SendStrStatic(&'static str)

branches/auto/src/test/compile-fail/lint-missing-doc.rs

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,43 @@ mod a {
7777
}
7878
}
7979

80+
enum Baz {
81+
BazA {
82+
a: int,
83+
priv b: int
84+
},
85+
BarB
86+
}
87+
88+
pub enum PubBaz { //~ ERROR: missing documentation
89+
PubBazA { //~ ERROR: missing documentation
90+
a: int, //~ ERROR: missing documentation
91+
priv b: int
92+
},
93+
94+
priv PubBazB
95+
}
96+
97+
/// dox
98+
pub enum PubBaz2 {
99+
/// dox
100+
PubBaz2A {
101+
/// dox
102+
a: int,
103+
priv b: int
104+
},
105+
priv PubBaz2B
106+
}
107+
108+
#[allow(missing_doc)]
109+
pub enum PubBaz3 {
110+
PubBaz3A {
111+
a: int,
112+
priv b: int
113+
},
114+
priv PubBaz3B
115+
}
116+
80117
#[doc(hidden)]
81118
pub fn baz() {}
82119

0 commit comments

Comments
 (0)