Skip to content

Commit adca15a

Browse files
committed
Add a FIXME relating to using ast::Name
1 parent 7836c72 commit adca15a

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/librustc/middle/def.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ pub enum Def {
3636
// A partially resolved path to an associated type `T::U` where `T` is a concrete
3737
// type (indicated by the DefId) which implements a trait which has an associated
3838
// type `U` (indicated by the Ident).
39+
// FIXME(#20301) -- should use Name
3940
DefAssociatedPath(TyParamProvenance, ast::Ident),
4041
DefTrait(ast::DefId),
4142
DefPrimTy(ast::PrimTy),

src/librustc_typeck/astconv.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -992,7 +992,7 @@ fn qpath_to_ty<'tcx,AC,RS>(this: &AC,
992992

993993
return this.projected_ty(ast_ty.span,
994994
trait_ref,
995-
qpath.item_name.name); // TODO change qpath to use name
995+
qpath.item_name.name);
996996
}
997997

998998
// Parses the programmer's textual representation of a type into our
@@ -1155,7 +1155,6 @@ pub fn ast_ty_to_ty<'tcx, AC: AstConv<'tcx>, RS: RegionScope>(
11551155
this.tcx().types.err
11561156
}
11571157
def::DefAssociatedPath(provenance, assoc_ident) => {
1158-
// TODO update DefAssociatedPath to use name
11591158
associated_path_def_to_ty(this, ast_ty, provenance, assoc_ident.name)
11601159
}
11611160
_ => {

src/libsyntax/ast.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ pub enum Expr_ {
764764
pub struct QPath {
765765
pub self_type: P<Ty>,
766766
pub trait_ref: P<TraitRef>,
767-
pub item_name: Ident,
767+
pub item_name: Ident, // FIXME(#20301) -- should use Name
768768
}
769769

770770
#[deriving(Clone, PartialEq, Eq, RustcEncodable, RustcDecodable, Hash, Show, Copy)]

0 commit comments

Comments
 (0)