---

yaml
---
r: 149743
b: refs/heads/try2
c: 258dbd0
h: refs/heads/master
i:
  149741: b8606e7
  149739: 77150ab
  149735: c0da104
  149727: 8b8e7c1
v: v3

Author: Palmer Cox

[refs]

@@ -5,7 +5,7 @@ refs/heads/snap-stage3: 78a7676898d9f80ab540c6df5d4c9ce35bb50463
 refs/heads/try: 519addf6277dbafccbb4159db4b710c37eaa2ec5
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
-refs/heads/try2: e3723dc4f1f256e5a454cafb62fd892d85767750
+refs/heads/try2: 258dbd09ba4aa868b373df7e82721ba0c40167ba
 refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
 refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try2/src/librustc/middle/lint.rs

@@ -212,7 +212,7 @@ static lint_table: &'static [(&'static str, LintSpec)] = &[
     ("uppercase_variables",
      LintSpec {
          lint: UppercaseVariables,
-         desc: "variable names should start with a lowercase character",
+         desc: "variable and structure field names should start with a lowercase character",
          default: warn
      }),
 
@@ -1201,6 +1201,23 @@ fn check_pat_uppercase_variable(cx: &Context, p: &ast::Pat) {
     }
 }
 
+fn check_struct_uppercase_variable(cx: &Context, s: &ast::StructDef) {
+    for sf in s.fields.iter() {
+        match sf.node {
+            ast::StructField_ { kind: ast::NamedField(ident, _), .. } => {
+                let s = token::get_ident(ident);
+                if s.get().char_at(0).is_uppercase() {
+                    cx.span_lint(
+                        UppercaseVariables,
+                        sf.span,
+                        "structure field names should start with a lowercase character");
+                }
+            }
+            _ => {}
+        }
+    }
+}
+
 fn check_unnecessary_parens_core(cx: &Context, value: &ast::Expr, msg: &str) {
     match value.node {
         ast::ExprParen(_) => {
@@ -1665,6 +1682,8 @@ impl<'a> Visitor<()> for Context<'a> {
                         g: &ast::Generics,
                         id: ast::NodeId,
                         _: ()) {
+        check_struct_uppercase_variable(self, s);
+
         let old_id = self.cur_struct_def_id;
         self.cur_struct_def_id = id;
         visit::walk_struct_def(self, s, i, g, id, ());

branches/try2/src/test/compile-fail/lint-uppercase-variables.rs

@@ -13,6 +13,10 @@
 use std::io::File;
 use std::io::IoError;
 
+struct Something {
+    X: uint //~ ERROR structure field names should start with a lowercase character
+}
+
 fn test(Xx: uint) { //~ ERROR variable names should start with a lowercase character
     println!("{}", Xx);
 }
@@ -30,5 +34,7 @@ fn main() {
     }
 
     test(1);
+
+    let _ = Something { X: 0 };
 }