---

michaelwoerister · michaelwoerister · commit b00b39cea58d · 2013-06-20T11:50:09.000+02:00
yaml --- r: 63499 b: refs/heads/snap-stage3 c: 60474f3 h: refs/heads/master i: 63497: 4366899 63495: 7487a3c v: v3
diff --git a/[refs] b/[refs]
@@ -1,7 +1,7 @@
 ---
 refs/heads/master: 2d28d645422c1617be58c8ca7ad9a457264ca850
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
-refs/heads/snap-stage3: 38743f51ade64148be396438b1f6fe4639336ab3
+refs/heads/snap-stage3: 60474f395c1736773fdd1d86d053dc380b2dad8c
 refs/heads/try: 7b78b52e602bb3ea8174f9b2006bff3315f03ef9
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
diff --git a/branches/snap-stage3/src/librustc/middle/trans/debuginfo.rs b/branches/snap-stage3/src/librustc/middle/trans/debuginfo.rs
@@ -464,6 +464,9 @@ fn create_basic_type(cx: @mut CrateContext, t: ty::t, _span: span) -> DIType {
                 size * 8 as u64, align * 8 as u64, encoding as c_uint)
         }};
 
+    // One could think that this call is not necessary, as the create_ty() function will insert the
+    // type descriptor into the cache anyway. Mind, however, that create_basic_type() is also called
+    // directly from other functions (e.g. create_boxed_type()).
     dbg_cx(cx).created_types.insert(ty_id, ty_md);
     return ty_md;
 }

Original file line number	Diff line number	Diff line change
`@@ -464,6 +464,9 @@ fn create_basic_type(cx: @mut CrateContext, t: ty::t, _span: span) -> DIType {`
`464`	`464`	`size * 8 as u64, align * 8 as u64, encoding as c_uint)`
`465`	`465`	`}};`
`466`	`466`
	`467`	`+ // One could think that this call is not necessary, as the create_ty() function will insert the`
	`468`	`+ // type descriptor into the cache anyway. Mind, however, that create_basic_type() is also called`
	`469`	`+ // directly from other functions (e.g. create_boxed_type()).`
`467`	`470`	`dbg_cx(cx).created_types.insert(ty_id, ty_md);`
`468`	`471`	`return ty_md;`
`469`	`472`	`}`