---

yaml
---
r: 92671
b: refs/heads/auto
c: a07cee2
h: refs/heads/master
i:
  92669: 3c5d8b9
  92667: efa6bc1
  92663: 6b00b61
  92655: af2da82
  92639: 12f6412
  92607: d235bcf
  92543: e09d1ae
  92415: 2346b5d
  92159: 166798c
v: v3

Author: pcwalton

[refs]

@@ -13,7 +13,7 @@ refs/heads/try3: 9387340aab40a73e8424c48fd42f0c521a4875c0
 refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
 refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
 refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
-refs/heads/auto: 5b0401f0e8a60649c7e86cdb6ecdae0afc2f67ab
+refs/heads/auto: a07cee26a43024867d4b554b996bb5fc881dcb32
 refs/heads/servo: af82457af293e2a842ba6b7759b70288da276167
 refs/tags/release-0.6: b4ebcfa1812664df5e142f0134a5faea3918544c
 refs/tags/0.1: b19db808c2793fe2976759b85a355c3ad8c8b336

branches/auto/src/librustc/middle/trans/base.rs

@@ -1594,7 +1594,7 @@ pub fn alloca_maybe_zeroed(cx: @Block, ty: Type, name: &str, zero: bool) -> Valu
     let p = Alloca(cx, ty, name);
     if zero {
         let b = cx.fcx.ccx.builder();
-        b.position_before(cx.fcx.alloca_insert_pt.unwrap());
+        b.position_before(cx.fcx.alloca_insert_pt.get().unwrap());
         memzero(&b, p, ty);
     }
     p
@@ -1687,7 +1687,7 @@ pub fn new_fn_ctxt_w_id(ccx: @CrateContext,
           },
           llretptr: Cell::new(None),
           entry_bcx: None,
-          alloca_insert_pt: None,
+          alloca_insert_pt: Cell::new(None),
           llreturn: None,
           llself: None,
           personality: None,
@@ -1711,7 +1711,8 @@ pub fn new_fn_ctxt_w_id(ccx: @CrateContext,
         Load(entry_bcx, C_null(Type::i8p()));
 
         fcx.entry_bcx = Some(entry_bcx);
-        fcx.alloca_insert_pt = Some(llvm::LLVMGetFirstInstruction(entry_bcx.llbb));
+        fcx.alloca_insert_pt.set(Some(
+                llvm::LLVMGetFirstInstruction(entry_bcx.llbb)));
     }
 
     if !ty::type_is_voidish(ccx.tcx, substd_output_type) {

branches/auto/src/librustc/middle/trans/build.rs

@@ -314,7 +314,7 @@ pub fn Alloca(cx: &Block, Ty: Type, name: &str) -> ValueRef {
     unsafe {
         if cx.unreachable.get() { return llvm::LLVMGetUndef(Ty.ptr_to().to_ref()); }
         let b = cx.fcx.ccx.builder();
-        b.position_before(cx.fcx.alloca_insert_pt.unwrap());
+        b.position_before(cx.fcx.alloca_insert_pt.get().unwrap());
         b.alloca(Ty, name)
     }
 }
@@ -323,7 +323,7 @@ pub fn ArrayAlloca(cx: &Block, Ty: Type, Val: ValueRef) -> ValueRef {
     unsafe {
         if cx.unreachable.get() { return llvm::LLVMGetUndef(Ty.ptr_to().to_ref()); }
         let b = cx.fcx.ccx.builder();
-        b.position_before(cx.fcx.alloca_insert_pt.unwrap());
+        b.position_before(cx.fcx.alloca_insert_pt.get().unwrap());
         b.array_alloca(Ty, Val)
     }
 }

branches/auto/src/librustc/middle/trans/common.rs

@@ -221,7 +221,7 @@ pub struct FunctionContext {
     // the function, due to LLVM's quirks.
     // A marker for the place where we want to insert the function's static
     // allocas, so that LLVM will coalesce them into a single alloca call.
-    alloca_insert_pt: Option<ValueRef>,
+    alloca_insert_pt: Cell<Option<ValueRef>>,
     llreturn: Option<BasicBlockRef>,
     // The 'self' value currently in use in this function, if there
     // is one.
@@ -291,7 +291,9 @@ impl FunctionContext {
 
     pub fn cleanup(&mut self) {
         unsafe {
-            llvm::LLVMInstructionEraseFromParent(self.alloca_insert_pt.unwrap());
+            llvm::LLVMInstructionEraseFromParent(self.alloca_insert_pt
+                                                     .get()
+                                                     .unwrap());
         }
         // Remove the cycle between fcx and bcx, so memory can be freed
         self.entry_bcx = None;