---

yaml
---
r: 63086
b: refs/heads/snap-stage3
c: d83d38c
h: refs/heads/master
v: v3

Author: brson

[refs]

@@ -1,7 +1,7 @@
 ---
 refs/heads/master: 2d28d645422c1617be58c8ca7ad9a457264ca850
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
-refs/heads/snap-stage3: 18019a1304c5cf6ec6f04e43b030602c8fec0e01
+refs/heads/snap-stage3: d83d38c7fe3408848664de66a9a53587f627a01b
 refs/heads/try: 7b78b52e602bb3ea8174f9b2006bff3315f03ef9
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b

branches/snap-stage3/.gitattributes

@@ -7,4 +7,3 @@
 src/rt/msvc/* -whitespace
 src/rt/vg/* -whitespace
 src/rt/linenoise/* -whitespace
-src/rt/jemalloc/**/* -whitespace

branches/snap-stage3/.mailmap

@@ -1,42 +1,27 @@
 ## Pull request procedure
 
-Pull requests should be targeted at Rust's `incoming` branch (note
-that by default Github will aim them at the `master` branch) -- see
-"Changing The Commit Range and Destination Repository" in Github's
-documentation on [pull
-requests](https://help.github.com/articles/using-pull-requests).
-Before pushing to your Github repo and issuing the pull request,
-please do two things:
+Pull requests should be targeted at Rust's `incoming` branch (note that by default Github will aim them at the `master` branch) --
+see "Changing The Commit Range and Destination Repository" in Github's documentation on [pull requests](https://help.github.com/articles/using-pull-requests).
+Before pushing to your Github repo and issuing the pull request, please do two things:
 
-1. [Rebase](http://git-scm.com/book/en/Git-Branching-Rebasing) your
-   local changes against the `incoming` branch. Resolve any conflicts
-   that arise.
+1. [Rebase](http://git-scm.com/book/en/Git-Branching-Rebasing) your local changes against the `incoming` branch. Resolve any conflicts that arise.
+2. Run the full Rust test suite with the `make check` command.
+You're not off the hook even if you just stick to documentation; code examples in the docs are tested as well!
 
-2. Run the full Rust test suite with the `make check` command.  You're
-   not off the hook even if you just stick to documentation; code
-   examples in the docs are tested as well!
+Pull requests will be treated as "review requests",
+and we will give feedback we expect to see corrected on [style](https://github.com/mozilla/rust/wiki/Note-style-guide) and substance before pulling.
+Changes contributed via pull request should focus on a single issue at a time, like any other.
+We will not accept pull-requests that try to "sneak" unrelated changes in.
 
-Pull requests will be treated as "review requests", and we will give
-feedback we expect to see corrected on
-[style](https://github.com/mozilla/rust/wiki/Note-style-guide) and
-substance before pulling.  Changes contributed via pull request should
-focus on a single issue at a time, like any other.  We will not accept
-pull-requests that try to "sneak" unrelated changes in.
+Normally, all pull requests must include regression tests (see [Note-testsuite](https://github.com/mozilla/rust/wiki/Note-testsuite)) that test your change.
+Occasionally, a change will be very difficult to test for.
+In those cases, please include a note in your commit message explaining why.
 
-Normally, all pull requests must include regression tests (see
-[Note-testsuite](https://github.com/mozilla/rust/wiki/Note-testsuite))
-that test your change.  Occasionally, a change will be very difficult
-to test for.  In those cases, please include a note in your commit
-message explaining why.
-
-In the licensing header at the beginning of any files you change,
-please make sure the listed date range includes the current year.  For
-example, if it's 2013, and you change a Rust file that was created in
-2010, it should begin:
+In the licensing header at the beginning of any files you change, please make sure the listed date range includes the current year.
+For example, if it's 2013, and you change a Rust file that was created in 2010, it should begin:
 
 ```
 // Copyright 2010-2013 The Rust Project Developers.
 ```
 
-For more details, please refer to
-[Note-development-policy](https://github.com/mozilla/rust/wiki/Note-development-policy).
+For more details, please refer to [Note-development-policy](https://github.com/mozilla/rust/wiki/Note-development-policy).

branches/snap-stage3/CONTRIBUTING.md

@@ -146,7 +146,8 @@ ifneq ($(wildcard $(CFG_GIT)),)
 ifneq ($(wildcard $(CFG_GIT_DIR)),)
     CFG_VERSION += $(shell git --git-dir=$(CFG_GIT_DIR) log -1 \
                      --pretty=format:'(%h %ci)')
-    CFG_VER_HASH = $(shell git --git-dir=$(CFG_GIT_DIR) rev-parse HEAD)
+    CFG_VER_HASH = $(shell git --git-dir=$(CFG_GIT_DIR) log -1 \
+                     --pretty=format:'%H')
 endif
 endif
 

branches/snap-stage3/Makefile.in

@@ -561,7 +561,7 @@ then
                       | cut -d ' ' -f 2)
 
     case $CFG_CLANG_VERSION in
-        (3.0svn | 3.0 | 3.1* | 3.2* | 3.3* | 3.4* )
+        (3.0svn | 3.0 | 3.1* | 3.2* | 3.3*)
         step_msg "found ok version of CLANG: $CFG_CLANG_VERSION"
         CFG_C_COMPILER="clang"
         ;;
@@ -683,8 +683,7 @@ do
     for i in                                          \
       isaac linenoise sync test \
       arch/i386 arch/x86_64 arch/arm arch/mips  \
-      libuv libuv/src/ares libuv/src/eio libuv/src/ev \
-      jemalloc
+      libuv libuv/src/ares libuv/src/eio libuv/src/ev
     do
       make_dir rt/$t/stage$s/$i
     done
@@ -971,13 +970,6 @@ then
     putvar CFG_CCACHE_CPP2
 fi
 
-if [ ! -z "$CFG_ENABLE_CCACHE" ]
-then
-    CFG_CCACHE_BASEDIR=${CFG_SRC_DIR}
-    putvar CFG_CCACHE_BASEDIR
-fi
-
-
 if [ ! -z $BAD_PANDOC ]
 then
     CFG_PANDOC=

branches/snap-stage3/configure

@@ -301,10 +301,10 @@ num_lit : nonzero_dec [ dec_digit | '_' ] * num_suffix ?
 num_suffix : int_suffix | float_suffix ;
 
 int_suffix : 'u' int_suffix_size ?
-           | 'i' int_suffix_size ? ;
+           | 'i' int_suffix_size ;
 int_suffix_size : [ '8' | '1' '6' | '3' '2' | '6' '4' ] ;
 
-float_suffix : [ exponent | '.' dec_lit exponent ? ] ? float_suffix_ty ? ;
+float_suffix : [ exponent | '.' dec_lit exponent ? ] float_suffix_ty ? ;
 float_suffix_ty : 'f' [ '3' '2' | '6' '4' ] ;
 exponent : ['E' | 'e'] ['-' | '+' ] ? dec_lit ;
 dec_lit : [ dec_digit | '_' ] + ;
@@ -1297,7 +1297,7 @@ with matching types and type parameter counts.
 
 An implementation can take type parameters,
 which can be different from the type parameters taken by the trait it implements.
-Implementation parameters are written after the `impl` keyword.
+Implementation parameters are written after after the `impl` keyword.
 
 ~~~~
 # trait Seq<T> { }
@@ -1840,7 +1840,6 @@ is bounds-checked at run-time. When the check fails, it will put the
 task in a _failing state_.
 
 ~~~~
-# use std::task;
 # do task::spawn_unlinked {
 
 ([1, 2, 3, 4])[0];
@@ -2033,8 +2032,7 @@ as
 =
 ~~~~
 
-Operators at the same precedence level are evaluated left-to-right. [Unary operators](#unary-operator-expressions)
-have the same precedence level and it is stronger than any of the binary operators'.
+Operators at the same precedence level are evaluated left-to-right.
 
 ### Grouped expressions
 
@@ -2170,7 +2168,7 @@ fn ten_times(f: &fn(int)) {
     }
 }
 
-ten_times(|j| println(fmt!("hello, %d", j)));
+ten_times(|j| io::println(fmt!("hello, %d", j)));
 
 ~~~~
 
@@ -2191,7 +2189,7 @@ An example:
 let mut i = 0;
 
 while i < 10 {
-    println("hello\n");
+    io::println("hello\n");
     i = i + 1;
 }
 ~~~~
@@ -2325,9 +2323,7 @@ An example of a for loop over the contents of a vector:
 ~~~~
 # type foo = int;
 # fn bar(f: foo) { }
-# let a = 0;
-# let b = 0;
-# let c = 0;
+# let a = 0, b = 0, c = 0;
 
 let v: &[foo] = &[a, b, c];
 
@@ -2339,7 +2335,6 @@ for v.each |e| {
 An example of a for loop over a series of integers:
 
 ~~~~
-# use std::uint;
 # fn bar(b:uint) { }
 for uint::range(0, 256) |i| {
     bar(i);
@@ -2803,7 +2798,6 @@ the vtable pointer for the `T` implementation of `R`, and the pointer value of `
 An example of an object type:
 
 ~~~~~~~~
-# use std::int;
 trait Printable {
   fn to_str(&self) -> ~str;
 }
@@ -2813,7 +2807,7 @@ impl Printable for int {
 }
 
 fn print(a: @Printable) {
-   println(a.to_str());
+   io::println(a.to_str());
 }
 
 fn main() {
@@ -3002,7 +2996,7 @@ allocated within the stack's memory. The value is a part of the stack frame.
 
 Local variables are immutable unless declared with `let mut`.  The
 `mut` keyword applies to all local variables declared within that
-declaration (so `let mut (x, y) = ...` declares two mutable variables, `x` and
+declaration (so `let mut x, y` declares two mutable variables, `x` and
 `y`).
 
 Function parameters are immutable unless declared with `mut`. The

branches/snap-stage3/doc/rust.md

@@ -30,12 +30,6 @@ or the equivalent on Windows.
 
 Each workspace may contain one or more packages.
 
-When building code that contains one or more directives of the form `extern mod P`,
-rustpkg automatically searches for packages named `P` in the `RUST_PATH` (as described above).
-It builds those dependencies if necessary.
-Thus, when using rustpkg,
-there is no need for `-L` flags to tell the linker where to find libraries for external crates.
-
 # Package structure
 
 A valid workspace must contain each of the following subdirectories:
@@ -72,10 +66,6 @@ A package can be stored in a workspace on the local file system,
 or on a remote Web server, in which case the package ID resembles a URL.
 For example, `github.com/mozilla/rust` is a package ID
 that would refer to the git repository browsable at `http://github.com/mozilla/rust`.
-A package ID can also specify a version, like:
-`github.com/mozilla/rust#0.3`.
-In this case, `rustpkg` will check that the repository `github.com/mozilla/rust` has a tag named `0.3`,
-and report an error otherwise.
 
 ## Source files
 
@@ -86,15 +76,6 @@ rustpkg searches for four different fixed filenames in order to determine the cr
 * `test.rs`: Assumed to contain tests declared with the `#[test]` attribute.
 * `bench.rs`: Assumed to contain benchmarks declared with the `#[bench]` attribute.
 
-## Versions
-
-`rustpkg` packages do not need to declare their versions with an attribute inside one of the source files,
-because `rustpkg` infers it from the version control system.
-When building a package that is in a `git` repository,
-`rustpkg` assumes that the most recent tag specifies the current version.
-When building a package that is not under version control,
-or that has no tags, `rustpkg` assumes the intended version is 0.1.
-
 # Custom build scripts
 
 A file called `pkg.rs` at the root level in a workspace is called a *package script*.

branches/snap-stage3/doc/rustpkg.md

@@ -149,18 +149,17 @@ A type with the same functionality as owned boxes can be implemented by
 wrapping `malloc` and `free`:
 
 ~~~~
-use std::cast;
 use std::libc::{c_void, size_t, malloc, free};
-use std::ptr;
 use std::unstable::intrinsics;
+use std::util;
 
 // a wrapper around the handle returned by the foreign code
 pub struct Unique<T> {
     priv ptr: *mut T
 }
 
-impl<T: Owned> Unique<T> {
-    pub fn new(value: T) -> Unique<T> {
+pub impl<T: Owned> Unique<T> {
+    fn new(value: T) -> Unique<T> {
         unsafe {
             let ptr = malloc(std::sys::size_of::<T>() as size_t) as *mut T;
             assert!(!ptr::is_null(ptr));
@@ -171,12 +170,12 @@ impl<T: Owned> Unique<T> {
     }
 
     // the 'r lifetime results in the same semantics as `&*x` with ~T
-    pub fn borrow<'r>(&'r self) -> &'r T {
+    fn borrow<'r>(&'r self) -> &'r T {
         unsafe { cast::copy_lifetime(self, &*self.ptr) }
     }
 
     // the 'r lifetime results in the same semantics as `&mut *x` with ~T
-    pub fn borrow_mut<'r>(&'r mut self) -> &'r mut T {
+    fn borrow_mut<'r>(&'r mut self) -> &'r mut T {
         unsafe { cast::copy_mut_lifetime(self, &mut *self.ptr) }
     }
 }
@@ -185,9 +184,9 @@ impl<T: Owned> Unique<T> {
 impl<T: Owned> Drop for Unique<T> {
     fn finalize(&self) {
         unsafe {
-            let x = intrinsics::init(); // dummy value to swap in
+            let mut x = intrinsics::init(); // dummy value to swap in
             // moving the object out is needed to call the destructor
-            ptr::replace_ptr(self.ptr, x);
+            util::replace_ptr(self.ptr, x);
             free(self.ptr as *c_void)
         }
     }

branches/snap-stage3/doc/tutorial-ffi.md

@@ -13,8 +13,7 @@ doing nothing otherwise:
 ~~~~
 # enum t { special_a(uint), special_b(uint) };
 # fn f() -> uint {
-# let input_1 = special_a(0);
-# let input_2 = special_a(0);
+# let input_1 = special_a(0), input_2 = special_a(0);
 match input_1 {
     special_a(x) => { return x; }
     _ => {}
@@ -39,8 +38,7 @@ the pattern in the above code:
 ~~~~
 # enum t { special_a(uint), special_b(uint) };
 # fn f() -> uint {
-# let input_1 = special_a(0);
-# let input_2 = special_a(0);
+# let input_1 = special_a(0), input_2 = special_a(0);
 macro_rules! early_return(
     ($inp:expr $sp:ident) => ( // invoke it like `(input_5 special_e)`
         match $inp {
@@ -157,8 +155,7 @@ instead of `*` to mean "at least one".
 ~~~~
 # enum t { special_a(uint),special_b(uint),special_c(uint),special_d(uint)};
 # fn f() -> uint {
-# let input_1 = special_a(0);
-# let input_2 = special_a(0);
+# let input_1 = special_a(0), input_2 = special_a(0);
 macro_rules! early_return(
     ($inp:expr, [ $($sp:ident)|+ ]) => (
         match $inp {