Skip to content

Commit c0caa23

Browse files
committed
---
yaml --- r: 218783 b: refs/heads/snap-stage3 c: 3a433b9 h: refs/heads/master i: 218781: 89dfbf0 218779: 2ba4d4d 218775: 787777d 218767: ae9feb7 218751: 1485d75 v: v3
1 parent 0076326 commit c0caa23

File tree

33 files changed

+645
-92
lines changed

33 files changed

+645
-92
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
refs/heads/master: c044791d80ea0dc5c4b57b6030a67b69f8510239
3-
refs/heads/snap-stage3: d061a0f8d51ca2e4d21409e4083bedd430998d88
3+
refs/heads/snap-stage3: 3a433b968b4aa3e0894c7eff897e98b570141db9
44
refs/heads/try: b53c0f93eedcdedd4fd89bccc5a3a09d1c5cd23e
55
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
66
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596

branches/snap-stage3/CONTRIBUTING.md

Lines changed: 39 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,8 @@ feature. We use the 'fork and pull' model described there.
8484
Please make pull requests against the `master` branch.
8585

8686
All pull requests are reviewed by another person. We have a bot,
87-
@rust-highfive, that will automatically assign a random person to review your request.
87+
@rust-highfive, that will automatically assign a random person to review your
88+
request.
8889

8990
If you want to request that a specific person reviews your pull request,
9091
you can add an `r?` to the message. For example, Steve usually reviews
@@ -124,6 +125,10 @@ To save @bors some work, and to get small changes through more quickly, when
124125
the other rollup-eligible patches too, and they'll get tested and merged at
125126
the same time.
126127

128+
To find documentation-related issues, sort by the [A-docs label][adocs].
129+
130+
[adocs]: https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AA-docs
131+
127132
## Issue Triage
128133

129134
Sometimes, an issue will stay open, even though the bug has been fixed. And
@@ -132,8 +137,40 @@ meantime.
132137

133138
It can be helpful to go through older bug reports and make sure that they are
134139
still valid. Load up an older issue, double check that it's still true, and
135-
leave a comment letting us know if it is or is not. The [least recently updated sort][lru] is good for finding issues like this.
140+
leave a comment letting us know if it is or is not. The [least recently
141+
updated sort][lru] is good for finding issues like this.
142+
143+
Contributors with sufficient permissions on the Rust repo can help by adding
144+
labels to triage issues:
145+
146+
* Yellow, **A**-prefixed labels state which **area** of the project an issue
147+
relates to.
148+
149+
* Magenta, **B**-prefixed labels identify bugs which **belong** elsewhere.
150+
151+
* Green, **E**-prefixed labels explain the level of **experience** necessary
152+
to fix the issue.
153+
154+
* Red, **I**-prefixed labels indicate the **importance** of the issue. The
155+
[I-nominated][inom] label indicates that an issue has been nominated for
156+
prioritizing at the next triage meeting.
157+
158+
* Orange, **P**-prefixed labels indicate a bug's **priority**. These labels
159+
are only assigned during triage meetings, and replace the [I-nominated][inom]
160+
label.
161+
162+
* Blue, **T**-prefixed bugs denote which **team** the issue belongs to.
163+
164+
* Dark blue, **beta-** labels track changes which need to be backported into
165+
the beta branches.
166+
167+
* The purple **metabug** label marks lists of bugs collected by other
168+
categories.
169+
170+
If you're looking for somewhere to start, check out the [E-easy][eeasy] tag.
136171

172+
[inom]: https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AI-nominated
173+
[eeasy]: https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AE-easy
137174
[lru]: https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-asc
138175

139176
## Out-of-tree Contributions

branches/snap-stage3/src/doc/complement-design-faq.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ that all delimiters be balanced.
160160
## `->` for function return type
161161

162162
This is to make the language easier to parse for humans, especially in the face
163-
of higher-order functions. `fn foo<T>(f: fn(int): int, fn(T): U): U` is not
163+
of higher-order functions. `fn foo<T>(f: fn(i32): i32, fn(T): U): U` is not
164164
particularly easy to read.
165165

166166
## Why is `let` used to introduce variables?

branches/snap-stage3/src/doc/style/errors/ergonomics.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ use std::io::{File, Open, Write, IoError};
1414

1515
struct Info {
1616
name: String,
17-
age: int,
18-
rating: int
17+
age: i32,
18+
rating: i32
1919
}
2020

2121
fn write_info(info: &Info) -> Result<(), IoError> {
@@ -36,8 +36,8 @@ use std::io::{File, Open, Write, IoError};
3636

3737
struct Info {
3838
name: String,
39-
age: int,
40-
rating: int
39+
age: i32,
40+
rating: i32
4141
}
4242

4343
fn write_info(info: &Info) -> Result<(), IoError> {
@@ -63,4 +63,4 @@ for more details.
6363
### The `Result`-`impl` pattern [FIXME]
6464

6565
> **[FIXME]** Document the way that the `io` module uses trait impls
66-
> on `IoResult` to painlessly propagate errors.
66+
> on `std::io::Result` to painlessly propagate errors.

branches/snap-stage3/src/doc/style/features/functions-and-methods/input.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,15 @@ it becomes.
5757
Prefer
5858

5959
```rust
60-
fn foo<T: Iterator<int>>(c: T) { ... }
60+
fn foo<T: Iterator<i32>>(c: T) { ... }
6161
```
6262

6363
over any of
6464

6565
```rust
66-
fn foo(c: &[int]) { ... }
67-
fn foo(c: &Vec<int>) { ... }
68-
fn foo(c: &SomeOtherCollection<int>) { ... }
66+
fn foo(c: &[i32]) { ... }
67+
fn foo(c: &Vec<i32>) { ... }
68+
fn foo(c: &SomeOtherCollection<i32>) { ... }
6969
```
7070

7171
if the function only needs to iterate over the data.
@@ -121,7 +121,7 @@ The primary exception: sometimes a function is meant to modify data
121121
that the caller already owns, for example to re-use a buffer:
122122

123123
```rust
124-
fn read(&mut self, buf: &mut [u8]) -> IoResult<uint>
124+
fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize>
125125
```
126126

127127
(From the [Reader trait](http://static.rust-lang.org/doc/master/std/io/trait.Reader.html#tymethod.read).)

branches/snap-stage3/src/doc/style/features/functions-and-methods/output.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ Prefer
1919
```rust
2020
struct SearchResult {
2121
found: bool, // item in container?
22-
expected_index: uint // what would the item's index be?
22+
expected_index: usize // what would the item's index be?
2323
}
2424

2525
fn binary_search(&self, k: Key) -> SearchResult
2626
```
2727
or
2828

2929
```rust
30-
fn binary_search(&self, k: Key) -> (bool, uint)
30+
fn binary_search(&self, k: Key) -> (bool, usize)
3131
```
3232

3333
over

branches/snap-stage3/src/doc/style/features/let.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
Prefer
66

77
```rust
8-
fn use_mutex(m: sync::mutex::Mutex<int>) {
8+
fn use_mutex(m: sync::mutex::Mutex<i32>) {
99
let guard = m.lock();
1010
do_work(guard);
1111
drop(guard); // unlock the lock
@@ -16,7 +16,7 @@ fn use_mutex(m: sync::mutex::Mutex<int>) {
1616
over
1717

1818
```rust
19-
fn use_mutex(m: sync::mutex::Mutex<int>) {
19+
fn use_mutex(m: sync::mutex::Mutex<i32>) {
2020
do_work(m.lock());
2121
// do other work
2222
}

branches/snap-stage3/src/doc/style/features/traits/reuse.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ trait Printable {
1515
fn print(&self) { println!("{:?}", *self) }
1616
}
1717

18-
impl Printable for int {}
18+
impl Printable for i32 {}
1919

2020
impl Printable for String {
2121
fn print(&self) { println!("{}", *self) }

branches/snap-stage3/src/doc/style/features/types/newtype.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ promises to the client.
4343

4444
For example, consider a function `my_transform` that returns a compound iterator
4545
type `Enumerate<Skip<vec::MoveItems<T>>>`. We wish to hide this type from the
46-
client, so that the client's view of the return type is roughly `Iterator<(uint,
46+
client, so that the client's view of the return type is roughly `Iterator<(usize,
4747
T)>`. We can do so using the newtype pattern:
4848

4949
```rust
5050
struct MyTransformResult<T>(Enumerate<Skip<vec::MoveItems<T>>>);
51-
impl<T> Iterator<(uint, T)> for MyTransformResult<T> { ... }
51+
impl<T> Iterator<(usize, T)> for MyTransformResult<T> { ... }
5252

5353
fn my_transform<T, Iter: Iterator<T>>(iter: Iter) -> MyTransformResult<T> {
5454
...

branches/snap-stage3/src/doc/style/ownership/builders.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ impl Command {
7575
}
7676

7777
/// Executes the command as a child process, which is returned.
78-
pub fn spawn(&self) -> IoResult<Process> {
78+
pub fn spawn(&self) -> std::io::Result<Process> {
7979
...
8080
}
8181
}

branches/snap-stage3/src/doc/style/style/features.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Terminate `return` statements with semicolons:
44

55
``` rust
6-
fn foo(bar: int) -> Option<int> {
6+
fn foo(bar: i32) -> Option<i32> {
77
if some_condition() {
88
return None;
99
}

branches/snap-stage3/src/doc/style/style/imports.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ For example:
4444
use option::Option;
4545
use mem;
4646

47-
let i: int = mem::transmute(Option(0));
47+
let i: isize = mem::transmute(Option(0));
4848
```
4949

5050
> **[FIXME]** Add rationale.

branches/snap-stage3/src/doc/style/style/whitespace.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
``` rust
1212
#[deprecated = "Use `bar` instead."]
13-
fn foo(a: uint, b: uint) -> uint {
13+
fn foo(a: usize, b: usize) -> usize {
1414
a + b
1515
}
1616
```

branches/snap-stage3/src/doc/trpl/associated-types.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ trait Graph {
4343
Now, our clients can be abstract over a given `Graph`:
4444

4545
```rust,ignore
46-
fn distance<G: Graph>(graph: &G, start: &G::N, end: &G::N) -> uint { ... }
46+
fn distance<G: Graph>(graph: &G, start: &G::N, end: &G::N) -> usize { ... }
4747
```
4848

4949
No need to deal with the `E`dge type here!

branches/snap-stage3/src/doc/trpl/box-syntax-and-patterns.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ fn main() {
5858
```
5959

6060
The idea is that by passing around a box, you're only copying a pointer, rather
61-
than the hundred `int`s that make up the `BigStruct`.
61+
than the hundred `i32`s that make up the `BigStruct`.
6262

6363
This is an antipattern in Rust. Instead, write this:
6464

branches/snap-stage3/src/doc/trpl/lifetimes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ x: &'a i32,
134134
# }
135135
```
136136

137-
uses it. So why do we need a lifetime here? We need to ensure that any reference
138-
to a `Foo` cannot outlive the reference to an `i32` it contains.
137+
uses it. So why do we need a lifetime here? We need to ensure that any
138+
reference to the contained `i32` does not outlive the containing `Foo`.
139139

140140
## Thinking in scopes
141141

branches/snap-stage3/src/doc/trpl/references-and-borrowing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ fn main() {
206206
^
207207
```
208208

209-
In other words, the mutable borow is held through the rest of our example. What
209+
In other words, the mutable borrow is held through the rest of our example. What
210210
we want is for the mutable borrow to end _before_ we try to call `println!` and
211211
make an immutable borrow. In Rust, borrowing is tied to the scope that the
212212
borrow is valid for. And our scopes look like this:

branches/snap-stage3/src/doc/trpl/traits.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ print_area(5);
146146
We get a compile-time error:
147147

148148
```text
149-
error: failed to find an implementation of trait main::HasArea for int
149+
error: the trait `HasArea` is not implemented for the type `_` [E0277]
150150
```
151151

152152
So far, we’ve only added trait implementations to structs, but you can

0 commit comments

Comments
 (0)