---

yaml
---
r: 117783
b: refs/heads/auto
c: 24b1b79
h: refs/heads/master
i:
  117781: a8e47d1
  117779: 9aeccb2
  117775: d6d81df
v: v3

Author: Cameron Zwarich

[refs]

@@ -13,7 +13,7 @@ refs/heads/try3: 9387340aab40a73e8424c48fd42f0c521a4875c0
 refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
 refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
 refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
-refs/heads/auto: 45a1b977643456ceacfc81183e2d5743f7c61ce9
+refs/heads/auto: 24b1b79cf1d2a27c3f8d1c518fcfa7a1ec832154
 refs/heads/servo: af82457af293e2a842ba6b7759b70288da276167
 refs/tags/release-0.6: b4ebcfa1812664df5e142f0134a5faea3918544c
 refs/tags/0.1: b19db808c2793fe2976759b85a355c3ad8c8b336

branches/auto/src/librustc/middle/borrowck/check_loans.rs

@@ -476,7 +476,10 @@ impl<'a> CheckLoanCtxt<'a> {
                                        span: Span,
                                        move_path: &LoanPath,
                                        move_kind: move_data::MoveKind) {
-        match self.analyze_move_out_from(id, move_path) {
+        // We want to detect if there are any loans at all, so we search for
+        // any loans incompatible with MutBorrrow, since all other kinds of
+        // loans are incompatible with that.
+        match self.analyze_move_out_from(id, move_path, ty::MutBorrow) {
             MoveOk => { }
             MoveWhileBorrowed(loan_path, loan_span) => {
                 let err_message = match move_kind {
@@ -865,7 +868,8 @@ impl<'a> CheckLoanCtxt<'a> {
 
     pub fn analyze_move_out_from(&self,
                                  expr_id: ast::NodeId,
-                                 move_path: &LoanPath)
+                                 move_path: &LoanPath,
+                                 borrow_kind: ty::BorrowKind)
                                  -> MoveError {
         debug!("analyze_move_out_from(expr_id={:?}, move_path={})",
                self.tcx().map.node_to_str(expr_id),
@@ -881,9 +885,12 @@ impl<'a> CheckLoanCtxt<'a> {
         //     let y = a;          // Conflicts with restriction
 
         self.each_in_scope_restriction(expr_id, move_path, |loan, _restr| {
-            // Any restriction prevents moves.
-            ret = MoveWhileBorrowed(loan.loan_path.clone(), loan.span);
-            false
+            if incompatible(loan.kind, borrow_kind) {
+                ret = MoveWhileBorrowed(loan.loan_path.clone(), loan.span);
+                false
+            } else {
+                true
+            }
         });
 
         // Next, we must check for *loans* (not restrictions) on the path P or
@@ -901,8 +908,8 @@ impl<'a> CheckLoanCtxt<'a> {
         let mut loan_path = move_path;
         loop {
             self.each_in_scope_loan(expr_id, |loan| {
-                // Any restriction prevents moves.
-                if *loan.loan_path == *loan_path {
+                if *loan.loan_path == *loan_path &&
+                   incompatible(loan.kind, borrow_kind) {
                     ret = MoveWhileBorrowed(loan.loan_path.clone(), loan.span);
                     false
                 } else {
@@ -921,5 +928,11 @@ impl<'a> CheckLoanCtxt<'a> {
         }
 
         return ret;
+
+        fn incompatible(borrow_kind1: ty::BorrowKind,
+                        borrow_kind2: ty::BorrowKind)
+                        -> bool {
+            borrow_kind1 != ty::ImmBorrow || borrow_kind2 != ty::ImmBorrow
+        }
     }
 }