Skip to content

Commit c87060a

Browse files
Delete read_enum_variant names
1 parent c6bd6b4 commit c87060a

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

compiler/rustc_macros/src/serialize.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,6 @@ fn decodable_body(
6060
quote! { #idx => { #construct } }
6161
})
6262
.collect();
63-
let names: TokenStream = variants
64-
.iter()
65-
.map(|vi| {
66-
let variant_name = vi.ast().ident.to_string();
67-
quote!(#variant_name,)
68-
})
69-
.collect();
7063
let message = format!(
7164
"invalid enum variant tag while decoding `{}`, expected 0..{}",
7265
ty_name,
@@ -75,7 +68,6 @@ fn decodable_body(
7568
quote! {
7669
::rustc_serialize::Decoder::read_enum_variant(
7770
__decoder,
78-
&[#names],
7971
|__decoder, __variant_idx| {
8072
match __variant_idx {
8173
#match_inner

compiler/rustc_serialize/src/serialize.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ pub trait Decoder {
202202
fn read_raw_bytes_into(&mut self, s: &mut [u8]);
203203

204204
#[inline]
205-
fn read_enum_variant<T, F>(&mut self, _names: &[&str], mut f: F) -> T
205+
fn read_enum_variant<T, F>(&mut self, mut f: F) -> T
206206
where
207207
F: FnMut(&mut Self, usize) -> T,
208208
{
@@ -255,7 +255,7 @@ pub trait Decoder {
255255
where
256256
F: FnMut(&mut Self, bool) -> T,
257257
{
258-
self.read_enum_variant(&["None", "Some"], move |this, idx| match idx {
258+
self.read_enum_variant(move |this, idx| match idx {
259259
0 => f(this, false),
260260
1 => f(this, true),
261261
_ => panic!("read_option: expected 0 for None or 1 for Some"),
@@ -571,7 +571,7 @@ impl<S: Encoder, T1: Encodable<S>, T2: Encodable<S>> Encodable<S> for Result<T1,
571571

572572
impl<D: Decoder, T1: Decodable<D>, T2: Decodable<D>> Decodable<D> for Result<T1, T2> {
573573
fn decode(d: &mut D) -> Result<T1, T2> {
574-
d.read_enum_variant(&["Ok", "Err"], |d, disr| match disr {
574+
d.read_enum_variant(|d, disr| match disr {
575575
0 => Ok(d.read_enum_variant_arg(|d| T1::decode(d))),
576576
1 => Err(d.read_enum_variant_arg(|d| T2::decode(d))),
577577
_ => panic!("Encountered invalid discriminant while decoding `Result`."),

0 commit comments

Comments
 (0)