Skip to content

Commit ca3a9f8

Browse files
committed
Annotate more FIXMES in libstd (comments only)
1 parent f029e1f commit ca3a9f8

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/libstd/deque.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ iface t<T> {
1414
}
1515

1616
// FIXME eventually, a proper datatype plus an exported impl would be
17-
// preferrable
17+
// preferrable (#2343)
1818
fn create<T: copy>() -> t<T> {
1919
type cell<T> = option<T>;
2020

src/libstd/map.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ iface map<K: copy, V: copy> {
6666
}
6767

6868
// FIXME: package this up and export it as a datatype usable for
69-
// external code that doesn't want to pay the cost of a box.
69+
// external code that doesn't want to pay the cost of a box. (#2344)
7070
mod chained {
7171
type entry<K, V> = {
7272
hash: uint,

src/libstd/sha1.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ fn sha1() -> sha1 {
6161
work_buf: [mut u32]};
6262

6363
fn add_input(st: sha1state, msg: [u8]) {
64-
// FIXME: Should be typestate precondition
64+
/* FIXME: Should be typestate precondition (#2345) */
6565
assert (!st.computed);
6666
for vec::each(msg) {|element|
6767
st.msg_block[st.msg_block_idx] = element;
@@ -70,7 +70,7 @@ fn sha1() -> sha1 {
7070
if st.len_low == 0u32 {
7171
st.len_high += 1u32;
7272
if st.len_high == 0u32 {
73-
// FIXME: Need better failure mode
73+
// FIXME: Need better failure mode (#2346)
7474

7575
fail;
7676
}
@@ -79,7 +79,7 @@ fn sha1() -> sha1 {
7979
}
8080
}
8181
fn process_msg_block(st: sha1state) {
82-
// FIXME: Make precondition
82+
// FIXME: Make precondition (#2345)
8383
assert (vec::len(st.h) == digest_buf_len);
8484
assert (vec::len(st.work_buf) == work_buf_len);
8585
let mut t: int; // Loop counter
@@ -181,7 +181,7 @@ fn sha1() -> sha1 {
181181
* can be assumed that the message digest has been computed.
182182
*/
183183
fn pad_msg(st: sha1state) {
184-
// FIXME: Should be a precondition
184+
// FIXME: Should be a precondition (#2345)
185185
assert (vec::len(st.msg_block) == msg_block_len);
186186

187187
/*
@@ -220,7 +220,7 @@ fn sha1() -> sha1 {
220220

221221
impl of sha1 for sha1state {
222222
fn reset() {
223-
// FIXME: Should be typestate precondition
223+
// FIXME: Should be typestate precondition (#2345)
224224
assert (vec::len(self.h) == digest_buf_len);
225225
self.len_low = 0u32;
226226
self.len_high = 0u32;

0 commit comments

Comments
 (0)