---

yaml
---
r: 95999
b: refs/heads/dist-snap
c: d08aadc
h: refs/heads/master
i:
  95997: e7eb614
  95995: 140f697
  95991: 795bf10
  95983: 7c7e885
  95967: 98458e4
  95935: e99de74
  95871: d32252f
  95743: 81399c7
v: v3

Author: alexcrichton

[refs]

@@ -6,7 +6,7 @@ refs/heads/try: c274a6888410ce3e357e014568b43310ed787d36
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
 refs/heads/try2: 147ecfdd8221e4a4d4e090486829a06da1e0ca3c
-refs/heads/dist-snap: 0df8b0057c8beaf108dfb34e53829b74fd2a7abc
+refs/heads/dist-snap: d08aadcc9aff233165a063df73c6436e0969f79c
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
 refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503
 refs/heads/try3: 9387340aab40a73e8424c48fd42f0c521a4875c0

branches/dist-snap/src/librustuv/addrinfo.rs

@@ -189,28 +189,27 @@ pub fn accum_addrinfo(addr: &Addrinfo) -> ~[ai::Info] {
 
 #[cfg(test)]
 mod test {
-    use Loop;
     use std::rt::io::net::ip::{SocketAddr, Ipv4Addr};
     use super::*;
+    use super::super::run_uv_loop;
 
     #[test]
     fn getaddrinfo_test() {
-        let mut loop_ = Loop::new();
-        let mut req = GetAddrInfoRequest::new();
-        do req.getaddrinfo(&loop_, Some("localhost"), None, None) |_, addrinfo, _| {
-            let sockaddrs = accum_addrinfo(addrinfo);
-            let mut found_local = false;
-            let local_addr = &SocketAddr {
-                ip: Ipv4Addr(127, 0, 0, 1),
-                port: 0
-            };
-            for addr in sockaddrs.iter() {
-                found_local = found_local || addr.address == *local_addr;
+        do run_uv_loop |l| {
+            match GetAddrInfoRequest::run(l, Some("localhost"), None, None) {
+                Ok(infos) => {
+                    let mut found_local = false;
+                    let local_addr = &SocketAddr {
+                        ip: Ipv4Addr(127, 0, 0, 1),
+                        port: 0
+                    };
+                    for addr in infos.iter() {
+                        found_local = found_local || addr.address == *local_addr;
+                    }
+                    assert!(found_local);
+                }
+                Err(e) => fail!("{:?}", e),
             }
-            assert!(found_local);
         }
-        loop_.run();
-        loop_.close();
-        req.delete();
     }
 }

branches/dist-snap/src/librustuv/async.rs

@@ -126,62 +126,56 @@ impl Drop for AsyncWatcher {
 #[cfg(test)]
 mod test_remote {
     use std::cell::Cell;
-    use std::rt::test::*;
+    use std::rt::rtio::Callback;
     use std::rt::thread::Thread;
     use std::rt::tube::Tube;
-    use std::rt::rtio::EventLoop;
-    use std::rt::local::Local;
-    use std::rt::sched::Scheduler;
 
+    use super::*;
+    use super::super::run_uv_loop;
+
+    // Make sure that we can fire watchers in remote threads
     #[test]
     fn test_uv_remote() {
-        do run_in_mt_newsched_task {
-            let mut tube = Tube::new();
-            let tube_clone = tube.clone();
-            let remote_cell = Cell::new_empty();
-            do Local::borrow |sched: &mut Scheduler| {
-                let tube_clone = tube_clone.clone();
-                let tube_clone_cell = Cell::new(tube_clone);
-                let remote = do sched.event_loop.remote_callback {
-                    // This could be called multiple times
-                    if !tube_clone_cell.is_empty() {
-                        tube_clone_cell.take().send(1);
-                    }
-                };
-                remote_cell.put_back(remote);
+        struct MyCallback(Option<Tube<int>>);
+        impl Callback for MyCallback {
+            fn call(&mut self) {
+                // this can get called more than once, but we only want to send
+                // once
+                if self.is_some() {
+                    self.take_unwrap().send(1);
+                }
             }
+        }
+
+        do run_uv_loop |l| {
+            let mut tube = Tube::new();
+            let cb = ~MyCallback(Some(tube.clone()));
+            let watcher = Cell::new(AsyncWatcher::new(l, cb as ~Callback));
+
             let thread = do Thread::start {
-                remote_cell.take().fire();
+                watcher.take().fire();
             };
 
-            assert!(tube.recv() == 1);
+            assert_eq!(tube.recv(), 1);
             thread.join();
         }
     }
-}
-
-#[cfg(test)]
-mod test {
-
-    use super::*;
-    use Loop;
-    use std::unstable::run_in_bare_thread;
-    use std::rt::thread::Thread;
-    use std::cell::Cell;
 
     #[test]
     fn smoke_test() {
-        do run_in_bare_thread {
-            let mut loop_ = Loop::new();
-            let watcher = AsyncWatcher::new(&mut loop_, |w, _| w.close(||()) );
-            let watcher_cell = Cell::new(watcher);
-            let thread = do Thread::start {
-                let mut watcher = watcher_cell.take();
-                watcher.send();
-            };
-            loop_.run();
-            loop_.close();
-            thread.join();
+        static mut hits: uint = 0;
+
+        struct MyCallback;
+        impl Callback for MyCallback {
+            fn call(&mut self) {
+                unsafe { hits += 1; }
+            }
+        }
+
+        do run_uv_loop |l| {
+            let mut watcher = AsyncWatcher::new(l, ~MyCallback as ~Callback);
+            watcher.fire();
         }
+        assert!(unsafe { hits > 0 });
     }
 }