---

yaml
---
r: 36822
b: refs/heads/try2
c: 63232d6
h: refs/heads/master
v: v3

Author: Isaac Aggrey

[refs]

@@ -5,7 +5,7 @@ refs/heads/snap-stage3: eb8fd119c65c67f3b1b8268cc7341c22d39b7b61
 refs/heads/try: d324a424d8f84b1eb049b12cf34182bda91b0024
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
-refs/heads/try2: 2ad41b881cb8389cb690c643e41c27f6c34270d5
+refs/heads/try2: 63232d6cf16ea2c4503b580c23a9fe8e31671a0d
 refs/heads/incoming: d9317a174e434d4c99fc1a37fd7dc0d2f5328d37
 refs/heads/dist-snap: 22efa39382d41b084fde1719df7ae8ce5697d8c9
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596

branches/try2/doc/tutorial.md

@@ -1924,7 +1924,7 @@ types by the compiler, and may not be overridden:
 
 Additionally, the `Drop` trait is used to define destructors. This
 trait defines one method called `finalize`, which is automatically
-called when value of the a type that implements this trait is
+called when a value of the type that implements this trait is
 destroyed, either because the value went out of scope or because the
 garbage collector reclaimed it.
 

branches/try2/src/libcore/dvec.rs

@@ -110,9 +110,6 @@ priv impl<A> DVec<A> {
             self.data = move data;
         }
     }
-
-    #[inline(always)]
-    fn unwrap(self) -> ~[A] { unwrap(self) }
 }
 
 // In theory, most everything should work with any A, but in practice

branches/try2/src/libcore/either.rs

@@ -142,14 +142,6 @@ pub pure fn unwrap_right<T,U>(eith: Either<T,U>) -> U {
     }
 }
 
-impl<T, U> Either<T, U> {
-    #[inline(always)]
-    fn unwrap_left(self) -> T { unwrap_left(self) }
-
-    #[inline(always)]
-    fn unwrap_right(self) -> U { unwrap_right(self) }
-}
-
 #[test]
 fn test_either_left() {
     let val = Left(10);

branches/try2/src/libcore/mutable.rs

@@ -73,9 +73,6 @@ impl<T> Data<T> {
             op(unsafe{transmute_immut(&mut self.value)})
         }
     }
-
-    #[inline(always)]
-    fn unwrap(self) -> T { unwrap(self) }
 }
 
 #[test]

branches/try2/src/libcore/option.rs

@@ -96,6 +96,19 @@ pub pure fn get_ref<T>(opt: &r/Option<T>) -> &r/T {
     }
 }
 
+pub pure fn expect<T>(opt: Option<T>, reason: ~str) -> T {
+    /*!
+     * Gets the value out of an option without copying, printing a
+     * specified message on failure.
+     *
+     * # Failure
+     *
+     * Fails if the value equals `none`
+     */
+    if opt.is_some() { move option::unwrap(move opt) }
+    else { fail reason }
+}
+
 pub pure fn map<T, U>(opt: &Option<T>, f: fn(x: &T) -> U) -> Option<U> {
     //! Maps a `some` value by reference from one type to another
 
@@ -222,46 +235,35 @@ pub fn swap_unwrap<T>(opt: &mut Option<T>) -> T {
     unwrap(util::replace(opt, None))
 }
 
-pub pure fn expect<T>(opt: Option<T>, reason: &str) -> T {
+pub pure fn unwrap_expect<T>(opt: Option<T>, reason: &str) -> T {
     //! As unwrap, but with a specified failure message.
-    match move opt {
-        Some(move val) => val,
-        None => fail reason.to_owned(),
-    }
+    if opt.is_none() { fail reason.to_owned(); }
+    unwrap(move opt)
 }
 
+// Some of these should change to be &Option<T>, some should not. See below.
 impl<T> Option<T> {
     /// Returns true if the option equals `none`
-    #[inline(always)]
-    pure fn is_none(&self) -> bool { is_none(self) }
-
+    pure fn is_none() -> bool { is_none(&self) }
     /// Returns true if the option contains some value
-    #[inline(always)]
-    pure fn is_some(&self) -> bool { is_some(self) }
+    pure fn is_some() -> bool { is_some(&self) }
+}
 
+impl<T> &Option<T> {
     /**
      * Update an optional value by optionally running its content by reference
      * through a function that returns an option.
      */
-    #[inline(always)]
-    pure fn chain_ref<U>(&self, f: fn(x: &T) -> Option<U>) -> Option<U> {
+    pure fn chain_ref<U>(f: fn(x: &T) -> Option<U>) -> Option<U> {
         chain_ref(self, f)
     }
-
-    /// Maps a `some` value from one type to another by reference
-    #[inline(always)]
-    pure fn map<U>(&self, f: fn(x: &T) -> U) -> Option<U> { map(self, f) }
-
     /// Applies a function to the contained value or returns a default
-    #[inline(always)]
-    pure fn map_default<U>(&self, def: U, f: fn(x: &T) -> U) -> U {
-        map_default(self, move def, f)
-    }
-
+    pure fn map_default<U>(def: U, f: fn(x: &T) -> U) -> U
+        { map_default(self, move def, f) }
     /// Performs an operation on the contained value by reference
-    #[inline(always)]
-    pure fn iter(&self, f: fn(x: &T)) { iter(self, f) }
-
+    pure fn iter(f: fn(x: &T)) { iter(self, f) }
+    /// Maps a `some` value from one type to another by reference
+    pure fn map<U>(f: fn(x: &T) -> U) -> Option<U> { map(self, f) }
     /**
     Gets an immutable reference to the value inside an option.
 
@@ -276,29 +278,7 @@ impl<T> Option<T> {
     Instead, prefer to use pattern matching and handle the `None`
     case explicitly.
      */
-    #[inline(always)]
-    pure fn get_ref(&self) -> &self/T { get_ref(self) }
-
-    /**
-     * Gets the value out of an option without copying.
-     *
-     * # Failure
-     *
-     * Fails if the value equals `none`
-     */
-    #[inline(always)]
-    pure fn unwrap(self) -> T { unwrap(self) }
-
-    /**
-     * Gets the value out of an option, printing a specified message on
-     * failure
-     *
-     * # Failure
-     *
-     * Fails if the value equals `none`
-     */
-    #[inline(always)]
-    pure fn expect(self, reason: &str) -> T { expect(self, reason) }
+    pure fn get_ref() -> &self/T { get_ref(self) }
 }
 
 impl<T: Copy> Option<T> {
@@ -316,17 +296,19 @@ impl<T: Copy> Option<T> {
     Instead, prefer to use pattern matching and handle the `None`
     case explicitly.
     */
-    #[inline(always)]
-    pure fn get(self) -> T { get(self) }
-
-    #[inline(always)]
-    pure fn get_default(self, def: T) -> T { get_default(self, def) }
-
+    pure fn get() -> T { get(self) }
+    pure fn get_default(def: T) -> T { get_default(self, def) }
+    /**
+     * Gets the value out of an option, printing a specified message on
+     * failure
+     *
+     * # Failure
+     *
+     * Fails if the value equals `none`
+     */
+    pure fn expect(reason: ~str) -> T { expect(self, move reason) }
     /// Applies a function zero or more times until the result is none.
-    #[inline(always)]
-    pure fn while_some(self, blk: fn(v: T) -> Option<T>) {
-        while_some(self, blk)
-    }
+    pure fn while_some(blk: fn(v: T) -> Option<T>) { while_some(self, blk) }
 }
 
 #[test]

branches/try2/src/libcore/pipes.rs

@@ -412,7 +412,7 @@ Fails if the sender closes the connection.
 */
 pub fn recv<T: Owned, Tbuffer: Owned>(
     p: RecvPacketBuffered<T, Tbuffer>) -> T {
-    try_recv(move p).expect("connection closed")
+    option::unwrap_expect(try_recv(move p), "connection closed")
 }
 
 /** Attempts to receive a message from a pipe.
@@ -1102,7 +1102,7 @@ impl<T: Owned> PortSet<T> : GenericPort<T> {
     }
 
     fn recv() -> T {
-        self.try_recv().expect("port_set: endpoints closed")
+        option::unwrap_expect(self.try_recv(), "port_set: endpoints closed")
     }
 
 }

branches/try2/src/libcore/result.rs

@@ -114,7 +114,7 @@ pub pure fn to_either<T: Copy, U: Copy>(res: &Result<U, T>)
  *         ok(parse_bytes(buf))
  *     }
  */
-pub pure fn chain<T, U, V>(res: Result<T, V>, op: fn(T)
+pub fn chain<T, U, V>(res: Result<T, V>, op: fn(t: T)
     -> Result<U, V>) -> Result<U, V> {
     match move res {
         Ok(move t) => op(move t),
@@ -130,7 +130,7 @@ pub pure fn chain<T, U, V>(res: Result<T, V>, op: fn(T)
  * immediately returned.  This function can be used to pass through a
  * successful result while handling an error.
  */
-pub pure fn chain_err<T, U, V>(
+pub fn chain_err<T, U, V>(
     res: Result<T, V>,
     op: fn(t: V) -> Result<T, U>)
     -> Result<T, U> {
@@ -154,7 +154,7 @@ pub pure fn chain_err<T, U, V>(
  *         print_buf(buf)
  *     }
  */
-pub pure fn iter<T, E>(res: &Result<T, E>, f: fn(&T)) {
+pub fn iter<T, E>(res: &Result<T, E>, f: fn(&T)) {
     match *res {
       Ok(ref t) => f(t),
       Err(_) => ()
@@ -169,7 +169,7 @@ pub pure fn iter<T, E>(res: &Result<T, E>, f: fn(&T)) {
  * This function can be used to pass through a successful result while
  * handling an error.
  */
-pub pure fn iter_err<T, E>(res: &Result<T, E>, f: fn(&E)) {
+pub fn iter_err<T, E>(res: &Result<T, E>, f: fn(&E)) {
     match *res {
       Ok(_) => (),
       Err(ref e) => f(e)
@@ -190,7 +190,7 @@ pub pure fn iter_err<T, E>(res: &Result<T, E>, f: fn(&E)) {
  *         parse_bytes(buf)
  *     }
  */
-pub pure fn map<T, E: Copy, U: Copy>(res: &Result<T, E>, op: fn(&T) -> U)
+pub fn map<T, E: Copy, U: Copy>(res: &Result<T, E>, op: fn(&T) -> U)
   -> Result<U, E> {
     match *res {
       Ok(ref t) => Ok(op(t)),
@@ -206,7 +206,7 @@ pub pure fn map<T, E: Copy, U: Copy>(res: &Result<T, E>, op: fn(&T) -> U)
  * is immediately returned.  This function can be used to pass through a
  * successful result while handling an error.
  */
-pub pure fn map_err<T: Copy, E, F: Copy>(res: &Result<T, E>, op: fn(&E) -> F)
+pub fn map_err<T: Copy, E, F: Copy>(res: &Result<T, E>, op: fn(&E) -> F)
   -> Result<T, F> {
     match *res {
       Ok(copy t) => Ok(t),
@@ -215,55 +215,58 @@ pub pure fn map_err<T: Copy, E, F: Copy>(res: &Result<T, E>, op: fn(&E) -> F)
 }
 
 impl<T, E> Result<T, E> {
-    #[inline(always)]
     pure fn get_ref(&self) -> &self/T { get_ref(self) }
 
-    #[inline(always)]
-    pure fn is_ok(&self) -> bool { is_ok(self) }
+    pure fn is_ok() -> bool { is_ok(&self) }
 
-    #[inline(always)]
-    pure fn is_err(&self) -> bool { is_err(self) }
+    pure fn is_err() -> bool { is_err(&self) }
 
-    #[inline(always)]
-    pure fn iter(&self, f: fn(&T)) { iter(self, f) }
-
-    #[inline(always)]
-    pure fn iter_err(&self, f: fn(&E)) { iter_err(self, f) }
-
-    #[inline(always)]
-    pure fn unwrap(self) -> T { unwrap(self) }
-
-    #[inline(always)]
-    pure fn unwrap_err(self) -> T { unwrap(self) }
-
-    #[inline(always)]
-    pure fn chain<U>(self, op: fn(T) -> Result<U,E>) -> Result<U,E> {
-        chain(self, op)
+    pure fn iter(f: fn(&T)) {
+        match self {
+          Ok(ref t) => f(t),
+          Err(_) => ()
+        }
     }
 
-    #[inline(always)]
-    pure fn chain_err<F>(self, op: fn(E) -> Result<T,F>) -> Result<T,F> {
-        chain_err(self, op)
+    fn iter_err(f: fn(&E)) {
+        match self {
+          Ok(_) => (),
+          Err(ref e) => f(e)
+        }
     }
 }
 
 impl<T: Copy, E> Result<T, E> {
-    #[inline(always)]
-    pure fn get(&self) -> T { get(self) }
+    pure fn get() -> T { get(&self) }
 
-    #[inline(always)]
-    pure fn map_err<F:Copy>(&self, op: fn(&E) -> F) -> Result<T,F> {
-        map_err(self, op)
+    fn map_err<F:Copy>(op: fn(&E) -> F) -> Result<T,F> {
+        match self {
+          Ok(copy t) => Ok(t),
+          Err(ref e) => Err(op(e))
+        }
     }
 }
 
 impl<T, E: Copy> Result<T, E> {
-    #[inline(always)]
-    pure fn get_err(&self) -> E { get_err(self) }
+    pure fn get_err() -> E { get_err(&self) }
+
+    fn map<U:Copy>(op: fn(&T) -> U) -> Result<U,E> {
+        match self {
+          Ok(ref t) => Ok(op(t)),
+          Err(copy e) => Err(e)
+        }
+    }
+}
+
+impl<T: Copy, E: Copy> Result<T, E> {
+    fn chain<U:Copy>(op: fn(t: T) -> Result<U,E>) -> Result<U,E> {
+        // XXX: Bad copy
+        chain(copy self, op)
+    }
 
-    #[inline(always)]
-    pure fn map<U:Copy>(&self, op: fn(&T) -> U) -> Result<U,E> {
-        map(self, op)
+    fn chain_err<F:Copy>(op: fn(t: E) -> Result<T,F>) -> Result<T,F> {
+        // XXX: Bad copy
+        chain_err(copy self, op)
     }
 }
 
@@ -357,17 +360,15 @@ pub fn iter_vec2<S,T,U:Copy>(ss: &[S], ts: &[T],
 }
 
 /// Unwraps a result, assuming it is an `ok(T)`
-#[inline(always)]
-pub pure fn unwrap<T, U>(res: Result<T, U>) -> T {
+pub fn unwrap<T, U>(res: Result<T, U>) -> T {
     match move res {
       Ok(move t) => move t,
       Err(_) => fail ~"unwrap called on an err result"
     }
 }
 
 /// Unwraps a result, assuming it is an `err(U)`
-#[inline(always)]
-pub pure fn unwrap_err<T, U>(res: Result<T, U>) -> U {
+pub fn unwrap_err<T, U>(res: Result<T, U>) -> U {
     match move res {
       Err(move u) => move u,
       Ok(_) => fail ~"unwrap called on an ok result"