Skip to content

Commit cd2effe

Browse files
committed
Annotate FIXMEs (comments only)
1 parent 37ea010 commit cd2effe

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

src/librustsyntax/attr.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ fn eq(a: @ast::meta_item, b: @ast::meta_item) -> bool {
192192
}
193193
ast::meta_list(na, la) {
194194

195+
// [Fixme-sorting]
195196
// FIXME (#607): Needs implementing
196197
// This involves probably sorting the list by name and
197198
// meta_item variant
@@ -257,6 +258,7 @@ fn last_meta_item_list_by_name(
257258
/* Higher-level applications */
258259

259260
// FIXME: This needs to sort by meta_item variant in addition to the item name
261+
// (See [Fixme-sorting])
260262
fn sort_meta_items(items: [@ast::meta_item]) -> [@ast::meta_item] {
261263
fn lteq(&&ma: @ast::meta_item, &&mb: @ast::meta_item) -> bool {
262264
fn key(m: @ast::meta_item) -> ast::ident {

src/librustsyntax/ext/env.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ fn expand_syntax_ext(cx: ext_ctxt, sp: codemap::span, arg: ast::mac_arg,
2121
cx.span_fatal(sp, "malformed #env call");
2222
}
2323
// FIXME: if this was more thorough it would manufacture an
24-
// option<str> rather than just an maybe-empty string.
24+
// option<str> rather than just an maybe-empty string. (Issue #2248)
2525

2626
let var = expr_to_str(cx, args[0], "#env requires a string");
2727
alt os::getenv(var) {

src/librustsyntax/ext/expand.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ fn new_span(cx: ext_ctxt, sp: span) -> span {
9898
// FIXME: this is a terrible kludge to inject some macros into the default
9999
// compilation environment. When the macro-definition system is substantially
100100
// more mature, these should move from here, into a compiled part of libcore
101-
// at very least.
101+
// at very least. (Issue #2247)
102102

103103
fn core_macros() -> str {
104104
ret

src/librustsyntax/ext/fmt.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ fn expand_syntax_ext(cx: ext_ctxt, sp: span, arg: ast::mac_arg,
4242
// be factored out in common with other code that builds expressions.
4343
// FIXME: Cleanup the naming of these functions
4444
// NOTE: Moved many of the common ones to build.rs --kevina
45+
// See Issue #2249
4546
fn pieces_to_expr(cx: ext_ctxt, sp: span, pieces: [piece], args: [@ast::expr])
4647
-> @ast::expr {
4748
fn make_path_vec(_cx: ext_ctxt, ident: ast::ident) -> [ast::ident] {
@@ -125,7 +126,7 @@ fn pieces_to_expr(cx: ext_ctxt, sp: span, pieces: [piece], args: [@ast::expr])
125126
}
126127
fn make_new_conv(cx: ext_ctxt, sp: span, cnv: conv, arg: @ast::expr) ->
127128
@ast::expr {
128-
// FIXME: Extract all this validation into extfmt::ct
129+
// FIXME: Move validation code into core::extfmt (Issue #2249)
129130

130131
fn is_signed_type(cnv: conv) -> bool {
131132
alt cnv.ty {

src/librustsyntax/ext/simplext.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,8 @@ fn p_t_s_rec(cx: ext_ctxt, m: matchable, s: selector, b: binders) {
456456
}
457457
}
458458
}
459-
/* FIXME: handle embedded types and blocks, at least */
459+
/* FIXME: handle embedded types and blocks, at least
460+
(Issue #2251) */
460461
expr_mac(mac) {
461462
p_t_s_r_mac(cx, mac, s, b);
462463
}
@@ -715,7 +716,7 @@ fn add_new_extension(cx: ext_ctxt, sp: span, arg: ast::mac_arg,
715716
body: elts[1u]}];
716717

717718
// FIXME: check duplicates (or just simplify
718-
// the macro arg situation)
719+
// the macro arg situation) (Issue #2251)
719720
}
720721
_ {
721722
cx.span_bug(mac.span, "undocumented invariant in \

0 commit comments

Comments
 (0)