Skip to content

Commit ce577f7

Browse files
committed
Fix and re-enable some rustc tests
* Set `config.opts.trimmed_def_paths` to `GoodPath` to trim def paths in error messages as expected by the rustc test suite * Fix `$SRC_DIR` normalization for out of tree compiled standard library
1 parent 9a8da8c commit ce577f7

File tree

4 files changed

+26
-10
lines changed

4 files changed

+26
-10
lines changed

scripts/setup_rust_fork.sh

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,28 @@ index 887d27fd6dca4..2c2239f2b83d1 100644
5353
5454
let rustc_has_profiler_support = env::var_os("RUSTC_PROFILER_SUPPORT").is_some();
5555
56+
diff --git a/src/tools/compiletest/src/runtest.rs b/src/tools/compiletest/src/runtest.rs
57+
index 8431aa7b818..a3ff7e68ce5 100644
58+
--- a/src/tools/compiletest/src/runtest.rs
59+
+++ b/src/tools/compiletest/src/runtest.rs
60+
@@ -3489,11 +3489,7 @@ fn normalize_output(&self, output: &str, custom_rules: &[(String, String)]) -> S
61+
.join("library");
62+
normalize_path(&src_dir, "$(echo '$SRC_DIR')");
63+
64+
- if let Some(virtual_rust_source_base_dir) =
65+
- option_env!("CFG_VIRTUAL_RUST_SOURCE_BASE_DIR").map(PathBuf::from)
66+
- {
67+
- normalize_path(&virtual_rust_source_base_dir.join("library"), "$(echo '$SRC_DIR')");
68+
- }
69+
+ normalize_path(&Path::new("$(cd ../build_sysroot/sysroot_src/library; pwd)"), "$(echo '$SRC_DIR')");
70+
71+
// Paths into the build directory
72+
let test_build_dir = &self.config.build_base;
5673
EOF
5774

5875
cat > config.toml <<EOF
76+
changelog-seen = 2
77+
5978
[llvm]
6079
ninja = false
6180

scripts/test_rustc_tests.sh

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,7 @@ rm -r src/test/run-make/emit-named-files # requires full --emit support
7272

7373
rm -r src/test/run-pass-valgrind/unsized-locals
7474

75-
rm src/test/ui/json-bom-plus-crlf-multifile.rs # differing warning
76-
rm src/test/ui/json-bom-plus-crlf.rs # same
7775
rm src/test/ui/intrinsics/const-eval-select-x86_64.rs # same
78-
rm src/test/ui/match/issue-82392.rs # differing error
79-
rm src/test/ui/consts/min_const_fn/address_of_const.rs # same
80-
rm src/test/ui/consts/issue-miri-1910.rs # same
81-
rm src/test/ui/generic-associated-types/bugs/issue-80626.rs # same
82-
rm src/test/ui/generic-associated-types/bugs/issue-89008.rs # same
83-
rm src/test/ui/chalkify/bugs/async.rs # same
8476
rm src/test/ui/type-alias-impl-trait/cross_crate_ice*.rs # requires removed aux dep
8577

8678
rm src/test/ui/allocator/no_std-alloc-error-handler-default.rs # missing rust_oom definition

src/base.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ use rustc_ast::InlineAsmOptions;
44
use rustc_index::vec::IndexVec;
55
use rustc_middle::ty::adjustment::PointerCast;
66
use rustc_middle::ty::layout::FnAbiOf;
7+
use rustc_middle::ty::print::with_no_trimmed_paths;
78

89
use indexmap::IndexSet;
910

@@ -258,7 +259,9 @@ fn codegen_fn_content(fx: &mut FunctionCx<'_, '_, '_>) {
258259

259260
if fx.clif_comments.enabled() {
260261
let mut terminator_head = "\n".to_string();
261-
bb_data.terminator().kind.fmt_head(&mut terminator_head).unwrap();
262+
with_no_trimmed_paths!({
263+
bb_data.terminator().kind.fmt_head(&mut terminator_head).unwrap();
264+
});
262265
let inst = fx.bcx.func.layout.last_inst(block).unwrap();
263266
fx.add_comment(inst, terminator_head);
264267
}

src/bin/cg_clif.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ use std::panic;
1313

1414
use rustc_data_structures::profiling::{get_resident_set_size, print_time_passes_entry};
1515
use rustc_interface::interface;
16-
use rustc_session::config::ErrorOutputType;
16+
use rustc_session::config::{ErrorOutputType, TrimmedDefPaths};
1717
use rustc_session::early_error;
1818
use rustc_target::spec::PanicStrategy;
1919

@@ -55,6 +55,8 @@ impl rustc_driver::Callbacks for CraneliftPassesCallbacks {
5555
config.opts.maybe_sysroot = Some(config.opts.maybe_sysroot.clone().unwrap_or_else(|| {
5656
std::env::current_exe().unwrap().parent().unwrap().parent().unwrap().to_owned()
5757
}));
58+
59+
config.opts.trimmed_def_paths = TrimmedDefPaths::GoodPath;
5860
}
5961
}
6062

0 commit comments

Comments
 (0)