Skip to content

Commit cfad341

Browse files
committed
compiletest/rmake: cleanup library search paths
1 parent f3297bc commit cfad341

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/tools/compiletest/src/runtest.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3584,14 +3584,15 @@ impl<'test> TestCx<'test> {
35843584
};
35853585
debug!(?support_lib_deps_deps);
35863586

3587-
// FIXME(jieyouxu): explain what the hecc we are doing here.
3587+
// To compile the recipe with rustc, we need to provide suitable dynamic library search
3588+
// paths to rustc. This includes both:
3589+
// 1. The "base" dylib search paths that was provided to compiletest, e.g. `LD_LIBRARY_PATH`
3590+
// on some linux distros.
3591+
// 2. Specific library paths in `self.config.compile_lib_path` needed for running rustc.
35883592

3589-
// This is the base dynamic library search paths that was made available to compiletest.
35903593
let base_dylib_search_paths =
35913594
Vec::from_iter(env::split_paths(&env::var(dylib_env_var()).unwrap()));
35923595

3593-
// We add in `self.config.compile_lib_path` which are the libraries needed to run the
3594-
// host compiler.
35953596
let host_dylib_search_paths = {
35963597
let mut paths = vec![self.config.compile_lib_path.clone()];
35973598
paths.extend(base_dylib_search_paths.iter().cloned());

0 commit comments

Comments
 (0)